Re: [PROPOSAL] Extended attributes for Posix security extensions

2000-10-24 Thread Christoph Hellwig
On Tue, Oct 24, 2000 at 01:46:49PM +0100, Stephen C. Tweedie wrote: Shure there should be lowlevel access to the eas for user-EAs or some special cases, but for the main usages (ACLs, Filesystem Capabilities, MACs) there should be a special high-level API instead. So instead of using the

Re: [PROPOSAL] Extended attributes for Posix security extensions

2000-10-26 Thread Christoph Hellwig
On Wed, Oct 25, 2000 at 02:50:32AM +0200, Andreas Gruenbacher wrote: On Tue, 24 Oct 2000, Christoph Hellwig wrote: [...] But the ACL implementation is not generic enough, IMHO. The ACL implementation is Posix 1003.1e draft standard 17 compliant. AFAIK neither of the other ACL

Re: Is address_mapping-host always (struct inode *)?

2000-11-14 Thread Christoph Hellwig
On Tue, Nov 14, 2000 at 12:04:21PM +0100, Daniel Phillips wrote: After quite a lot of grepping in 2.4.0-test10 I was unable to find any places where address_mapping-host is not (struct inode *) - are there any? I can't find one. This change was requested some time ago (Mai 2000 or so) by

Re: fs/ext2/inode.c:ext2_notify_change()

2000-11-23 Thread Christoph Hellwig
On Thu, Nov 23, 2000 at 02:28:16PM +0100, Andreas Gruenbacher wrote: On Thu, 23 Nov 2000, Stephen C. Tweedie wrote: Not if we re-enable notify_change --- if we do that, the filesystem will rely on notify_change doing the right thing in such cases. Hmmm. I don't see any use of

[ANNOUNCE] kiobuf IO mailinglist

2000-12-18 Thread Christoph Hellwig
I would like to announce a new mailinglist devoted to the development of kiobuf based IO pathes. The address is [EMAIL PROTECTED] Stephen Tweedie has also suggested to collect varoius kiobuf- related patches on that sourceforge project, so if you have such patches contact me to become

Re: [ANNOUNCE] kiobuf IO mailinglist

2000-12-19 Thread Christoph Hellwig
On Sat, Nov 18, 2000 at 02:57:18PM -0200, Andrew Clausen wrote: Christoph Hellwig wrote: I would like to announce a new mailinglist devoted to the development of kiobuf based IO pathes. The address is [EMAIL PROTECTED] Could you post the subscription address/whatever

Re: How to find mountpoint at fs mount time?

2001-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2001 at 11:48:07AM -0700, Andreas Dilger wrote: Hello Al, I was looking at adding support to ext2 (and optionally other fses) to allow it to set the "filesystem last mounted on" (s_last_mounted) field in the on-disk ext2 superblock. One reason for this is that AIX has such a

Re: [PATCH][CFT] per-process namespaces for Linux

2001-02-26 Thread Christoph Hellwig
On Mon, Feb 26, 2001 at 08:26:23AM -0800, Peter J. Braam wrote: - when you login, you get imounted into an environment where you have full priviliges (except mknod). The "/" of your environment is not a directory in the Unix tree. - in this environment the system file systems are available

[ANNOUNCE] VxFS 0.1

2001-04-14 Thread Christoph Hellwig
. VxFS is a trademark of Veritas. === author VxFS for Linux has been written by Christoph Hellwig [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED]

Re: Announcing Journaled File System (JFS) release 0.3.1 available

2001-05-09 Thread Christoph Hellwig
Hi Steve, On Wed, May 09, 2001 at 12:40:25PM -0500, Steve Best wrote: Release 0.3.1 of JFS was made available today. Drop 31 on May 9, 2001 (jfs-0.3.1.tar.gz) includes fixes to the file system and utilities. For more details about the problems fixed, please see the README. would it be

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-07-02 Thread Christoph Hellwig
On Fri, Jun 29, 2001 at 08:01:55AM -0700, Lever, Charles wrote: Fs-independent and fs-private parts are allocated separately. On systems with VNODE style interface So I'm not sure what are you talking about. actually, they're not. the fs-private implementations on these systems

ROOT_DEV usage in hostfs

2005-01-25 Thread Christoph Hellwig
Could someone explain why hosts does thnings like: if((ino-i_sb-s_dev == ROOT_DEV) (ino-i_uid == getuid())) ino-i_uid = 0; (in fs/hostfs/hostfs_kern.c:read_name()) and if(attr-ia_valid ATTR_UID){ if((dentry-d_inode-i_sb-s_dev == ROOT_DEV)

Re: ROOT_DEV usage in hostfs

2005-01-25 Thread Christoph Hellwig
It's also the last thing preventing us from exporting ROOT_DEV unexporting - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] fat: fix writev(), add aio support

2005-01-25 Thread Christoph Hellwig
This patch fixes vectored write support on fat to do the nessecary non-standard action done in write() aswell. Also adds aio support and makes read/write wrappers around the aio version. --- 1.28/fs/fat/file.c 2005-01-21 06:02:08 +01:00 +++ edited/fs/fat/file.c2005-01-25 14:10:05

Re: fishy -put_inode usage in ntfs

2005-02-10 Thread Christoph Hellwig
On Thu, Oct 14, 2004 at 02:26:45PM +0100, Anton Altaparmakov wrote: I don't like filesystem doings things like this in -put_inode at all, and indeed the plan is to get rid of -put_inode completely. Why do you need to hold an additional reference anyway? What's so special about the

Re: fishy -put_inode usage in ntfs

2005-02-10 Thread Christoph Hellwig
On Thu, Feb 10, 2005 at 02:48:26PM +, Anton Altaparmakov wrote: If the igrab() were not done, it would be possible for clear_inode to be called on the 'parent' inode whilst at the same time one or more attr inodes (belonging to this 'parent') are in use and Bad Things(TM) would happen...

Re: fishy -put_inode usage in ntfs

2005-02-10 Thread Christoph Hellwig
On Thu, Feb 10, 2005 at 02:50:02PM +, Anton Altaparmakov wrote: If the igrab() were not done, it would be possible for clear_inode to be called on the 'parent' inode whilst at the same time one or more attr inodes (belonging to this 'parent') are in use and Bad Things(TM) would

[PATCH] block new writers on frozen filesystems

2005-02-10 Thread Christoph Hellwig
When the lockfs patches went in an important bit got lost, the call in generic_file_write to put newly incoming writers to sleep when a filesystem is frozen. Nathan added back the call in the now separate XFS write patch, and the patch for the generic code is below: Index: mm/filemap.c

Re: RFC: exporting per-superblock statistics to user space

2005-03-23 Thread Christoph Hellwig
On Mon, Mar 14, 2005 at 05:16:41PM -0500, Chuck Lever wrote: we still have a need to provide iostat like statistics for NFS clients. attached are a couple of patches, against 2.6.11.3, which prototype an approach for providing this kind of data to user programs. i'd like some comment on

Re: Access content of file via inodes

2005-04-05 Thread Christoph Hellwig
On Tue, Apr 05, 2005 at 09:23:19AM +0800, Kathy KN wrote: Good day all, How do I access/read the content of the files via using inodes or blocks that belong to the inode, at sys_link and vfs_link layer? I used bmap to access the blocks that belongs to the inodes, but getting access to the

Re: [RFC] Add support for semaphore-like structure with support for asynchronous I/O

2005-04-07 Thread Christoph Hellwig
On Tue, Apr 05, 2005 at 11:46:41AM -0400, Benjamin LaHaise wrote: On Mon, Apr 04, 2005 at 01:56:35PM -0400, Trond Myklebust wrote: IOW: the current semaphore implementations really all need to die, and be replaced by a single generic version to which it is actually practical to add new

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2005 at 02:31:00AM +0100, Matthew Wilcox wrote: On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote: 'arg' is unsigned so it can never be less than zero, so testing for that is pointless and also generates a warning when building with gcc -W. This patch eliminates

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-15 Thread Christoph Hellwig
On Fri, Apr 15, 2005 at 12:29:08PM +0100, Matthew Wilcox wrote: I think Linux only complained if we're using some typedef that actually may be signed. For fcntl that 'arg' argument is unsigned and that's hardcoded in the ABI. So the check doesn't make sense at all. No, it was exactly

Re: NFS4 mount problem

2005-04-17 Thread Christoph Hellwig
On Fri, Apr 15, 2005 at 01:22:59PM -0700, David S. Miller wrote: Make a -compat_read_super() just like we have a -compat_ioctl() method for files, if you want to suggest a solution like what you describe. I don't think we should encourage filesystem writers to do such stupid things as

Re: Mount bind filehandle (Was: Re: [RFC][2.6 patch] Allow creation of new namespaces during mount system call)

2005-04-21 Thread Christoph Hellwig
On Thu, Apr 21, 2005 at 09:33:20AM +0200, Jan Hudec wrote: I think I can. And I think I can modify the proposal to something a bit more sane. The problem is: The mount should be accessible only by processes started by the authorized user, but not by other user, including root, who is

Re: [RFC][2.6 patch] Allow creation of new namespaces during mount system call

2005-04-21 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 05:23:10PM -0700, Bryan Henderson wrote: That assumes that everyone has the same stuff in the same places. I.e. that there is a universal tree with different subset hidden from different processes. But that is obviously a wrong approach - e.g. it loses ability to

Re: [RFC][PATCH 0/3] Enable atomic inode security labeling

2005-07-10 Thread Christoph Hellwig
On Fri, Jul 08, 2005 at 09:25:21AM -0400, Stephen Smalley wrote: The following patch set enables atomic security labeling of newly created inodes by altering the fs code to invoke a new LSM hook to obtain the security attribute to apply to a newly created inode and to set up the incore inode

Re: [RFC][PATCH 2/3] ext2: Enable atomic inode security labeling

2005-07-10 Thread Christoph Hellwig
On Fri, Jul 08, 2005 at 09:55:14AM -0400, Stephen Smalley wrote: +int +ext2_init_security(struct inode *inode, struct inode *dir) +{ + int err; + size_t len; + void *value; + char *name; + + err = security_inode_init_security(inode, dir, name, value, len); + if

Re: [RFC][PATCH 2/3] ext2: Enable atomic inode security labeling

2005-07-11 Thread Christoph Hellwig
On Mon, Jul 11, 2005 at 08:53:02AM -0400, Stephen Smalley wrote: Please set the xattr from security_inode_init_security by using -setxattr, that way we don't need to duplicate this code everywhere. That doesn't allow us to ensure that the setting of the xattr occurs in the same

Re: [RFC][PATCH 0/3] Enable atomic inode security labeling

2005-07-11 Thread Christoph Hellwig
On Mon, Jul 11, 2005 at 09:31:39AM -0400, Stephen Smalley wrote: I was planning on leaving the security_inode_post* hooks intact at least until the other filesystem types that support security xattrs have all been converted to use the new hook, Having these transactional guarantees just for

Re: XFS corruption on move from xscale to i686

2005-07-14 Thread Christoph Hellwig
On Thu, Jul 14, 2005 at 05:45:15PM +0300, Yura Pakhuchiy wrote: Yes, but a lof of people use older versions of compilers and suffer from this bug. I personally was very unhappy when lost my data. then host the patch somewhere and make sure to apply it. - To unsubscribe from this list: send

Re: [PATCH 2.6.13-rc3-mm2] v9fs: add fd based transport

2005-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2005 at 08:57:23AM -0500, [EMAIL PROTECTED] wrote: v9fs: add file-descriptor based transport as was requested by LANL and Plan 9 from User Space folks. Couldn't the two other transports be implemented ontop of this one using a mount helper doing the pipe or tcp setup? - To

Re: please write FAT FS to a file

2005-08-02 Thread Christoph Hellwig
On Mon, Aug 01, 2005 at 08:26:15PM +0530, Mukund JB. wrote: Dear all, ? I have requirement of writing a FAT12 fs a file. I hope there are some exiting applications that write FAT12 to a file. Can someone help guiding me to the correct place? use the loop driver. See the losetup manpage for

Re: [RFC][PATCH] Generic fallback for security xattrs

2005-08-19 Thread Christoph Hellwig
On Fri, Aug 19, 2005 at 01:57:56PM -0400, Stephen Smalley wrote: This is a request for comments (only) on the patch below that modifies the VFS setxattr, getxattr, and listxattr code to fall back to the security module for security xattrs if the filesystem does not support xattrs natively.

Re: Kernel bug: Bad page state: related to generic symlink code and mmap

2005-08-19 Thread Christoph Hellwig
On Fri, Aug 19, 2005 at 07:02:18PM +0100, Al Viro wrote: On Fri, Aug 19, 2005 at 05:53:32PM +0100, Al Viro wrote: I'm taking NFS helpers to libfs.c and switching ncpfs to them. IMO that's better than copying the damn thing and other network filesystems might have the same needs

Re: Kernel bug: Bad page state: related to generic symlink code and mmap

2005-08-19 Thread Christoph Hellwig
On Fri, Aug 19, 2005 at 08:43:06PM +0100, Al Viro wrote: On Fri, Aug 19, 2005 at 08:41:29PM +0100, Matthew Wilcox wrote: is getting crowded. Linus, do you have any objections to that or suggestions on filename here? fs/symlink.c? Or fs/lib/symlink.c... That's a very good idea.

Re: [EMAIL PROTECTED]: Re: [Linux-cluster] Re: [PATCH 1/3] dlm: use configfs]

2005-08-24 Thread Christoph Hellwig
BTW, from where I sit, ocfs2 is on hold due to some additional work which hch identified when I was on vacation and not paying much attention. vma walk, perhaps? I don't know of anything that should put it on hold. Copying Mark on this. Mark? (cc hch) On 10 Aug

Re: [EMAIL PROTECTED]: Re: [Linux-cluster] Re: [PATCH 1/3] dlm: use configfs]

2005-08-25 Thread Christoph Hellwig
On Thu, Aug 25, 2005 at 11:45:14AM -0700, Zach Brown wrote: Yeah, we aim to simplify this code. For the record, it wasn't buffered aio that was the problem. There were two naughty moving parts: First, trying not to block in the dlm when issuing aio ops and tracking state to restart after

Re: GFS, what's remaining

2005-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2005 at 03:49:18PM +0100, Alan Cox wrote: - Why GFS is better than OCFS2, or has functionality which OCFS2 cannot possibly gain (or vice versa) - Relative merits of the two offerings You missed the important one - people actively use it and have been for some years.

Re: GFS, what's remaining

2005-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2005 at 04:28:30PM +0100, Alan Cox wrote: That's GFS. The submission is about a GFS2 that's on-disk incompatible to GFS. Just like say reiserfs3 and reiserfs4 or ext and ext2 or ext2 and ext3 then. I think the main point still stands - we have always taken multiple file

Re: [RFC] [PATCH] Stacking support for inode_init_security

2005-09-06 Thread Christoph Hellwig
On Fri, Aug 19, 2005 at 03:47:12PM -0500, [EMAIL PROTECTED] wrote: The following patch changes the (new to -mm) inode_init_security function to support multiple LSMs. It does this by placing the three passed arguments (name, value, len) into a structure, and passing in a list_head, onto which

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-11-27 Thread Christoph Hellwig
What crack do you guys have been smoking? On Mon, Nov 27, 2006 at 09:34:05PM -0700, Gary Grider wrote: NFS developers, a group of people from the High End Computing Interagency Working Group File Systems and I/O (HECIWG FSIO), which is a funding oversight group for file systems and

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-11-29 Thread Christoph Hellwig
Please don't repeat the stupid marketroid speach. If you want this to go anywhere please get someone with an actual clue to talk to us instead of you. Thanks a lot. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-11-30 Thread Christoph Hellwig
On Wed, Nov 29, 2006 at 12:26:22AM -0800, Brad Boyer wrote: For a more extreme case, hfs and hfsplus don't even have a separation between directory entries and inode information. The code creates this separation synthetically to match the expectations of the kernel. During a readdir(), the

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-11-30 Thread Christoph Hellwig
On Wed, Nov 29, 2006 at 10:25:07AM +, Steven Whitehouse wrote: I agree that this is a good plan, but I'd been looking at this idea from a different direction recently. The in kernel NFS server calls vfs_getattr from its filldir routine for readdirplus and this means not only are we unable

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-12-05 Thread Christoph Hellwig
On Mon, Dec 04, 2006 at 09:44:08PM -0700, Gary Grider wrote: The one use that some users talk about is just knowing the file is growing is important and useful to them, knowing exactly to the byte how much growth seems less important to them until they close. On these big parallel apps, so

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-12-05 Thread Christoph Hellwig
I'd like to Cc Ulrich Drepper in this thread because he's going to decide what APIs will be exposed at the C library level in the end, and he also has quite a lot of experience with the various standardization bodies. Ulrich, this in reply to these API proposals:

openg

2006-12-06 Thread Christoph Hellwig
On Tue, Dec 05, 2006 at 03:44:31PM -0600, Rob Ross wrote: The openg() really just does the lookup and permission checking). The openfh() creates the file descriptor and starts that context if the particular FS tracks that sort of thing. ... Well you've caught me. I don't want to cache the

Re: openg

2006-12-06 Thread Christoph Hellwig
On Wed, Dec 06, 2006 at 09:42:47AM -0600, Rob Ross wrote: The fh_t is indeed a type of capability. fh_t, properly protected, could be passed into user space and validated by the file system when presented back to the file system. Well, there's quite a lot of papers on how to implement

Re: openg and path_to_handle

2006-12-06 Thread Christoph Hellwig
On Wed, Dec 06, 2006 at 03:09:10PM -0700, Andreas Dilger wrote: While it could do that, I'd be interested to see how you'd construct the handle such that it's immune to a malicious user tampering with it, or saving it across a reboot, or constructing one from scratch. If the server has to

Re: [PATCH 1/10] lockd: add new export operation for nfsv4/lockd locking

2006-12-15 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 06:04:42PM -0500, J. Bruce Fields wrote: By the way, one other issue I think we'll need to resolve: On Wed, Dec 06, 2006 at 12:34:11AM -0500, J. Bruce Fields wrote: +/** + * vfs_cancel_lock - file byte range unblock lock + * @filp: The file to apply the unblock to

Re: [RFC] Heads up on a series of AIO patchsets

2006-12-27 Thread Christoph Hellwig
On Wed, Dec 27, 2006 at 09:08:56PM +0530, Suparna Bhattacharya wrote: (2) Most of these other applications need the ability to process both network events (epoll) and disk file AIO in the same loop. With POSIX AIO they could at least sort of do this using signals (yeah, and all

Re: [FSAIO][PATCH 6/8] Enable asynchronous wait page and lock page

2006-12-28 Thread Christoph Hellwig
On Thu, Dec 28, 2006 at 02:11:49PM +0530, Suparna Bhattacharya wrote: -extern void FASTCALL(lock_page_slow(struct page *page)); +extern int FASTCALL(__lock_page_slow(struct page *page, wait_queue_t *wait)); extern void FASTCALL(__lock_page_nosync(struct page *page)); extern void

Re: [FSAIO][PATCH 6/8] Enable asynchronous wait page and lock page

2007-01-02 Thread Christoph Hellwig
On Thu, Dec 28, 2006 at 08:17:17PM +0530, Suparna Bhattacharya wrote: I am really bad with names :( I tried using the _wq suffixes earlier and that seemed confusing to some, but if no one else objects I'm happy to use that. I thought aio_lock_page() might be misleading because it is

Re: [FSAIO][PATCH 7/8] Filesystem AIO read

2007-01-02 Thread Christoph Hellwig
On Thu, Dec 28, 2006 at 08:48:30PM +0530, Suparna Bhattacharya wrote: Yes, we can do that -- how about aio_restarted() as an alternate name ? Sounds fine to me. Pluse possible naming updates discussed in the last mail. Also do we really need to pass current-io_wait here? Isn't the

Re: [PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-08 Thread Christoph Hellwig
this doesn't look like a full first class flag to me yet. Don't we need to check for buffer_unwritten in the places we're checking for buffer_delay so we can stop setting buffer_delay for unwritten buffers? - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Christoph Hellwig
On Tue, Jan 09, 2007 at 05:43:33AM -0500, Josef Sipek wrote: RAIF is another fan-out stackable fs with much more complex logic. (Just the other day, I saw an announcement for a new version on fsdevel.) I didn't say none exist, but rather none is useful. While RAIF is definitly an excellent

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Christoph Hellwig
On Tue, Jan 09, 2007 at 05:43:33AM -0500, Josef Sipek wrote: I think that's an very important point. We have a chance to get that non-fanout filesystems right quite easily - something I wished that would have been done before the ecryptfs merge - while getting fan-out stackable

Re: [PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-09 Thread Christoph Hellwig
On Tue, Jan 09, 2007 at 10:57:45AM +1100, David Chinner wrote: On Mon, Jan 08, 2007 at 10:54:02PM +, Christoph Hellwig wrote: this doesn't look like a full first class flag to me yet. Don't we need to check for buffer_unwritten in the places we're checking for buffer_delay so we can

Re: [PATCH 1 of 2]: Make BH_Unwritten a first class bufferhead flag V2

2007-01-10 Thread Christoph Hellwig
The two patches look good to me. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] make static counters in new_inode and iunique be 32 bits

2007-01-10 Thread Christoph Hellwig
On Mon, Jan 08, 2007 at 03:47:07PM -0500, Jeff Layton wrote: When a 32-bit program that was not compiled with large file offsets does a stat and gets a st_ino value back that won't fit in the 32 bit field, glibc (correctly) generates an EOVERFLOW error. We can't do anything about fs's with

Re: [PATCH 2/3] change libfs sb creation routines to avoid collisions with their root inodes

2007-01-10 Thread Christoph Hellwig
On Mon, Jan 08, 2007 at 03:47:13PM -0500, Jeff Layton wrote: This changes the superblock creation routines that call new_inode to take steps to avoid later collisions with other inodes that get created. I took the approach here of not hashing things unless is was strictly necessary, though

Re: [PATCH 3/3] have pipefs ensure i_ino uniqueness by calling iunique and hashing the inode

2007-01-10 Thread Christoph Hellwig
On Mon, Jan 08, 2007 at 03:47:17PM -0500, Jeff Layton wrote: This converts pipefs to use the new scheme. Here we're calling iunique to get a unique i_ino value for the new inode, and then hashing it afterward. We call iunique with a max_reserved value of 1 to avoid collision with the root

Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

2007-01-15 Thread Christoph Hellwig
On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote: Convert code using iocb-ki_left to use the more generic iov_length() call. No way. We need to reduce the numer of iovec traversals, not adding more of them. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-15 Thread Christoph Hellwig
On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote: This series is an attempt to generalize the async I/O paths to be implementation agnostic. It completely eliminates knowledge of the kiocb structure in the generic code and makes it private within the current aio code. Things get

Re: [PATCH 3/3] pipefs and sockfs respin -- make .drop_inode = generic_delete_inode

2007-01-22 Thread Christoph Hellwig
On Mon, Jan 22, 2007 at 09:16:06AM -0500, Jeff Layton wrote: A little late since I sent some patches to akpm already, but I'm thinking that this might be the better way to go. Rather than trying to have the filesystems manage i_nlink, just make drop_inode for the filesystems be

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 03:37:42PM -0500, Josef 'Jeff' Sipek wrote: The only fields that we have to watch out for are the dentry and vfsmount. Additionally, this makes Unionfs gentler on the stack as nameidata is rather large. That's onviously not true at all. To handle any filesystems using

Re: [PATCH] make iunique use a do/while loop rather than its obscure goto loop

2007-01-31 Thread Christoph Hellwig
On Tue, Jan 30, 2007 at 10:45:54AM -0500, Jeffrey Layton wrote: While working on a case, Christoph mentioned that he thought that iunique ought to be cleaned up to use a more conventional loop construct. This patch does that, turning the strange goto loop into a do/while. Signed-off-by: Jeff

Re: asynchronous locks for cluster exports

2007-02-03 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 12:30:55AM -0500, J. Bruce Fields wrote: The gfs2 implementation in the last patch is (unfortunately) still just a rough draft that needs some more thought and some testing. So what exactly in this patch is tested? - To unsubscribe from this list: send the line

Re: [PATCH 3/14] locks: factor out generic/filesystem switch from setlock code

2007-02-03 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 12:33:59AM -0500, J. Bruce Fields wrote: + */ +int vfs_lock_file(struct file *filp, unsigned int cmd, struct file_lock *fl) +{ + if (filp-f_op filp-f_op-lock) + return filp-f_op-lock(filp, cmd, fl); + else + return

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Christoph Hellwig
On Sun, Feb 04, 2007 at 11:15:29AM +0100, Nick Piggin wrote: Cool, a kernel thread is calling sys_write. Fun. There are tons of places where we possible call into -write from either kernel threads or at least with a kernel pointer and set_fs/set_ds magic. Anything in the buffer write path that

[PATCH[RFC] kill sysrq-u (emergency remount r/o)

2007-02-05 Thread Christoph Hellwig
Hi there, in two recent discussions (file_list_lock scalability and remount r/o on suspend) I stumbled over this emergency remount feature. It's not actually useful because it tries a potentially dangerous remount despite writers still beeing in progress, which we can't get rid. I've attached

[PATCH[RFC] don't force remount in sysrq-u (emergency remount r/o)

2007-02-05 Thread Christoph Hellwig
On Mon, Feb 05, 2007 at 06:32:47PM +0100, Christoph Hellwig wrote: Hi there, in two recent discussions (file_list_lock scalability and remount r/o on suspend) I stumbled over this emergency remount feature. It's not actually useful because it tries a potentially dangerous remount despite

[PATCH] move remove_dquot_ref to dqout.c

2007-02-05 Thread Christoph Hellwig
Remove_dquot_ref can move to dqout.c instead of beeing in inode.c under #ifdef CONFIG_QUOTA. Also clean the resulting code up a tiny little bit by testing sb-dq_op earlier - it's constant over a filesystems lifetime. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-05 Thread Christoph Hellwig
On Mon, Feb 05, 2007 at 10:58:26AM -0800, Trond Myklebust wrote: On Mon, 2007-02-05 at 18:44 +, Christoph Hellwig wrote: Just FYI: Al was very opposed to the idea of passing the vfsmount to the vfs_ helpers, so you should discuss this with him. Looking at the actual patches I see

Re: [PATCH[RFC] kill sysrq-u (emergency remount r/o)

2007-02-06 Thread Christoph Hellwig
On Mon, Feb 05, 2007 at 10:17:44PM -0500, Theodore Tso wrote: sysrq+u is helpful. It is like \( sysrq+s make sure no further writes go to disk \). I agree it is useful, but if we're going to do it we really should do it right. We should have real revoke() functionality on file

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-06 Thread Christoph Hellwig
On Tue, Feb 06, 2007 at 12:51:52AM -0800, Trond Myklebust wrote: Who cares? There is no way to export a partial directory, and in any case the subtree_check crap is borken beyond repair (see cross-directory renames which lead to actual changes to the filehandle - broken, broken, broken).

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-06 Thread Christoph Hellwig
On Mon, Feb 05, 2007 at 06:13:26PM -0800, Andreas Gruenbacher wrote: On Monday 05 February 2007 10:44, Christoph Hellwig wrote: Looking at the actual patches I see you're lazy in a lot of places. Please make sure that when you introduce a vfsmount argument somewhere that it is _always_

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-06 Thread Christoph Hellwig
On Tue, Feb 06, 2007 at 09:26:14PM +1100, Neil Brown wrote: What would be the benefit of having private non-visible vfsmounts? Sounds like a recipe for confusion? It is possible that mountd might start doing bind-mounts to create the 'pseudo filesystem' thing for NFSv4, but they would be

[PATCH] remove sb-s_files and file_list_lock usage in dquot.c

2007-02-06 Thread Christoph Hellwig
to dqout.c' which I sent out yesterday. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/dquot.c === --- linux-2.6.orig/fs/dquot.c 2007-02-05 18:54:36.0 +0100 +++ linux-2.6/fs/dquot.c2007-02-05 18:59

Re: [PATCH] remove sb-s_files and file_list_lock usage in dquot.c

2007-02-06 Thread Christoph Hellwig
On Tue, Feb 06, 2007 at 03:50:01PM -0800, Andrew Morton wrote: On Tue, 6 Feb 2007 14:23:33 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: static void add_dquot_ref(struct super_block *sb, int type) { - struct list_head *p; + struct inode *inode; restart

Re: [PATCH] remove sb-s_files and file_list_lock usage in dquot.c

2007-02-07 Thread Christoph Hellwig
On Wed, Feb 07, 2007 at 07:03:05PM +0100, Jan Engelhardt wrote: With filesystems that can turn on their quota after mount time (about every fs except xfs), I can surely have a ton of files open, and hence, if I understand correctly, have lots of inodes instantiated. Yes, you can in theory.

Re: [patch 1/3] fs: add an iovec iterator

2007-02-08 Thread Christoph Hellwig
On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: Add an iterator data structure to operate over an iovec. Add usercopy operators needed by generic_file_buffered_write, and convert that function over. iovec_iterator is an awfully long and not very descriptive name. In past

[PATCH] affs: implement -drop_inode

2007-02-10 Thread Christoph Hellwig
advantage of this. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/affs/affs.h === --- linux-2.6.orig/fs/affs/affs.h 2007-01-30 16:36:52.0 +0100 +++ linux-2.6/fs/affs/affs.h2007-02-11 08:43

Re: [RFC] Heads up on sys_fallocate()

2007-03-01 Thread Christoph Hellwig
On Fri, Mar 02, 2007 at 12:04:45AM +0530, Amit K. Arora wrote: This is to give a heads up on few patches that we will be soon coming up with. These patches implement a new system call sys_fallocate() and a new inode operation fallocate, for persistent preallocation. The new system call, as

Re: [RFC] Heads up on sys_fallocate()

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 10:44:16PM +, Dave Kleikamp wrote: Would EINVAL (or whatever) make it back to the caller of posix_fallocate(), or would glibc fall back to its current implementation? Forgive me if I haven't put enough thought into it, but would it be useful to create a

Re: [RFC] Heads up on sys_fallocate()

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 05:29:15PM -0600, Eric Sandeen wrote: Amit K. Arora wrote: Might want more error checking in there, something like (rough cut)... (or is some of this glibc's job?) Yeah, we need to have this checks. We can't rely on userspace not passing arguments that might corrupt

Re: [RFC] Heads up on sys_fallocate()

2007-03-04 Thread Christoph Hellwig
On Sun, Mar 04, 2007 at 08:11:17PM +, Anton Altaparmakov wrote: glibc cannot ever be smart enough because a file system driver will always know better and be able to do things in a much more optimized way. Please read the thread again. That is not what anyone proposed. The issues

Re: [RFC] Heads up on sys_fallocate()

2007-03-05 Thread Christoph Hellwig
On Sat, Mar 03, 2007 at 11:45:32PM +0100, Arnd Bergmann wrote: I'd be more happy to have the write out zeroes loop in glibc. ?And glibc needs to have it anyway, for older kernels. A generic_fallocate makes sense to me iff we can do it in the kernel more significantly more efficiently than

Re: [RFC] Heads up on sys_fallocate()

2007-03-05 Thread Christoph Hellwig
On Mon, Mar 05, 2007 at 07:15:33AM -0800, Ulrich Drepper wrote: Theodore Tso wrote: Given that glibc already has to support this for older kernels, I would argue that there's no point putting in generic support for filesystem that can't support a more advanced way of doing things. Well,

Re: [RFC] Heads up on sys_fallocate()

2007-03-05 Thread Christoph Hellwig
On Mon, Mar 05, 2007 at 12:02:59PM -0800, Mingming Cao wrote: Yep, I think it makes sense to use preallocation for defragmentation. After all both preallocation and defragmentation shall call underlying filesystem multiple block allocator to try to allocate a chunk of contiguous blocks on

Re: [RFC] Heads up on sys_fallocate()

2007-03-06 Thread Christoph Hellwig
On Tue, Mar 06, 2007 at 06:36:09AM -0800, Ulrich Drepper wrote: Christoph Hellwig wrote: fallocate with the whence argument and flags is already quite complicated, I'd rather have another call for placement decisions, that would be called on an fd to do placement decissions for any further

[PATCH] vfs: remove superflous sb == NULL checks

2007-03-07 Thread Christoph Hellwig
inode-i_sb is always set, not need to check for it. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/inode.c === --- linux-2.6.orig/fs/inode.c 2007-02-24 10:37:57.0 +0100 +++ linux-2.6/fs/inode.c

[PATCH] namei.c: remove utterly outdated comment

2007-03-07 Thread Christoph Hellwig
We don't have a routine called namei() anymore since at least 2.3.x, and the comment is just totally out of sync with the current lookup logic. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/namei.c

Re: [patch 2/3] fs: introduce perform_write aop

2007-03-09 Thread Christoph Hellwig
Hi Nick, sorry for my later reply, this has been on my to answer list for the last month and I only managed to get back to it now. On Thu, Feb 08, 2007 at 02:07:36PM +0100, Nick Piggin wrote: Add a new perform_write aop, which replaces prepare_write and commit_write as a single call to copy a

Re: [patch 1/3] fs: add an iovec iterator

2007-03-09 Thread Christoph Hellwig
On Thu, Feb 08, 2007 at 06:03:50PM -0800, Nate Diller wrote: i had a patch integrating the iodesc idea, but after some thought, had decided to call it struct file_io. That name reflects the fact that it's doing I/O in arbitrary lengths with byte offsets, and struct file_io *fio contrasts well

Re: [PATCH 1/4]: ufs2 more correct work with time

2007-03-10 Thread Christoph Hellwig
On Sat, Mar 10, 2007 at 12:30:02PM +0300, Evgeniy Dushistov wrote: This patch corrects work with time in UFS2 case. 1)According to UFS2 disk layout modification/access and so on time should be hold in two variables one 64bit for seconds and another 32bit for nanoseconds, at now for some

Re: impact of 4k sector size on the IO FS stack

2007-03-12 Thread Christoph Hellwig
On Sun, Mar 11, 2007 at 06:51:53PM -0400, Ric Wheeler wrote: During the recent IO/FS workshop, we spoke briefly about the coming change to a 4k sector size for disks on linux. If I recall correctly, the general feeling was that the impact was not significant since we already do most file

Re: impact of 4k sector size on the IO FS stack

2007-03-12 Thread Christoph Hellwig
On Mon, Mar 12, 2007 at 10:45:16AM -0400, Jeff Garzik wrote: Christoph Hellwig wrote: the occasional 2k sector SCSI MO device aswell. It would be nice to get samples of large sector size ATA devices into the hands of developers to do real world testing of the whole stack. hands

Re: [patch 2/3] fs: introduce perform_write aop

2007-03-14 Thread Christoph Hellwig
On Wed, Mar 14, 2007 at 02:30:24PM +0100, Nick Piggin wrote: So I've tried a different approach - the 2-op API rather than an actor. perform_write stays around as a higher performance API, but it isn't required if the filesystem implements the 2-op API. I've called them write_begin/write_end

  1   2   3   4   >