Re: Unionfs: Stackable namespace unification filesystem

2006-12-05 Thread Josef Sipek
On Mon, Dec 04, 2006 at 07:30:33AM -0500, Josef 'Jeff' Sipek wrote: The following patches are in a git repo at: git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/unionfs.git (master.kernel.org:/pub/scm/linux/kernel/git/jsipek/unionfs.git) The repository contains the following 35

Re: [RFC][PATCH] Secure Deletion and Trash-Bin Support for Ext4

2006-12-06 Thread Josef Sipek
On Wed, Dec 06, 2006 at 08:11:00PM +1100, David Chinner wrote: They are defined but unused in 2.6.19, right? I can't see anywhere in the 2.6.19 ext2/3/4/reiser trees that actually those flags, including setting and retrieving them from disk. JFS i can see sets, clears and retreives them, but

Re: [RFC][PATCH] Secure Deletion and Trash-Bin Support for Ext4

2006-12-06 Thread Josef Sipek
On Thu, Dec 07, 2006 at 12:44:27PM +1100, David Chinner wrote: Maybe we should be using EAs for this sort of thing instead of flags on the inode? If we keep adding inode flags for generic features then we are going to force more than just XFS into inode format changes eventually Aren't

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-06 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:50:13PM -0500, Josef Sipek wrote: On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: +#include union.h + +struct workqueue_struct *sioq; + +int __init init_sioq(void) Although it's just me

Re: [RFC][PATCH] Secure Deletion and Trash-Bin Support for Ext4

2006-12-06 Thread Josef Sipek
On Wed, Dec 06, 2006 at 07:14:58PM -0800, Nicholas Miell wrote: On Thu, 2006-12-07 at 13:49 +1100, David Chinner wrote: On Wed, Dec 06, 2006 at 09:35:30PM -0500, Josef Sipek wrote: On Thu, Dec 07, 2006 at 12:44:27PM +1100, David Chinner wrote: Maybe we should be using EAs for this sort

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 08:08:03AM -0500, Jeff Layton wrote: Josef Sipek wrote: - ret = simple_fill_super(sb, IPATHFS_MAGIC, files); + ret = simple_fill_super(sb, IPATHFS_MAGIC, files, 1); I don't know...the magic looking 1 and 0 (later in the patch) seem a bit arbitrary. Maybe

Re: Is a NULL check missing in nfs_lookup?

2007-01-04 Thread Josef Sipek
On Thu, Jan 04, 2007 at 07:47:34PM -0500, Shaya Potter wrote: yes, you're writing a stackable file system (the cs.sunysb gives that away) and have run a lookup_one_len() on a nfs mounted file system and that means nd is null. Erez's group is trying to fix that situation so the intents can be

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 02:02:24PM -0800, Andrew Morton wrote: On Mon, 08 Jan 2007 16:30:48 -0500 Shaya Potter [EMAIL PROTECTED] wrote: On Mon, 2007-01-08 at 13:19 -0800, Andrew Morton wrote: On Mon, 8 Jan 2007 14:43:39 -0500 (EST) Shaya Potter [EMAIL PROTECTED] wrote: It's the

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 05:00:18PM -0600, Michael Halcrow wrote: On Mon, Jan 08, 2007 at 03:51:31PM -0500, Erez Zadok wrote: BTW, this is a problem with all stackable file systems, including ecryptfs. To be fair, our Unionfs users have come up against this problem, usually for the first

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Tue, Jan 09, 2007 at 01:19:48AM +0100, Giuseppe Bilotta wrote: As a simple user without much knowledge of kernel internals, much less so filesystems, couldn't something based on the same principle of lsof+fam be used to handle these situations? Using inotify has been suggested before. That

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:49:35AM +, Christoph Hellwig wrote: On Mon, Jan 08, 2007 at 06:25:16PM -0500, Josef Sipek wrote: There's no such problem with bind mounts. It's surprising to see such a restriction with union mounts. Bind mounts are a purely VFS level construct. Unionfs

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:53:45AM +, Christoph Hellwig wrote: On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: However, I must caution that a file system like ecryptfs is very different from Unionfs, the latter being a fan-out file system---and both have very different

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-10 Thread Josef Sipek
On Wed, Jan 10, 2007 at 05:12:15PM +0100, Jan Kara wrote: I see :). To me it just sounds as if you want to do remount-read-only for source filesystems, which is operation we support perfectly fine, and after that create union mount. But I agree you cannot do quite that since you need to have

Re: Unionfs in -mm

2007-01-12 Thread Josef Sipek
On Tue, Jan 09, 2007 at 03:08:57PM -0500, Jason Lunz wrote: ... But I have a bug to report. I'm trying out yesterday's 24-patch series on 2.6.20-rc4 (http://thread.gmane.org/gmane.linux.kernel/481661). The root filesystem is a union of a ro squashfs and a rw tmpfs. The initramfs sets it up

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Josef Sipek
On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote: ... diff -Nurp linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h linux/fs/jfs/jfs_lock.h --- linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h2006-11-29 15:57:37.0 -0600 +++ linux/fs/jfs/jfs_lock.h 2007-01-17 15:30:19.0 -0600 @@

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-30 Thread Josef Sipek
On Tue, Jan 30, 2007 at 09:42:33AM +, Christoph Hellwig wrote: On Mon, Jan 29, 2007 at 03:37:42PM -0500, Josef 'Jeff' Sipek wrote: The only fields that we have to watch out for are the dentry and vfsmount. Additionally, this makes Unionfs gentler on the stack as nameidata is rather

Re: [PATCH 1/2] eCryptfs: convert lookup_one_len() to lookup_one_len_nd()

2007-03-09 Thread Josef Sipek
On Fri, Mar 09, 2007 at 09:40:00AM +, Christoph Hellwig wrote: On Sat, Feb 17, 2007 at 03:56:55AM -0500, Josef 'Jeff' Sipek wrote: From: Michael Halcrow [EMAIL PROTECTED] Call the new lookup_one_len_nd() rather than lookup_one_len(). This fixes an oops when stacked on NFS.

Re: [PATCH] unionfs: sioq not __exit

2007-03-19 Thread Josef Sipek
On Mon, Mar 19, 2007 at 03:22:26PM -0700, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] stop_sioq() is called from both __init and __exit functions, so it shouldn't be marked __exit. Reported on the kernelnewbies mailing list, but no patch offered there. Signed-off-by: Randy

Re: [GIT PULL -mm] Unionfs branch management code

2007-04-09 Thread Josef Sipek
On Mon, Apr 09, 2007 at 10:49:48AM -0700, Andrew Morton wrote: On Mon, 9 Apr 2007 10:53:51 -0400 Josef 'Jeff' Sipek [EMAIL PROTECTED] wrote: The following patches introduce new branch-management code into Unionfs as well as fix a number of stability issues and resource leaks. First, a

Re: [GIT PULL -mm] Unionfs branch management code

2007-04-10 Thread Josef Sipek
On Tue, Apr 10, 2007 at 01:22:52PM -0400, Shaya Potter wrote: Andrew Morton wrote: On Mon, 9 Apr 2007 10:53:51 -0400 Josef 'Jeff' Sipek [EMAIL PROTECTED] wrote: The following patches introduce new branch-management code into Unionfs as well as fix a number of stability issues and resource

[PATCH 0/1] [RFC] New mode for path_lookup (V1)

2007-04-29 Thread Josef Sipek
Stackable file systems frequently need to lookup paths or path components starting from an arbitrary point in the namespace (identified by a dentry and a vfsmount). Currently, such file systems use lookup_one_len, which is frowned upon [1] as it does not pass the lookup intent along; not passing

[PATCH 1/1] fs: add 4th case to do_path_lookup

2007-04-29 Thread Josef Sipek
Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] diff --git a/fs/namei.c b/fs/namei.c index 2995fba..1516a9b 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1125,6 +1125,10 @@ static int fastcall do_path_lookup(int dfd, const char *name, nd-mnt = mntget(fs-rootmnt);

Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup

2007-05-06 Thread Josef Sipek
On Sun, May 06, 2007 at 12:11:24PM +0100, Christoph Hellwig wrote: On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] unionfs section mismatch

2007-06-06 Thread Josef Sipek
On Wed, Jun 06, 2007 at 02:51:02PM -0700, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Applied. Thanks. Josef Jeff Sipek. -- Don't drink and derive. Alcohol and algebra don't mix. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message

Re: [RFC PATCH 2/4] Mount changes to support union mount.

2007-06-21 Thread Josef Sipek
On Wed, Jun 20, 2007 at 02:23:30PM +0530, Bharata B Rao wrote: (replying from a different ID as you didn't copy me on reply) On 6/20/07, Jan Blunck [EMAIL PROTECTED] wrote: On Wed, 20 Jun 2007 11:22:41 +0530, Bharata B Rao wrote: +/* + * When propagating mount events to peer group, this

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Josef Sipek
On Wed, Aug 01, 2007 at 10:23:29AM -0500, Dave Kleikamp wrote: On Tue, 2007-07-31 at 13:11 -0400, Josef Sipek wrote: On Tue, Jul 31, 2007 at 07:00:12PM +0200, Jan Blunck wrote: On Tue, Jul 31, Josef Sipek wrote: On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote