On Thu, Jun 04, 2015 at 10:54:03AM +0800, Chaotian Jing wrote:
> On Tue, 2015-05-19 at 13:15 +0200, Sascha Hauer wrote:
> > On Tue, May 19, 2015 at 02:36:46PM +0800, Chaotian Jing wrote:
> > > Add Mediatek MMC driver code
> > > Support eMMC/SD/SDIO
> > >
> > > Signed-off-by: Chaotian Jing
> > > -
On 27 May 2015 at 13:34, Chaotian Jing wrote:
> On Tue, 2015-05-26 at 14:33 +0200, Ulf Hansson wrote:
>> [...]
>>
>> >> >> > +{
>> >> >> > + unsigned long tmo = jiffies + msecs_to_jiffies(20);
>> >> >> > +
>> >> >> > + while ((readl(host->base + SDC_STS) & SDC_STS_CMDBUSY)
>> >> >> > +
[...]
>> >> > +{
>> >> > + unsigned long tmo = jiffies + msecs_to_jiffies(20);
>> >> > +
>> >> > + while ((readl(host->base + SDC_STS) & SDC_STS_CMDBUSY)
>> >> > + && time_before(jiffies, tmo))
>> >> > + continue;
>> >> > +
>> >> > + if (readl(
[...]
>> You are invoking msdc_gate_clock() and msdc_ungate_clock() in a
>> balanced manner, thus hclk_enabled is redundant. Please remove it.
>
> on drv->probe(), already invoke the msdc_ungate_clock(), so, when the
> runtime pm resume invoke the msdc_ungate_clock(), the hclk already
> enabled.
