Re: [Linux-ha-dev] [patch 6/6] Remove acconfig.h

2008-10-15 Thread Simon Horman
On Wed, Oct 15, 2008 at 04:09:22PM +0200, Dejan Muhamedagic wrote: > On Wed, Oct 15, 2008 at 06:02:55PM +1100, Simon Horman wrote: > > Remove acconfig.h and instead put desriptions in configur.in > > Strange. This one I can't find either. Again, this seems to be a stale file in my tree. Patch wit

Re: [Linux-ha-dev] [patch 4/6] Remove heartbeat/hb_api_core.h and heartebat/hb_api.h

2008-10-15 Thread Simon Horman
On Wed, Oct 15, 2008 at 04:02:59PM +0200, Dejan Muhamedagic wrote: > Hi, > > On Wed, Oct 15, 2008 at 06:02:53PM +1100, Simon Horman wrote: > > It seems that heartbeat/hb_api_core.h and heartebat/hb_api.h > > are out of date copies of files in include/. I'm not sure > > why this hasn't happened bef

Re: [Linux-ha-dev] [patch 6/6] Remove acconfig.h

2008-10-15 Thread Dejan Muhamedagic
On Wed, Oct 15, 2008 at 06:02:55PM +1100, Simon Horman wrote: > Remove acconfig.h and instead put desriptions in configur.in Strange. This one I can't find either. ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailm

Re: [Linux-ha-dev] [patch 4/6] Remove heartbeat/hb_api_core.h and heartebat/hb_api.h

2008-10-15 Thread Dejan Muhamedagic
Hi, On Wed, Oct 15, 2008 at 06:02:53PM +1100, Simon Horman wrote: > It seems that heartbeat/hb_api_core.h and heartebat/hb_api.h > are out of date copies of files in include/. I'm not sure > why this hasn't happened before, but today they are causing > my build to fail. > > Removing heartbeat/hb_

Re: [Linux-ha-dev] [patch 0/6] Assorted build cleanups and fixes

2008-10-15 Thread Andrew Beekhof
Looks fine to me On Wed, Oct 15, 2008 at 09:02, Simon Horman <[EMAIL PROTECTED]> wrote: > Hi, > > I noticed a couple of things while building heartbeat > earlier today. Please let me know if there are any > objections to any of these. > > -- > Simon Horman > VA Linux Systems Japan K.K., Sydney, A

[Linux-ha-dev] Comparing Sfex with SBD

2008-10-15 Thread Xinwei Hu
Hi all, I'm thinking about to implement SBD as resource agent to support clone mode. However, it turns out to be problematic after comparison. I'd prefer to stay with current SFEX implementation and only make SCSI-3 support clone mode. May I have your comments on my analysis ? =

[Linux-ha-dev] [patch 5/6] Define liblrm_la_LDFLAGS once

2008-10-15 Thread Simon Horman
liblrm_la_LDFLAGS was multiply defined and only the second definition was being used. Consolidate this into a single definition with the side effect of actually using -version-info 2:0:0 and thus bumping the so version of librlrm from 0.0.0 to 2.0.0. Signed-off-by: Simon Horman <[EMAIL PROTECTED]>

[Linux-ha-dev] [patch 4/6] Remove heartbeat/hb_api_core.h and heartebat/hb_api.h

2008-10-15 Thread Simon Horman
It seems that heartbeat/hb_api_core.h and heartebat/hb_api.h are out of date copies of files in include/. I'm not sure why this hasn't happened before, but today they are causing my build to fail. Removing heartbeat/hb_api_core.h resolves the following warnings and errors: #make [snip] gcc -std=g

[Linux-ha-dev] [patch 0/6] Assorted build cleanups and fixes

2008-10-15 Thread Simon Horman
Hi, I noticed a couple of things while building heartbeat earlier today. Please let me know if there are any objections to any of these. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en __

[Linux-ha-dev] [patch 2/6] Add AM_PROG_CC_C_O to configure.am

2008-10-15 Thread Simon Horman
As advised by the following warning: # automake --version automake (GNU automake) 1.10.1 Copyright (C) 2008 Free Software Foundation, Inc. License GPLv2+: GNU GPL version 2 or later This is free software: you are free to change and redistribute it. There is NO WA

[Linux-ha-dev] [patch 6/6] Remove acconfig.h

2008-10-15 Thread Simon Horman
Remove acconfig.h and instead put desriptions in configur.in as the third argument to AC_DEFINE() and AC_DEFINE_UNQUOTED() as per the following warning: # autoheader autoheader (GNU Autoconf) 2.61 Copyright (C) 2006 Free Software Foundation, Inc. This is free software. You may redistribute copies

[Linux-ha-dev] [patch 1/6] "`%-style pattern rules are a GNU make extension" correction

2008-10-15 Thread Simon Horman
Use a suffix rule instead of a pattern rule, as per the following warning: # automake --version automake (GNU automake) 1.10.1 Copyright (C) 2008 Free Software Foundation, Inc. License GPLv2+: GNU GPL version 2 or later This is free software: you are free to chan

[Linux-ha-dev] [patch 3/6] Use $(top_builddir)/lib/clplumbing/libplumb.la for linking drac3

2008-10-15 Thread Simon Horman
Use $(top_builddir)/lib/clplumbing/libplumb.la instead of -lplumb when linking drac3, to make it link the same way as other users of libplub and fix the build error below. While we are at it, list the libraries that drac3 should link against in drac3_la_LIBADD instead of drac3_la_LDFLAGS # make [