Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-11 Thread Florian Haas
Just FYI, I noticed I erroneously put the asterisk changes in the master branch on my github repo; I've now moved them to a separate asterisk branch. The direct links to commits, which I posted earlier, should still work as the SHA IDs are unchanged. They just point to commits in a different

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Florian Haas
On 2011-11-09 12:02, Martin Gerhard Loschwitz wrote: Hello everybody, I wrote an asterisk OCF resource agent which I am hereby putting up for discussion. Any feedback is welcome. It's available from https://github.com/fghaas/resource-agents/blob/master/heartbeat/asterisk Let's move this

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hi, On Thu, Nov 10, 2011 at 10:27:36AM +0100, Florian Haas wrote: On 2011-11-09 12:02, Martin Gerhard Loschwitz wrote: Hello everybody, I wrote an asterisk OCF resource agent which I am hereby putting up for discussion. Any feedback is welcome. It's available from

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Lars Ellenberg
On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: Hi Dejan, thanks for the feedback! We've worked in most of your suggested changes, see below: More direct would be: if [ $? -ne 0 ]; then $? in a test is almost always an error. Because you lose the actual value it

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hey Florian, On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: Hi Dejan, thanks for the feedback! We've worked in most of your suggested changes, see below: On 2011-11-10 13:14, Dejan Muhamedagic wrote: Hi, [...] Start may exit with some arbitrary error code (line 324 in

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hi Lars, Pity I didn't see this earlier, could've saved meself some time :) On Thu, Nov 10, 2011 at 04:33:02PM +0100, Lars Ellenberg wrote: On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: Hi Dejan, thanks for the feedback! We've worked in most of your suggested changes,