Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2012-01-09 Thread Chris Bowlby
Hi Everyone, I apologize for my lack of response till now, December was a bit hectic for me. I have, however, read over your points of discussion and agree that a reasonable default, and subsequent removal of the required parameter, is mostly likely the preferred method in relation to that

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Chris Bowlby
Hi Dejan, It has been recommended, that required options should not have default values. The initial version of the script had a default for that variable, but chrooted_path was not required. During the revision's suggested by Andreas and Florian, chrooted was converted into a required, and

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Florian Haas
On Fri, Dec 9, 2011 at 6:30 AM, Dejan Muhamedagic de...@suse.de wrote: Hi, On Tue, Dec 06, 2011 at 01:39:04PM -0400, Chris Bowlby wrote: Hi All,   Ok, I'll look into csync, and will concede the point on the RA syncing the out of chrooted configuration file. I still need to find a means to

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Dejan Muhamedagic
Hi Chris, On Fri, Dec 09, 2011 at 10:33:05AM -0400, Chris Bowlby wrote: Hi Dejan, It has been recommended, that required options should not have default values. Definitely they cannot have defaults. Sorry, I should've been more precise. The initial version of the script had a default for

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Rasto Levrinc
On Fri, Dec 9, 2011 at 4:40 PM, Dejan Muhamedagic de...@suse.de wrote: Hi Chris, On Fri, Dec 09, 2011 at 10:33:05AM -0400, Chris Bowlby wrote: Hi Dejan, It has been recommended, that required options should not have default values. Definitely they cannot have defaults. Sorry, I should've

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-08 Thread Dejan Muhamedagic
Hi, On Tue, Dec 06, 2011 at 01:39:04PM -0400, Chris Bowlby wrote: Hi All, Ok, I'll look into csync, and will concede the point on the RA syncing the out of chrooted configuration file. I still need to find a means to monitor the DHCP responses however, as that will just improve the

[Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-06 Thread Chris Bowlby
Hi Everyone, I would like to thank Florian, Andreas and Dejan for making suggestions and pointing out some additional changed I should make. At this point the following additional changes have been made: - A test case in the validation function for ocf_is_probe has been reversed tp !

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-06 Thread Dejan Muhamedagic
Hi, On Tue, Dec 06, 2011 at 10:59:20AM -0400, Chris Bowlby wrote: Hi Everyone, I would like to thank Florian, Andreas and Dejan for making suggestions and pointing out some additional changed I should make. At this point the following additional changes have been made: - A test case

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-06 Thread Alan Robertson
I agree about avoiding the feature to sync config files. My typical recommendation is to use drbdlinks and put it on replicated or shared storage. In fact, I do that at home, and are doing it for a current customer. By the way, Sean has recently revised drbdlinks to support the OCF API.