Re: [AX.25] Make asc2ax thread-proof

2005-09-08 Thread David S. Miller
From: Ralf Baechle DL5RB [EMAIL PROTECTED]
Date: Wed, 7 Sep 2005 15:34:01 +0100

 Asc2ax was still using a static buffer for all invocations which isn't
 exactly SMP-safe.  Change asc2ax to take an additional result buffer as
 the argument.  Change all callers to provide such a buffer.
 
 This one only really is a fix for ROSE and as per recent discussions
 there's still much more to fix in ROSE ...
 
 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED]

Applied, thanks Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [AX.25] Make ax2asc thread-proof

2005-09-06 Thread David S. Miller
From: Ralf Baechle [EMAIL PROTECTED]
Date: Tue, 6 Sep 2005 19:12:22 +0100

 Ax2asc was still using a static buffer for all invocations which isn't
 exactly SMP-safe.  Change ax2asc to take an additional result buffer as
 the argument.  Change all callers to provide such a buffer.
 
 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED]

Applied, thanks a lot Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/3] Cleanup direct calls into IP stack

2005-08-24 Thread David S. Miller

All 3 patches queued up for 2.6.14, thanks a lot Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Fix socket bitop damage

2005-08-23 Thread David S. Miller
From: Ralf Baechle [EMAIL PROTECTED]
Date: Mon, 22 Aug 2005 12:02:18 +0100

 The socket flag cleanups that went into 2.6.12-rc1 are basically oring
 the flags of an old socket into the socket just being created.
 Unfortunately that one was just initialized by sock_init_data(), so already
 has SOCK_ZAPPED set.  As the result zapped sockets are created and all
 incoming connection will fail due to this bug which again was carefully
 replicated to at least AX.25, NET/ROM or ROSE.
 
 In order to keep the abstraction alive I've introduced sock_copy_flags()
 to copy the socket flags from one sockets to another and used that
 instead of the bitwise copy thing.  Anyway, the idea here has probably
 been to copy all flags, so sock_copy_flags() should be the right thing.
 With this the ham radio protocols are usable again, so I hope this will
 make it into 2.6.13.
 
 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED]

Applied, thanks Ralf.

-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] AX.25 UID fixes

2005-08-23 Thread David S. Miller
From: Ralf Baechle [EMAIL PROTECTED]
Date: Mon, 22 Aug 2005 12:10:38 +0100

  o Brown paperbag bug - ax25_findbyuid() was always returning a NULL pointer
as the result.  Breaks ROSE completly and AX.25 if UID policy set to deny.
 
  o While the list structure of AX.25's UID to callsign mapping table was
properly protected by a spinlock, it's elements were not refcounted
resulting in a race between removal and usage of an element.
 
 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED]

Applied, thanks Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Get rid of sk_protinfo use in rose

2005-03-23 Thread David S. Miller
On Mon, 21 Mar 2005 09:50:37 +
Ralf Baechle DL5RB [EMAIL PROTECTED] wrote:

 Below patch puts struct sock into rose_cb to get rid of the need for the
 use of sk_protinfo in rose_sk().  While we're touching the data structure
 convert it from a typedef into a struct.

Also applied, thanks Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/9] Use netdev_priv in NETROM and ROSE

2005-02-15 Thread David S. Miller
On Sun, 30 Jan 2005 21:21:47 +
Ralf Baechle DL5RB [EMAIL PROTECTED] wrote:

 Convert the NETROM and ROSE protocol stacks to use netdev_priv().

Applied, thanks Ralf.
-
To unsubscribe from this list: send the line unsubscribe linux-hams in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html