Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Neil Horman
On Tue, Apr 16, 2019 at 10:32:48PM +0200, Arnd Bergmann wrote: > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > socket protocol handlers, and all of those end up calling the same > sock_get_timestamp()/sock_get_timestampns() helper functions, which > results in a lot of

Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Willem de Bruijn
On Tue, Apr 16, 2019 at 4:38 PM Arnd Bergmann wrote: > > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > socket protocol handlers, and all of those end up calling the same > sock_get_timestamp()/sock_get_timestampns() helper functions, which > results in a lot of duplicate

Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Arnd Bergmann
On Wed, Apr 17, 2019 at 4:46 PM Willem de Bruijn wrote: > On Tue, Apr 16, 2019 at 4:38 PM Arnd Bergmann wrote: > > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > > socket protocol handlers, and all of those end up calling the same > >

Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread David Miller
From: Neil Horman Date: Wed, 17 Apr 2019 05:35:23 -0400 > Acked-by: Neil Horman Neil, please quote appropriately in the future. I have to scroll through all of those pages of quoted patch just to see this one line. Thank you.

Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Willem de Bruijn
On Wed, Apr 17, 2019 at 12:19 PM Arnd Bergmann wrote: > > On Wed, Apr 17, 2019 at 4:46 PM Willem de Bruijn > wrote: > > On Tue, Apr 16, 2019 at 4:38 PM Arnd Bergmann wrote: > > > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > > > socket protocol handlers, and all of those

Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Neil Horman
On Wed, Apr 17, 2019 at 10:21:12AM -0700, David Miller wrote: > From: Neil Horman > Date: Wed, 17 Apr 2019 05:35:23 -0400 > > > Acked-by: Neil Horman > > Neil, please quote appropriately in the future. > > I have to scroll through all of those pages of quoted patch just to > see this one

[PATCH v3 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Arnd Bergmann
The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many socket protocol handlers, and all of those end up calling the same sock_get_timestamp()/sock_get_timestampns() helper functions, which results in a lot of duplicate code. With the introduction of 64-bit time_t on 32-bit

Re: [PATCH v3 1/3] net: rework SIOCGSTAMP ioctl handling

2019-04-17 Thread Willem de Bruijn
On Wed, Apr 17, 2019 at 4:54 PM Arnd Bergmann wrote: > > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > socket protocol handlers, and all of those end up calling the same > sock_get_timestamp()/sock_get_timestampns() helper functions, which > results in a lot of duplicate