[PATCH] Fix socket bitop damage

2005-08-22 Thread Ralf Baechle
has probably been to copy all flags, so sock_copy_flags() should be the right thing. With this the ham radio protocols are usable again, so I hope this will make it into 2.6.13. Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] include/net/sock.h |5 + net/ax25/af_ax25.c |7

[PATCH] AX.25 UID fixes

2005-08-22 Thread Ralf Baechle
not refcounted resulting in a race between removal and usage of an element. Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] include/net/ax25.h | 18 +- net/ax25/af_ax25.c | 20 +++ net/ax25/ax25_route.c | 12 --- net/ax25/ax25_uid.c| 83

Another mkiss patch (was: Re: AX-25 software that works on Fedora Core 4?)

2005-08-24 Thread Ralf Baechle
/ DOK A21 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] drivers/net/hamradio/Kconfig |2 drivers/net/hamradio/mkiss.c | 1087 --- 2 files changed, 525 insertions(+), 564 deletions(-) Index: linux-cvs/drivers/net/hamradio/mkiss.c

Re: Netdevice reference leak in af_ax25.c ??

2005-09-01 Thread Ralf Baechle
On Thu, Sep 01, 2005 at 08:56:19PM +0200, Patrick McHardy wrote: I believe the SO_BINDTODEVICE case in net/ax25/af_x25.c (line 613 or so) leaks a reference to a net device. It does a dev_get_by_name, which holds a reference, but since it never assigns the pointer anywhere, I do not see

[AX.25] Make ax2asc thread-proof

2005-09-06 Thread Ralf Baechle
Ax2asc was still using a static buffer for all invocations which isn't exactly SMP-safe. Change ax2asc to take an additional result buffer as the argument. Change all callers to provide such a buffer. Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] include/net/ax25.h |2 +- net

[AX.25 1/7] Mark all kmalloc users __must_check

2006-12-14 Thread Ralf Baechle
The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that error values were not being propagated through the AX.25 stack. To help with that this patch marks all kmalloc users in the AX.25, NETROM and ROSE stacks as __must_check. Signed-off-by: Ralf Baechle [EMAIL PROTECTED

[AX.25 7/7] Fix unchecked rose_add_loopback_neigh uses

2006-12-14 Thread Ralf Baechle
rose_add_loopback_neigh uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net/rose.h |4 ++-- net

[AX.25 5/7] Fix unchecked ax25_linkfail_register uses

2006-12-14 Thread Ralf Baechle
ax25_linkfail_register uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net/ax25.h | 10 +++- net

[AX.25 3/7] Fix unchecked ax25_listen_register uses

2006-12-14 Thread Ralf Baechle
Fix ax25_listen_register to return something that's a sane error code, then all callers to use it. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] net/ax25/ax25_iface.c |7 --- net/netrom/nr_dev.c | 24 ++-- net/rose/af_rose.c|3 ++- 3 files changed, 24

[PATCH] NET: Fix /proc/net/arp for AX.25

2017-02-10 Thread Ralf Baechle
"*" in buf for a NULL address argument. Finally the HW address field is left aligned in a 17 character field (the length of an ethernet HW address in the usual hex notation) for readability. Signed-off-by: Ralf Baechle <r...@linux-mips.org> --- net/ipv4/arp.c | 12 ++-- 1

[PATCH] Add a number of protocols to __SOCKADDR_ALLTYPES

2017-08-03 Thread Ralf Baechle
, , len) == -1) { will hit. Adding a number of sockaddr_* fixes these problems. 2017-08-03 Ralf Baechle <r...@linux-mips.org> * socket/sys/socket.h (__SOCKADDR_ALLTYPES.): Add full_sockaddr_ax25 , sockaddr_ll, sockaddr_pkt and sockaddr_rose. --- socket/sys/socket.h | 4 +

[PATCH] Get rid of sk_protinfo use in netrom

2005-03-21 Thread Ralf Baechle DL5RB
Below patch puts struct sock into nr_cb to get rid of the need for the use of sk_protinfo in nr_sk(). While we're touching the data structure convert it from a typedef into a struct. Index: bk-afu/net/netrom/nr_timer.c === ---

Re: [PATCH] Get rid of sk_protinfo use in rose

2005-03-21 Thread Ralf Baechle DL5RB
On Mon, Mar 21, 2005 at 09:50:37AM +, Ralf Baechle DL5RB wrote: Below patch puts struct sock into rose_cb to get rid of the need for the use of sk_protinfo in rose_sk(). While we're touching the data structure convert it from a typedef into a struct. The previous two patches leave

[PATCH] AX.25 patches for strace

2005-03-31 Thread Ralf Baechle DL5RB
So far strace is lacking support for AX.25 making debugging of AX.25 software harder for no good reason. Below the first cut of a patch to add AX.25 support. The patch is against Sourceforge CVS. Please test. 73 de DL5RB op Ralf -- Loc. JN47BS / CQ 14 / ITU 28 / DOK A21 Index: configure.ac

Re: [PATCH] SMP fix for 6pack driver

2005-07-07 Thread Ralf Baechle DL5RB
On Tue, Jul 05, 2005 at 05:39:44PM -0500, Bill Vodall wrote: It's a strategy that allows attaching the TNC to any UNIX machine, even without AX.25 support. It's a hack but I was playing with it for a while when I ran out of interfaces. That could be VERY userful... Any more details

Re: What happened to mkiss module

2005-07-24 Thread Ralf Baechle DL5RB
PROTECTED] + * Copyright (C) 2004, 05 Ralf Baechle DL5RB [EMAIL PROTECTED] */ #include linux/config.h @@ -50,174 +39,301 @@ #include net/ax25.h -#include mkiss.h - #ifdef CONFIG_INET #include linux/ip.h #include linux/tcp.h #endif -static char banner[] __initdata = KERN_INFO mkiss

Re: What happened to mkiss module

2005-07-25 Thread Ralf Baechle DL5RB
On Mon, Jul 25, 2005 at 04:05:46PM -0400, Scott Weis wrote: I grabbed the message directly off of the server with VI. I only had one rej.. Okay. That's more the expected behaviour due to the change in 2.6.12-rc4. I applied the last part of the patch by hand.. No problems.. I found

Re: Ethereal ax25 monitoring

2005-08-15 Thread Ralf Baechle DL5RB
On Sun, Aug 14, 2005 at 10:54:41PM +0100, Richard Stearn wrote: Before I actually get down to design and coding I will make some enquiries on the Ethereal dev mailing list to see if anybody on that list is currently working on an AX.25 dissector and also to see if it would be accepted if

[PATCH 0/3] Eleminate HZ from AX.25 kernel interfaces

2005-08-18 Thread Ralf Baechle DL5RB
AX.25, NET/ROM and ROSE unfortunately still use jiffies as the unit of time for all their timeouts that can be configured through sysctl and it's procfs equivalents. This did result in a change of these kernel interfaces going from Linux 2.4 to 2.6 for anybody who was unlucky enough to use an

Re: AX-25 software that works on Fedora Core 4?

2005-08-20 Thread Ralf Baechle DL5RB
but unfortunately without mkiss setup for testing, so a very silly bug happened; find a version with that bug fixed below. All I can test it is to the point that kissattach succeeds, however. Ralf PS: Before anybody is scared, it did work that way for 6pack :-) Signed-off-by: Ralf Baechle DL5RB

Re: AX-25 software that works on Fedora Core 4?

2005-08-22 Thread Ralf Baechle DL5RB
and again, great job ! So here's the next version to test, it should fix the SIOCSIFHADDR issue. Again the patch is against 2.6.13-rc6. 73 de DL5RB op Ralf -- Loc. JN47BS / CQ 14 / ITU 28 / DOK A21 Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] drivers/net/hamradio/Kconfig |2 drivers

Re: AX-25 software that works on Fedora Core 4?

2005-08-22 Thread Ralf Baechle DL5RB
On Sat, Aug 20, 2005 at 08:30:37PM -, [EMAIL PROTECTED] wrote: What version is it actually intended for? The above are the latest Suse 9.2 and 9.3 respactively. I hope the above tells you something. 2.6.13-rc6. Always the latest. 73 de DL5RB op Ralf -- Loc. JN47BS / CQ 14 / ITU 28 / DOK

Re: [PATCH] SMP fix for 6pack driver

2005-09-01 Thread Ralf Baechle DL5RB
On Sun, Aug 28, 2005 at 10:46:09PM +0200, IƱaki Arenaza wrote: You could try EB6EBU's m6pack which is an application level solution to the problem. Just a little correction. It's EB2EBU, not EB6EBU (otherwise Google will not find my patch against ax25-tools-0.0.8 ;-) Sorry :-) You can

Re: Ethereal ax25 monitoring

2005-09-01 Thread Ralf Baechle DL5RB
On Wed, Aug 31, 2005 at 10:46:34PM +0100, Richard Stearn wrote: An update on AX.25 in Ethereal. I have enquired on the Ethereal list and the attitude (sample of 1) is that if the protocol exists and is used then it will be accepted. Subject to a few pratical provisos. The deeper issue I

Re: [PATCH] SMP fix for 6pack driver

2005-09-01 Thread Ralf Baechle DL5RB
On Thu, Sep 01, 2005 at 07:47:46AM -0500, Chuck Hast wrote: http://www.escomposlinux.org/iarenaza/hamradio/m6pack/files/ax25-tools-0.0.8-m6pack.diff.bz2 I'm still contemplating if this should preferably be done in userspace or in kernelspace ... Is there anymore on making

Re: ax25-howto

2005-09-06 Thread Ralf Baechle DL5RB
On Sun, Sep 04, 2005 at 08:15:22AM -0400, Harold Hartley wrote: I must agree as I have found it talks in some places about files that are not relevent to most distro's now and in fact are very out of date. Now with the newer files such as the ax25-config, ax25-tools and ax25-apps, most of

[AX.25] Make asc2ax thread-proof

2005-09-07 Thread Ralf Baechle DL5RB
to fix in ROSE ... Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] include/net/ax25.h |2 +- net/ax25/ax25_addr.c | 27 --- net/rose/rose_subr.c |4 ++-- 3 files changed, 15 insertions(+), 18 deletions(-) Index: linux-cvs/include/net/ax25.h

Re: Something about timers

2005-09-09 Thread Ralf Baechle DL5RB
On Fri, Sep 09, 2005 at 08:34:51AM +0300, jarmo wrote: Just noticed, that if you compile kernel without looking, Prosessor type and features - Timer frequency, default is 250ms, you get quite suprising behaviour with your ax25 stuff, especially 6pack :) I'd say quite quick actions and in

Re: multiple kiss ports

2007-02-14 Thread Ralf Baechle DL5RB
On Thu, Feb 15, 2007 at 12:03:06AM +1030, Stef Daniels VK5HSX wrote: P4 1.2Ghz Celeron MSI Motherboard 512MB RAM 40GB ATA Drive ttyS0 - 9600bd -MFJ 1270b (1200bd TNC) axport '2' ttyS1 - 4800bd - AEA PK232 (4800bd TNC) axport '3' Debian GNU\linux 3.1 (2.4.27 kernel) using:

Re: [PATCH] baycom_ser_fdx: also allow i/o ports = 0x1000 and enhanced failure logging

2007-03-05 Thread Ralf Baechle DL5RB
On Mon, Mar 05, 2007 at 02:45:09PM +0100, Thomas Sailer wrote: The baycom modem really doesn't have anything to do with RS232, it just uses the RS232 port as a PIO port + timer. That's why it needs its own 16550 driver. A few people asked me if it is possible to drive one of those RS232

Re: AX25 tools and packages

2007-07-30 Thread Ralf Baechle DL5RB
On Thu, Jul 26, 2007 at 05:23:32PM +, Bill Vodall WA7NWP wrote: Is sourceforge still the primary repository for the ax25 library and tools? Actually DL9SAU and me have moved the development away to another machine a while ago when Sourceforge was basically unusable for weeks. The new site

Re: AX25 tools and packages

2007-08-02 Thread Ralf Baechle DL5RB
On Thu, Aug 02, 2007 at 11:24:51AM +1000, Hamish Moffatt wrote: I'm using the latest patches from Debian since that seemed to be the latest I could find. Because my current builds are targeted at a 2.4 series kernel in an embedded system they work with a few small patches but I'm

Re: AX.25 Kernel - problem - ax25_sendmsg returns EMSGSIZE !

2007-10-08 Thread Ralf Baechle DL5RB
On Sun, Oct 07, 2007 at 09:58:06PM +0200, Tihomir Heidelberg - 9a4gl wrote: Using kernel 2.6.21.6 here. If you write to AX.25 socket bytes more then MTU, write will return -1 and errno will be set to 90 (EMSGSIZE = [Message too long]). This happend in net/ax25/af_ax25.c in function

Re: [BUG] AX.25 sockets not destroyed

2017-02-23 Thread Ralf Baechle DL5RB
On Thu, Feb 23, 2017 at 02:53:36PM +0100, f6bvp wrote: > 8c80b5ed5800 ax0 F6BVP-7 F4BWT-9 1 0 0 0 18446744073709549 100 0 3 0 300 > 0 0 9 10 5 2 256 * * * > 8c80b5ed5400 ax0 F6BVP-7 WA3MEZ-9 1 0 0 0 18446744073709549 100 0 3 0 300 > 0 0 9 10 5 2 256 * * * > then it displays a very