KASAN: use-after-free Read in refcount_inc_not_zero_checked (2)
Hello, syzbot found the following crash on: HEAD commit:9c7dc824 Merge tag '5.1-rc-smb3' of git://git.samba.org/sf.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=170ae6d720 kernel config: https://syzkaller.appspot.com/x/.config?x=7e1aaa1cfbfe1abf dashboard link: https://syzkaller.appspot.com/bug?extid=eff6b596cc8194e2f029 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17e294a320 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+eff6b596cc8194e2f...@syzkaller.appspotmail.com == BUG: KASAN: use-after-free in atomic_read include/asm-generic/atomic-instrumented.h:26 [inline] BUG: KASAN: use-after-free in refcount_inc_not_zero_checked+0x81/0x200 lib/refcount.c:123 Read of size 4 at addr 8880a614c280 by task syz-executor.3/7636 CPU: 1 PID: 7636 Comm: syz-executor.3 Not tainted 5.0.0+ #25 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 print_address_description.cold+0x7c/0x20d mm/kasan/report.c:187 kasan_report.cold+0x1b/0x40 mm/kasan/report.c:317 check_memory_region_inline mm/kasan/generic.c:185 [inline] check_memory_region+0x123/0x190 mm/kasan/generic.c:191 kasan_check_read+0x11/0x20 mm/kasan/common.c:102 atomic_read include/asm-generic/atomic-instrumented.h:26 [inline] refcount_inc_not_zero_checked+0x81/0x200 lib/refcount.c:123 refcount_inc_checked+0x17/0x70 lib/refcount.c:156 sock_hold include/net/sock.h:647 [inline] nr_release+0x62/0x3c0 net/netrom/af_netrom.c:523 __sock_release+0xd3/0x2b0 net/socket.c:579 sock_close+0x1b/0x30 net/socket.c:1162 __fput+0x2e5/0x8d0 fs/file_table.c:278 fput+0x16/0x20 fs/file_table.c:309 task_work_run+0x14a/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x273/0x2c0 arch/x86/entry/common.c:166 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline] syscall_return_slowpath arch/x86/entry/common.c:268 [inline] do_syscall_64+0x52d/0x610 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x411e31 Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 e4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:7ffcf55d0f50 EFLAGS: 0293 ORIG_RAX: 0003 RAX: RBX: 0007 RCX: 00411e31 RDX: RSI: 007410c8 RDI: 0006 RBP: R08: 0002cf1a R09: 0002cf1a R10: 7ffcf55d0e80 R11: 0293 R12: 0001 R13: 7ffcf55d0f90 R14: R15: 7ffcf55d0fa0 Allocated by task 7638: save_stack+0x45/0xd0 mm/kasan/common.c:75 set_track mm/kasan/common.c:87 [inline] __kasan_kmalloc mm/kasan/common.c:497 [inline] __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:470 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:511 __do_kmalloc mm/slab.c:3726 [inline] __kmalloc+0x15c/0x740 mm/slab.c:3735 kmalloc include/linux/slab.h:550 [inline] sk_prot_alloc+0x19c/0x2e0 net/core/sock.c:1607 sk_alloc+0x39/0xf70 net/core/sock.c:1661 nr_create+0xb9/0x5e0 net/netrom/af_netrom.c:436 __sock_create+0x3e6/0x750 net/socket.c:1298 sock_create net/socket.c:1338 [inline] __sys_socket+0x103/0x220 net/socket.c:1368 __do_sys_socket net/socket.c:1377 [inline] __se_sys_socket net/socket.c:1375 [inline] __x64_sys_socket+0x73/0xb0 net/socket.c:1375 do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe Freed by task 7636: save_stack+0x45/0xd0 mm/kasan/common.c:75 set_track mm/kasan/common.c:87 [inline] __kasan_slab_free+0x102/0x150 mm/kasan/common.c:459 kasan_slab_free+0xe/0x10 mm/kasan/common.c:467 __cache_free mm/slab.c:3498 [inline] kfree+0xcf/0x230 mm/slab.c:3821 sk_prot_free net/core/sock.c:1644 [inline] __sk_destruct+0x4f1/0x6d0 net/core/sock.c:1726 sk_destruct+0x7b/0x90 net/core/sock.c:1734 __sk_free+0xce/0x300 net/core/sock.c:1745 sk_free+0x42/0x50 net/core/sock.c:1756 sock_put include/net/sock.h:1708 [inline] nr_release+0x337/0x3c0 net/netrom/af_netrom.c:557 __sock_release+0xd3/0x2b0 net/socket.c:579 sock_close+0x1b/0x30 net/socket.c:1162 __fput+0x2e5/0x8d0 fs/file_table.c:278 fput+0x16/0x20 fs/file_table.c:309 task_work_run+0x14a/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x273/0x2c0 arch/x86/entry/common.c:166 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline] syscall_return_slowpath arch/x86/entry/common.c:268 [inline] do_syscall_64+0x52d/0x610 arch/x86/entry/common.c:293
Re: KASAN: use-after-free Read in refcount_inc_not_zero_checked
syzbot has found a reproducer for the following crash on: HEAD commit:333478a7eb21 Merge branch 'for-rc' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14ec4628c0 kernel config: https://syzkaller.appspot.com/x/.config?x=505743eba4e4f68 dashboard link: https://syzkaller.appspot.com/bug?extid=defa700d16f1bd1b9a05 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=142f7590c0 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+defa700d16f1bd1b9...@syzkaller.appspotmail.com IPv6: ADDRCONF(NETDEV_UP): vxcan1: link is not ready 8021q: adding VLAN 0 to HW filter on device batadv0 IPVS: ftp: loaded support on port[0] = 21 chnl_net:caif_netlink_parms(): no params data found == BUG: KASAN: use-after-free in atomic_read include/asm-generic/atomic-instrumented.h:21 [inline] BUG: KASAN: use-after-free in refcount_inc_not_zero_checked+0x91/0x2e0 lib/refcount.c:120 Read of size 4 at addr 888089bba440 by task syz-executor5/11381 CPU: 1 PID: 11381 Comm: syz-executor5 Not tainted 5.0.0-rc3+ #40 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1db/0x2d0 lib/dump_stack.c:113 print_address_description.cold+0x7c/0x20d mm/kasan/report.c:187 kasan_report.cold+0x1b/0x40 mm/kasan/report.c:317 check_memory_region_inline mm/kasan/generic.c:185 [inline] check_memory_region+0x123/0x190 mm/kasan/generic.c:191 kasan_check_read+0x11/0x20 mm/kasan/common.c:100 atomic_read include/asm-generic/atomic-instrumented.h:21 [inline] refcount_inc_not_zero_checked+0x91/0x2e0 lib/refcount.c:120 refcount_inc_checked+0x17/0x70 lib/refcount.c:153 sock_hold include/net/sock.h:647 [inline] nr_release+0x62/0x3c0 net/netrom/af_netrom.c:523 __sock_release+0xd3/0x250 net/socket.c:579 sock_close+0x1b/0x30 net/socket.c:1141 __fput+0x3c5/0xb10 fs/file_table.c:278 fput+0x16/0x20 fs/file_table.c:309 task_work_run+0x1f4/0x2b0 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0xad7/0x26e0 kernel/exit.c:867 do_group_exit+0x177/0x430 kernel/exit.c:971 get_signal+0x8b4/0x19b0 kernel/signal.c:2517 do_signal+0x91/0x1ea0 arch/x86/kernel/signal.c:816 exit_to_usermode_loop+0x2f7/0x3b0 arch/x86/entry/common.c:162 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline] syscall_return_slowpath arch/x86/entry/common.c:268 [inline] do_syscall_64+0x696/0x800 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x458099 Code: 6d b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 3b b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7f7c8a6a7cf8 EFLAGS: 0246 ORIG_RAX: 00ca RAX: fe00 RBX: 0073c228 RCX: 00458099 RDX: RSI: 0080 RDI: 0073c228 RBP: 0073c220 R08: R09: R10: R11: 0246 R12: 0073c22c R13: 7ffc1cd8e9ef R14: 7f7c8a6a89c0 R15: 0005 Allocated by task 11350: save_stack+0x45/0xd0 mm/kasan/common.c:73 set_track mm/kasan/common.c:85 [inline] __kasan_kmalloc mm/kasan/common.c:496 [inline] __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:469 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:504 __do_kmalloc mm/slab.c:3711 [inline] __kmalloc+0x15c/0x740 mm/slab.c:3720 kmalloc include/linux/slab.h:550 [inline] sk_prot_alloc+0x19c/0x2e0 net/core/sock.c:1477 sk_alloc+0xd7/0x1690 net/core/sock.c:1531 nr_create+0xb9/0x5e0 net/netrom/af_netrom.c:436 __sock_create+0x532/0x930 net/socket.c:1277 sock_create net/socket.c:1317 [inline] __sys_socket+0x106/0x260 net/socket.c:1347 __do_sys_socket net/socket.c:1356 [inline] __se_sys_socket net/socket.c:1354 [inline] __x64_sys_socket+0x73/0xb0 net/socket.c:1354 do_syscall_64+0x1a3/0x800 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe Freed by task 11170: save_stack+0x45/0xd0 mm/kasan/common.c:73 set_track mm/kasan/common.c:85 [inline] __kasan_slab_free+0x102/0x150 mm/kasan/common.c:458 kasan_slab_free+0xe/0x10 mm/kasan/common.c:466 __cache_free mm/slab.c:3487 [inline] kfree+0xcf/0x230 mm/slab.c:3806 sk_prot_free net/core/sock.c:1514 [inline] __sk_destruct+0x76d/0xa60 net/core/sock.c:1596 sk_destruct+0x7b/0x90 net/core/sock.c:1604 __sk_free+0xce/0x300 net/core/sock.c:1615 sk_free+0x42/0x50 net/core/sock.c:1626 sock_put include/net/sock.h:1707 [inline] nr_heartbeat_expiry+0x489/0x520 net/netrom/nr_timer.c:130 call_timer_fn+0x254/0x900 kernel/time/timer.c:1325 expire_timers kernel/time/timer.c:1362 [inline] __run_timers+0x6fc/0xd50 kernel/time/timer.c:1681