Re: [linux-fbdev] gcc -W for 2.2.17-pre14

2000-08-02 Thread Geert Uytterhoeven
On Tue, 1 Aug 2000, Andrew Morton wrote: drivers/video/fbmem.c:478 if (con2fb.console 0 || con2fb.console MAX_NR_CONSOLES) return -EINVAL; I think this is an off-by-one. Should it be `= MAX_NR_CONSOLES'? No, see the code below. 0 means `set them all',

gcc -W for 2.2.17-pre14

2000-08-01 Thread Andrew Morton
Feeding kernel 2.2.17 through `gcc -W' has shown a number of bugs. I have attached here a proposed patch which fixes a small number of these, but for the rest I would ask those on the "To:" list to let me know how they would prefer that these be addressed. I shall then cut a final patch.