Re: [PATCH v2] scsi: fcoe: use sysfs_match_string over fcoe_parse_mode

2023-12-18 Thread Martin K. Petersen
On Tue, 12 Dec 2023 23:19:06 +, Justin Stitt wrote: > Instead of copying @buf into a new buffer and carefully managing its > newline/null-terminating status, we can just use sysfs_match_string() > as it uses sysfs_streq() internally which handles newline/null-term: > > | /** > | *

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-18 Thread Luis Chamberlain
So we can split this up concentually in two: * constificaiton of the table handlers * constification of the table struct itself On Sun, Dec 17, 2023 at 11:10:15PM +0100, Thomas Weißschuh wrote: > The handlers can already be made const as shown in this series, The series did already produce

Re: [PATCH v3 1/2] kernel.h: removed REPEAT_BYTE from kernel.h

2023-12-18 Thread Greg KH
On Mon, Dec 18, 2023 at 06:44:47PM +, tanz...@google.com wrote: > This patch creates wordpart.h and includes it in asm/word-at-a-time.h > for the all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h > because of REPEAT_BYTE. Moving this to another header and including it > where

[PATCH v3 2/2] lib/string: shrink lib/string.i via IWYU

2023-12-18 Thread tanzirh
This diff uses an open source tool include-what-you-use (IWYU) to modify the include list changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times.

[PATCH v3 1/2] kernel.h: removed REPEAT_BYTE from kernel.h

2023-12-18 Thread tanzirh
This patch creates wordpart.h and includes it in asm/word-at-a-time.h for the all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h because of REPEAT_BYTE. Moving this to another header and including it where necessary allows us to not include the bloated kernel.h. Making this implicit

[PATCH v3 0/2] shrink lib/string.i via IWYU

2023-12-18 Thread tanzirh
This patch series changes the include list of string.c to minimize the preprocessing size. The patch series intends to remove REPEAT_BYE from kernel.h and move it into its own header file because word-at-a-time.h has an implicit dependancy on it but it is declared in kernel.h which is bloated.

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-18 Thread Andy Shevchenko
On Mon, Dec 18, 2023 at 09:05:56AM -0800, Tanzir Hasan wrote: > > While REPEAT_BYTE has a manageable number of users, upper_* and > > lower_* have significantly more; I worry about moving those causing > > regressions. We can move them, but such changes would need > > significantly more soak time

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-18 Thread Andy Shevchenko
On Mon, Dec 18, 2023 at 08:57:59AM -0800, Nick Desaulniers wrote: > On Fri, Dec 15, 2023 at 11:09 AM Andy Shevchenko > wrote: > > On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan wrote: > > > On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko wrote: > > >> On Thu, Dec 14, 2023 at 09:06:12PM +,

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-18 Thread Tanzir Hasan
> While REPEAT_BYTE has a manageable number of users, upper_* and > lower_* have significantly more; I worry about moving those causing > regressions. We can move them, but such changes would need > significantly more soak time than this series IMO. Tanzir is also > working on statistical

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-18 Thread Nick Desaulniers
On Fri, Dec 15, 2023 at 11:09 AM Andy Shevchenko wrote: > > On Fri, Dec 15, 2023 at 8:31 PM Tanzir Hasan wrote: > > On Fri, Dec 15, 2023 at 8:04 AM Andy Shevchenko wrote: > >> On Thu, Dec 14, 2023 at 09:06:12PM +, tanz...@google.com wrote: > > ... > > >> > +#include > >> > >> I highly

Re: [PATCH v7 0/8] soc/tegra: fuse: Add ACPI support

2023-12-18 Thread Kartik
On Fri, 2023-12-15 at 17:43 +0100, Thierry Reding wrote > On Thu, Dec 14, 2023 at 06:43:47PM +, Arnd Bergmann wrote: > > On Thu, Dec 14, 2023, at 17:08, Thierry Reding wrote: > > > On Tue, Oct 17, 2023 at 10:53:14AM +0530, Kartik wrote: > > >> This series of patches add ACPI support for