Re: [PATCH] hwmon: (lm75) Add a basic interrupt handler

2017-07-17 Thread Guenter Roeck
On Sun, Jul 16, 2017 at 09:51:24PM +, Tony O'Brien wrote: > Hi Guenter - > > The interrupt line the LM75 sits on is shared by other devices and therefore > cannot be disabled. It was added in hardware as a possible feature can > cannot be disconnected. > Ah yes, it is declared as shared,

[RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-17 Thread Andrew Jeffery
Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Fans in a PMBus device are driven by the configuration of two registers: FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan and the tacho operate (if installed), while FAN_COMMAND_x sets the desired fan rate. The u

[RFC PATCH v2 2/3] pmbus: Add and expose pmbus_get_info()

2017-07-17 Thread Andrew Jeffery
This allows the caller to hoist themselves out to a containing structure in e.g. the read/write callbacks without exposing struct pmbus_data. Signed-off-by: Andrew Jeffery --- New since v1. drivers/hwmon/pmbus/pmbus.h | 1 + drivers/hwmon/pmbus/pmbus_core.c | 6 ++ 2 files changed, 7 i

[RFC PATCH v2 3/3] pmbus: Add MAX31785 driver

2017-07-17 Thread Andrew Jeffery
The driver features fan control and basic dual-tachometer support. The fan control makes use of the new virtual registers exposed by the pmbus core, mixing use of the default implementations with some overrides via the read/write handlers. FAN_COMMAND_1 on the MAX31785 breaks the values into bands

[RFC PATCH v2 0/3] pmbus: Expand fan support and add MAX31785 driver

2017-07-17 Thread Andrew Jeffery
Hello, This is a follow-up to the first RFC series[1] and includes some significant reworks based on Guenter's feedback. [1] https://lkml.org/lkml/2017/7/10/338 v2 retains the goal of exposing the fan[1-*]_target, pwm[1-*] and pwm[1-*]_enable attributes, and implementing support for the MAX31785

[PATCH linux v5 3/3] drivers: w1: add hwmon temp support for w1_therm

2017-07-17 Thread Jaghathiswari Rankappagounder Natarajan
This change adds hwmon temp support for w1_therm. Signed-off-by: Jaghathiswari Rankappagounder Natarajan Acked-by: Evgeniy Polyakov Acked-by: Guenter Roeck --- v2 - make changes to support hwmon_device_register_with_info mentioned by Guenter. v3 - used IS_REACHABLE() - rearranged the code to n

[PATCH linux v5 2/3] drivers: w1: refactor w1_slave_show to make the temp reading functionality separate

2017-07-17 Thread Jaghathiswari Rankappagounder Natarajan
Inside the w1_slave_show function refactor the code to read the temp into a separate function. Signed-off-by: Jaghathiswari Rankappagounder Natarajan Acked-by: Guenter Roeck Acked-by: Evgeniy Polyakov --- v2 - made changes to support hwmon_device_register_with_info mentioned by Guenter. v3 - u

[PATCH linux v5 1/3] drivers: w1: add hwmon support structures

2017-07-17 Thread Jaghathiswari Rankappagounder Natarajan
This patch has changes to w1.h/w1.c/w1_family.h generic files to add (optional) hwmon support structures. Signed-off-by: Jaghathiswari Rankappagounder Natarajan Acked-by: Evgeniy Polyakov Acked-by: Guenter Roeck --- v2 - made changes to support hwmon_device_register_with_info mentioned by Guent

[PATCH linux v5 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-17 Thread Jaghathiswari Rankappagounder Natarajan
Hi Greg, Please pull in this patchset into the tree. Thanks! Summary of what this patchset does: Our board has 4 DS18B20 1-wire temperature sensors. Each 1-wire bus and the sensor under it is already configured against the Linux 1-wire driver (called w1). They have a sysfs file(e.g. /sys/bus/w1/d

[PATCH] hwmon: i5k_amb: constify pci_device_id.

2017-07-17 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 3562 320 83890 f32 drivers/hwmon

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-17 Thread Greg Kroah-Hartman
On Mon, Jul 17, 2017 at 09:06:00AM -0700, Jaghathiswari Rankappagounder Natarajan wrote: > Hi Evgeniy/Greg, > > Please pull in version 4 patchset into the tree. I have no idea what that means :( Please resend the correct ones so I know what to do here. thanks, greg k-h -- To unsubscribe from

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-17 Thread Jaghathiswari Rankappagounder Natarajan
Hi Evgeniy/Greg, Please pull in version 4 patchset into the tree. On Thu, Jul 13, 2017 at 8:39 AM, Evgeniy Polyakov wrote: > Hi > > 13.07.2017, 18:36, "Evgeniy Polyakov" : >> I believe this is a resend of your previous patchet, isn't it? >> Greg, if you hadn't yet, please pull it into the tree.

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-17 Thread Sebastian Reichel
Hi, On Mon, Jul 17, 2017 at 03:32:45PM +0100, Lee Jones wrote: > On Mon, 03 Jul 2017, Sebastian Reichel wrote: > > > Add register details an channels definition for using the TSI > > registers in the hwmon driver. > > > > Signed-off-by: Sebastian Reichel > > --- > > include/linux/mfd/da9052/da

Re: [PATCHv5 4/6] mfd: da9052: make touchscreen registration optional

2017-07-17 Thread Lee Jones
On Mon, 03 Jul 2017, Sebastian Reichel wrote: > If the touchscreen pins are used as general purpose analogue > input, the touchscreen driver should not be used. The pins > will be handled by the existing hwmon driver instead. > > Signed-off-by: Sebastian Reichel > --- > drivers/mfd/da9052-core.

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-17 Thread Lee Jones
On Mon, 17 Jul 2017, Lee Jones wrote: > On Mon, 03 Jul 2017, Sebastian Reichel wrote: > > > Add register details an channels definition for using the TSI > > registers in the hwmon driver. > > > > Signed-off-by: Sebastian Reichel > > --- > > include/linux/mfd/da9052/da9052.h | 6 ++ > > i

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-17 Thread Lee Jones
On Mon, 03 Jul 2017, Sebastian Reichel wrote: > Add register details an channels definition for using the TSI > registers in the hwmon driver. > > Signed-off-by: Sebastian Reichel > --- > include/linux/mfd/da9052/da9052.h | 6 ++ > include/linux/mfd/da9052/reg.h| 11 ++- > 2 fi

Re: [PATCHv5 2/6] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-17 Thread Lee Jones
On Mon, 03 Jul 2017, Sebastian Reichel wrote: > DA9052 allows using the touchscreen input pins as general purpose > analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y- > and providing a reference voltage at TSIREF pin. > > Signed-off-by: Sebastian Reichel > --- > Documentation/dev

Re: [PATCHv4 3/4] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-17 Thread Sebastian Reichel
Hi Lee, On Mon, Jul 17, 2017 at 11:49:45AM +0100, Lee Jones wrote: > On Fri, 30 Jun 2017, Sebastian Reichel wrote: > > > DA9052 allows using the touchscreen input pins as general purpose > > analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y- > > and providing a reference voltage at

Re: [PATCHv4 3/4] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-17 Thread Lee Jones
On Fri, 30 Jun 2017, Sebastian Reichel wrote: > DA9052 allows using the touchscreen input pins as general purpose > analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y- > and providing a reference voltage at TSIREF pin. > > Signed-off-by: Sebastian Reichel > --- > Documentation/dev

Re: [PATCHv4 1/4] mfd: da9052: fix manual ADC read after timed out read

2017-07-17 Thread Lee Jones
On Fri, 30 Jun 2017, Sebastian Reichel wrote: > It is possible that under heavy system load, the counter in the completion > struct, used for waiting for end of AD conversion, gets incremented twice. > To make sure the driver recovers from this situation, the completion struct > should be reinitia