Re: [RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-07 Thread Guenter Roeck
On 08/07/2017 08:25 PM, Eddie James wrote: From: "Edward A. James" Hi Guenter, I'm looking for some feedback for some extensions to the pmbus core. We're looking for some additional functionality, particularly with STATUS_WORD and obtaining raw status data. The first two

[RFC 2/3] drivers/hmwon/pmbus: store STATUS_WORD in status registers

2017-08-07 Thread Eddie James
From: "Edward A. James" Higher byte of the status register wasn't available for boolean alarms. Store the STATUS_WORD register if it's available, and read it out when queried by boolean attributes. The method of storing and retrieving the status reg is a bit hacky but I

[RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-07 Thread Eddie James
From: "Edward A. James" Hi Guenter, I'm looking for some feedback for some extensions to the pmbus core. We're looking for some additional functionality, particularly with STATUS_WORD and obtaining raw status data. The first two patches enable the use of the STATUS_WORD

[RFC 1/3] drivers/hwmon/pmbus: Access word data for STATUS_WORD and use it by default

2017-08-07 Thread Eddie James
From: "Edward A. James" Pmbus core always reads byte data from the status register, even if configured to use STATUS_WORD. Use a function pointer so we always do either byte or word access depending on which register we're trying to access. Also switch to use STATUS_WORD by

Re: [PATCH v2 16/18] hwmon: add support for sensors exported via ARM SCMI

2017-08-07 Thread Sudeep Holla
On 04/08/17 20:32, Guenter Roeck wrote: > On Fri, Aug 04, 2017 at 03:31:42PM +0100, Sudeep Holla wrote: [...] >> +platform_set_drvdata(pdev, scmi_sensors); >> + >> +hwdev = devm_hwmon_device_register_with_groups(dev, "scmi_sensors", >> +

[PATCH v2] hwmon: adt7475: constify attribute_group structures

2017-08-07 Thread Arvind Yadav
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- change in v2: subject was not correct.

Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.

2017-08-07 Thread Arvind Yadav
Hi, On Monday 07 August 2017 02:55 PM, Jean Delvare wrote: Hi Arvind, On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const

Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.

2017-08-07 Thread Jean Delvare
Hi Arvind, On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. Confused by the subject. What is

[PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.

2017-08-07 Thread Arvind Yadav
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/hwmon/adt7475.c | 16 1