Re: [RFC] hwmon: (ibmpowernv) Add support for reset-history sensors

2017-08-08 Thread Guenter Roeck
On 07/25/2017 10:55 PM, Shilpasri G Bhat wrote: In P9, OCC allows for clearing the sensor min-max history. This patch exports attribute to reset history when set will clear the history of all the sensors owned by CSM and belonging to the chip. Signed-off-by: Shilpasri G Bhat --- This patch is o

Re: [v3, 1/2] hwmon: (it87) Split out chip registers setting code on probe path

2017-08-08 Thread Guenter Roeck
On Wed, Aug 02, 2017 at 01:06:23AM +0200, Maciej S. Szmigiero wrote: > This commit splits out chip registers setting code on probe path to > separate functions so they can be reused for setting the device properly > again when system resumes from suspend. > > While we are at it let's also make cle

Re: [v2] hwmon: adt7475: constify attribute_group structures

2017-08-08 Thread Arvind Yadav
yes, Sorry for noise. After rebase, it' was showing unchanged. On Wednesday 09 August 2017 07:35 AM, Guenter Roeck wrote: On Mon, Aug 07, 2017 at 03:06:29PM +0530, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by

Re: [v2] hwmon: adt7475: constify attribute_group structures

2017-08-08 Thread Guenter Roeck
On Mon, Aug 07, 2017 at 03:06:29PM +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Kind of conf

Re: [9/9, v2] hwmon: (scpi) constify thermal_zone_of_device_ops structures

2017-08-08 Thread Guenter Roeck
On Tue, Aug 08, 2017 at 05:09:03PM +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to devm_thermal_zone_of_sensor_register, which is declared > as const. Thus the thermal_zone_of_device_ops structure itself can > be const. > > Done wit

Re: [8/9, v2] hwmon: (core) constify thermal_zone_of_device_ops structures

2017-08-08 Thread Guenter Roeck
On Tue, Aug 08, 2017 at 05:09:02PM +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to devm_thermal_zone_of_sensor_register, which is declared > as const. Thus the thermal_zone_of_device_ops structure itself can > be const. > > Done wit

Re: [RFC,3/3] drivers/hwmon/pmbus: Add sensor status to pmbus attributes

2017-08-08 Thread Guenter Roeck
On Mon, Aug 07, 2017 at 10:25:48PM -0500, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Extend the pmbus core to provide status registers for attributes. > > Signed-off-by: Edward A. James NACK, sorry. As mentioned separately, please consider adding debugfs support instead.

Re: [RFC,2/3] drivers/hmwon/pmbus: store STATUS_WORD in status registers

2017-08-08 Thread Guenter Roeck
On Mon, Aug 07, 2017 at 10:25:47PM -0500, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Higher byte of the status register wasn't available for boolean alarms. > Store the STATUS_WORD register if it's available, and read it out when > queried by boolean attributes. > > The meth

Re: [RFC, 1/3] drivers/hwmon/pmbus: Access word data for STATUS_WORD and use it by default

2017-08-08 Thread Guenter Roeck
On Mon, Aug 07, 2017 at 10:25:46PM -0500, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Pmbus core always reads byte data from the status register, even if > configured to use STATUS_WORD. Use a function pointer so we always do > either byte or word access depending on which reg

Re: [RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-08 Thread Guenter Roeck
On Tue, Aug 08, 2017 at 11:12:19AM -0500, Eddie James wrote: > > > On 08/07/2017 11:00 PM, Guenter Roeck wrote: > >On 08/07/2017 08:25 PM, Eddie James wrote: > >>From: "Edward A. James" > >> > >>Hi Guenter, > >> > >>I'm looking for some feedback for some extensions to the pmbus core. > >>We're >

Re: [RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-08 Thread Guenter Roeck
On Tue, Aug 08, 2017 at 02:26:15PM -0500, Christopher Bostic wrote: > > > On 8/8/17 11:12 AM, Eddie James wrote: > > > > > >On 08/07/2017 11:00 PM, Guenter Roeck wrote: > >>On 08/07/2017 08:25 PM, Eddie James wrote: > >>>From: "Edward A. James" > >>> > >>>Hi Guenter, > >>> > >>>I'm looking for s

Re: [RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-08 Thread Christopher Bostic
On 8/8/17 11:12 AM, Eddie James wrote: On 08/07/2017 11:00 PM, Guenter Roeck wrote: On 08/07/2017 08:25 PM, Eddie James wrote: From: "Edward A. James" Hi Guenter, I'm looking for some feedback for some extensions to the pmbus core. We're looking for some additional functionality, partic

Re: [RFC 0/3] drivers/hwmon/pmbus: Use STATUS_WORD and add status sensors

2017-08-08 Thread Eddie James
On 08/07/2017 11:00 PM, Guenter Roeck wrote: On 08/07/2017 08:25 PM, Eddie James wrote: From: "Edward A. James" Hi Guenter, I'm looking for some feedback for some extensions to the pmbus core. We're looking for some additional functionality, particularly with STATUS_WORD and obtaining ra

[PATCH 0/9 v2] constify thermal_zone_of_device_ops structures

2017-08-08 Thread Julia Lawall
The thermal_zone_of_device_ops structures are only passed as the fourth argument to thermal_zone_of_sensor_register or devm_thermal_zone_of_sensor_register, both of which are declared as const. Thus the thermal_zone_of_device_ops structures themselves can be const. v2: add structures passed to dev

[PATCH 8/9 v2] hwmon: (core) constify thermal_zone_of_device_ops structures

2017-08-08 Thread Julia Lawall
The thermal_zone_of_device_ops structure is only passed as the fourth argument to devm_thermal_zone_of_sensor_register, which is declared as const. Thus the thermal_zone_of_device_ops structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: New patc

[PATCH 9/9 v2] hwmon: (scpi) constify thermal_zone_of_device_ops structures

2017-08-08 Thread Julia Lawall
The thermal_zone_of_device_ops structure is only passed as the fourth argument to devm_thermal_zone_of_sensor_register, which is declared as const. Thus the thermal_zone_of_device_ops structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: New patc

Re: ftsteutates: fix clear alarm sysfs entries

2017-08-08 Thread Guenter Roeck
On Thu, Aug 03, 2017 at 11:43:51AM +0200, Thilo Cestonaro wrote: > sysfs store functions should return the "written" bytes. > Returning zero ends in an endless loop, so fix this by > returning the count of bytes got. > > Signed-off-by: Thilo Cestonaro Applied, thanks (fixed documentation change