[PATCH v3] hwmon: g762: handle cleanup with devm_add_action

Simplify code and use devm_add_action() to handle cleanup. Signed-off-by: Peng Hao --- drivers/hwmon/g762.c | 58 +--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/drivers/hwmon/g762.c

Re: [PATCH v2] hwmon: g762: handle cleanup with devm_add_action

On 03/01/2018 03:03 AM, Peng Hao wrote: Simplify code and use devm_add_action() to handle cleanup. Signed-off-by: Peng Hao --- drivers/hwmon/g762.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git

[PATCH v2] hwmon: g762: handle cleanup with devm_add_action

Simplify code and use devm_add_action() to handle cleanup. Signed-off-by: Peng Hao --- drivers/hwmon/g762.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/hwmon/g762.c b/drivers/hwmon/g762.c index

Re: [RFC 3/4] hwmon: add Gateworks System Controller support

On Wed, Feb 28, 2018 at 01:44:36PM -0800, Tim Harvey wrote: > On Tue, Feb 27, 2018 at 6:05 PM, Guenter Roeck wrote: > > On 02/27/2018 05:21 PM, Tim Harvey wrote: > >> > >> The Gateworks System Controller has a hwmon sub-component that exposes > >> up to 16 ADC's, some of which

Re: [RFC 3/4] hwmon: add Gateworks System Controller support

On Tue, Feb 27, 2018 at 6:05 PM, Guenter Roeck wrote: > On 02/27/2018 05:21 PM, Tim Harvey wrote: >> >> The Gateworks System Controller has a hwmon sub-component that exposes >> up to 16 ADC's, some of which are temperature sensors, others which are >> voltage inputs. The ADC

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

On Tue, Feb 27, 2018 at 6:00 PM, Randy Dunlap wrote: > On 02/27/2018 05:21 PM, Tim Harvey wrote: >> The Gateworks System Controller (GSC) is an I2C slave controller >> implemented with an MSP430 micro-controller whose firmware embeds the >> following features: >> - I/O

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

On Wed, 28 Feb 2018, Thierry Reding wrote: > Anyone that needs something other than normal mode should use the new > atomic PWM API. At the risk of revealing my true ignorance, what is the new atomic PWM API? Where? Examples of how one would convert old code over to the

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: > Add PWM mode to pwm_config() function. The drivers which uses pwm_config() > were adapted to this change. > > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-s3c24xx/mach-rx1950.c | 11

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

> + dev_err(>dev, ">> 0x%02x %d\n", reg, ret); > + return ret; > + } > + dev_dbg(>dev, ">> 0x%02x=0x%02x (%d)\n", reg, val, retry); > + > +return 0; Hi Tim There appears to be a few spaces vs tabs issues in this file. Andrew -- To unsubscribe from

Re: [RFC 0/4] Add support for the Gateworks System Controller

Hi Tim Cool. I would say this is done right. > One issue I'm trying to figure out the best way to deal with is the > fact that the GSC can 'NAK' transactions occasionally which is why I > override the regmap read/write functions and provide retries. This > resolves the issue for the mfd core

Re: [RFC 0/4] Add support for the Gateworks System Controller

On Wed, Feb 28, 2018 at 6:44 AM, Andrew Lunn wrote: > On Tue, Feb 27, 2018 at 05:21:10PM -0800, Tim Harvey wrote: >> This series adds support for the Gateworks System Controller used on >> Gateworks >> Laguna, Ventana, and Newport product families. >> >> The GSC is an MSP430 I2C

Re: [PATCH] hwmon: g762: handle cleanup with devm_add_action

On 02/28/2018 07:51 AM, Peng Hao wrote: Simplify code and use devm_add_action() to handle cleanup. Signed-off-by: Peng Hao Excellent idea. Some suggestions for improvements below. --- drivers/hwmon/g762.c | 30 ++ 1 file changed, 14

Re: [RFC 0/4] Add support for the Gateworks System Controller

On Tue, Feb 27, 2018 at 05:21:10PM -0800, Tim Harvey wrote: > This series adds support for the Gateworks System Controller used on Gateworks > Laguna, Ventana, and Newport product families. > > The GSC is an MSP430 I2C slave controller whose firmware embeds the following > features: > - I/O

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 02/27/2018 11:03 PM, Mikko Perttunen wrote: On 02/28/2018 08:12 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 11:28 AM, Guenter Roeck wrote: On 02/27/2018 09:38 PM, Rajkumar Rampelli wrote: On Wednesday 21 February 2018 08:20 PM, Guenter Roeck wrote: On 02/20/2018 10:58 PM,