[PATCH] hwmon: (nct6775) Fix access to fan pulse registers

2018-09-06 Thread Guenter Roeck
Not all fans have a fan pulse register. This can result in reading beyond the end of REG_FAN_PULSES and FAN_PULSE_SHIFT arrays, and was reported by smatch as possible error. 1672 for (i = 0; i < ARRAY_SIZE(data->rpm); i++) {

[PATCH 1/2] hwmon: (mc13783-adc) Switch to SPDX identifier

2018-09-06 Thread Fabio Estevam
From: Fabio Estevam Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/hwmon/mc13783-adc.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/hwmon/mc13783-adc.c

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-06 Thread Guenter Roeck
On 09/05/2018 11:50 PM, Dan Carpenter wrote: On Wed, Sep 05, 2018 at 03:05:00PM -0700, Guenter Roeck wrote: Hi Dan, On 09/05/2018 12:57 AM, Dan Carpenter wrote: Done. Btw, I saw another that looks legit. Thanks ... drivers/hwmon/nct6775.c:1687 nct6775_update_device() error: buffer

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-06 Thread Dan Carpenter
On Wed, Sep 05, 2018 at 03:05:00PM -0700, Guenter Roeck wrote: > Hi Dan, > > On 09/05/2018 12:57 AM, Dan Carpenter wrote: > > Done. Btw, I saw another that looks legit. > > > Thanks ... > > > drivers/hwmon/nct6775.c:1687 nct6775_update_device() > > error: buffer overflow