Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Nicolin Chen
Hi Guenter, On Wed, Oct 10, 2018 at 04:43:00PM -0700, Guenter Roeck wrote: > > > The effort to do all this using CPU cycles would in most if not all cases > > > outweigh any perceived power savings. As such, I just don't see the > > > practical use case. > > > > It really depends on the use case

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On Wed, Oct 10, 2018 at 04:09:07PM -0700, Nicolin Chen wrote: > Hello Guenter, > > On Wed, Oct 10, 2018 at 06:22:39AM -0700, Guenter Roeck wrote: > > > > The hwmon core now has a new optional mode interface. So this patch > > > just implements this mode support so that user space

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Nicolin Chen
Hello Guenter, On Wed, Oct 10, 2018 at 06:22:39AM -0700, Guenter Roeck wrote: > > The hwmon core now has a new optional mode interface. So this patch > > just implements this mode support so that user space can check and > > configure via sysfs node its operating modes: power-down, one-shot, > >

Re: [PATCH 1/2] hwmon: (core) Add hwmon_mode structure and mode sysfs node

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On Wed, Oct 10, 2018 at 02:13:57PM -0700, Nicolin Chen wrote: > Hi Guenter, > > On Wed, Oct 10, 2018 at 06:08:30AM -0700, Guenter Roeck wrote: > > > +available_modes The available operating modes of the chip. > > > + This should be short, lowercase string, not containing > >

[PATCH] hwmon: (pmbus) remove redundant 'default n' from Kconfig

2018-10-10 Thread Bartlomiej Zolnierkiewicz
'default n' is the default value for any bool or tristate Kconfig setting so there is no need to write it explicitly. Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO is not set' for visible symbols") the Kconfig behavior is the same regardless of 'default n' being present or

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On 10/09/2018 09:33 PM, Nicolin Chen wrote: The hwmon core now has a new optional mode interface. So this patch just implements this mode support so that user space can check and configure via sysfs node its operating modes: power-down, one-shot, and continuous modes. One-shot