Re: [PATCH] hwmon: (pmbus) remove redundant 'default n' from Kconfig

2018-10-11 Thread Guenter Roeck
On Wed, Oct 10, 2018 at 04:35:57PM +0200, Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible

Re: [PATCH v2] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-11 Thread Guenter Roeck
On Tue, Oct 09, 2018 at 02:42:19PM -0700, Nicolin Chen wrote: > Trace events are useful for people who collect data from the > Ftrace outputs. There're people who analyse the relationship > of cpufreq, thermal and hwmon (power/voltage/current) using > the convenient and timestamped Ftrace outputs,

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Nicolin Chen
On Thu, Oct 11, 2018 at 12:31:52PM -0700, Guenter Roeck wrote: > > One more question here, and this might sound a bit abuse of using > > the existing hwmon ABI: would it sound plausible to you that the > > driver powers down the chip when all three channels get disabled > > via in[123]_enable

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Guenter Roeck
On Wed, Oct 10, 2018 at 05:24:12PM -0700, Nicolin Chen wrote: > Hi Guenter, > > On Wed, Oct 10, 2018 at 04:43:00PM -0700, Guenter Roeck wrote: > > > > The effort to do all this using CPU cycles would in most if not all > > > > cases > > > > outweigh any perceived power savings. As such, I just

Re: [PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-11 Thread Linus Walleij
On Mon, Oct 8, 2018 at 8:09 AM Hannes Reinecke wrote: > On 10/7/18 10:49 PM, Linus Walleij wrote: > Hmm. I might be getting something wrong here, but the main problem with > SMART values is that they are _not_ really standardized; plus any drive > is free to implement whatever they want. Yes so

[hwmon:watchdog-next 23/28] armada_37xx_wdt.c:undefined reference to `__udivdi3'

2018-10-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next head: 8de959ed4898d8f270fd990cbc551619799100ef commit: 6f935e7eff6f4fd9da9d54f46901b19ffc15df27 [23/28] watchdog: Add support for Armada 37xx CPU watchdog config: i386-allyesconfig (attached as