Re: ABI for these two registers?

2019-10-07 Thread Nicolin Chen
On Wed, Oct 02, 2019 at 10:03:11PM -0700, Guenter Roeck wrote: > On 10/1/19 3:17 PM, Nicolin Chen wrote: > > Hello Guenter, > > > > It's been nearly three weeks. Would it be possible for you to > > provide some advice on my latest questions? I'd like to write > > code and submit changes once ABI

[PATCH v4 2/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-07 Thread Tremblay, Eric
dt-bindings: Add TMP512/513 documentation Add documentation for TMP512/513 sensor chips Signed-off-by: Eric Tremblay --- .../devicetree/bindings/hwmon/tmp513.txt | 32 +++ 1 file changed, 32 insertions(+) create mode 100644

[PATCH v4 1/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-07 Thread Tremblay, Eric
hwmon: Add driver for Texas Instruments TMP512/513 sensor chips. TI's TMP512/513 are I2C/SMBus system monitor chips. These chips monitor the supply voltage, supply current, power consumption and provide one local and up to three (TMP513) remote temperature sensors. It has been tested using a TI

[PATCH v4 0/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-07 Thread Tremblay, Eric
Version four of the driver for Texas Instruments TMP512/513 sensors. Thanks again for the review. Main changes from version 3: - Remove tmp51x_config structure, there was no useful static field in the structure. The data was moved to tmp51x_data. - Remove platform data

Re: [PATCH 2/3] hwmon: Support ADI Fan Control IP

2019-10-07 Thread Sa, Nuno
On Mon, 2019-10-07 at 07:18 -0700, Guenter Roeck wrote: > > On 10/7/19 6:52 AM, Sa, Nuno wrote: > [ ... ] > > > > +static long axi_fan_control_get_pwm_duty(const struct > > > > axi_fan_control_data *ctl) > > > > +{ > > > > + u32 pwm_width = > > > > axi_fan_control_ioread(ADI_REG_PWM_WIDTH,

Re: [PATCH 2/3] hwmon: Support ADI Fan Control IP

2019-10-07 Thread Guenter Roeck
On 10/7/19 6:52 AM, Sa, Nuno wrote: [ ... ] +static long axi_fan_control_get_pwm_duty(const struct axi_fan_control_data *ctl) +{ + u32 pwm_width = axi_fan_control_ioread(ADI_REG_PWM_WIDTH, ctl); + u32 pwm_period = axi_fan_control_ioread(ADI_REG_PWM_PERIOD, ctl); + + return

Re: [PATCH 2/3] hwmon: Support ADI Fan Control IP

2019-10-07 Thread Sa, Nuno
On Sun, 2019-10-06 at 08:32 -0700, Guenter Roeck wrote: > > On Thu, Sep 26, 2019 at 12:39:24PM +0200, Nuno Sá wrote: > > The purpose of this IP Core is to control the fan used for the > > cooling of a > > Xilinx Zynq Ultrascale+ MPSoC without the need of any external > > temperature > > sensors.