Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-10-11 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 10:04 PM, Guenter Roeck wrote: > On 09/20/2016 01:01 PM, Timothy Pearson wrote: >> On 09/20/2016 02:59 PM, Guenter Roeck wrote: >> >> OK, sounds good. I looked back in the notes for this project and we had >> originally considered using

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-20 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 10:04 PM, Guenter Roeck wrote: > On 09/20/2016 01:01 PM, Timothy Pearson wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 09/20/2016 02:59 PM, Guenter Roeck wrote: >> OK, sounds good. I looked back in the notes for thi

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-20 Thread Guenter Roeck
On 09/20/2016 01:01 PM, Timothy Pearson wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 02:59 PM, Guenter Roeck wrote: On Tue, Sep 20, 2016 at 02:41:56PM -0500, Timothy Pearson wrote: On 09/19/2016 07:54 PM, Guenter Roeck wrote: On 09/19/2016 03:04 PM, Guenter Roeck wrote:

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-20 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 02:59 PM, Guenter Roeck wrote: > On Tue, Sep 20, 2016 at 02:41:56PM -0500, Timothy Pearson wrote: >> On 09/19/2016 07:54 PM, Guenter Roeck wrote: On 09/19/2016 03:04 PM, Guenter Roeck wrote: And then you are using all pmbus comm

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-20 Thread Guenter Roeck
On Tue, Sep 20, 2016 at 02:41:56PM -0500, Timothy Pearson wrote: > On 09/19/2016 07:54 PM, Guenter Roeck wrote: > >> On 09/19/2016 03:04 PM, Guenter Roeck wrote: > >> And then you are using all pmbus commands ? Seems odd. > > > > I guess I'l buy an evaluation board if one is available and check if

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-20 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2016 07:54 PM, Guenter Roeck wrote: >> On 09/19/2016 03:04 PM, Guenter Roeck wrote: >> And then you are using all pmbus commands ? Seems odd. > > I guess I'l buy an evaluation board if one is available and check if your > claim > is correct.

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2016 07:54 PM, Guenter Roeck wrote: > On Mon, Sep 19, 2016 at 03:31:33PM -0500, Timothy Pearson wrote: >> On 09/19/2016 03:04 PM, Guenter Roeck wrote: > And then you are using all pmbus commands ? Seems odd. > > I guess I'l buy an evaluation

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Guenter Roeck
On Mon, Sep 19, 2016 at 03:31:33PM -0500, Timothy Pearson wrote: > On 09/19/2016 03:04 PM, Guenter Roeck wrote: > > On Mon, Sep 19, 2016 at 01:40:36PM -0500, Timothy Pearson wrote: > > Not sure I understand. pwm[1-6]_enable = 0 means no fan speed control. > > Do you mean the (full speed) comment ?

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2016 03:04 PM, Guenter Roeck wrote: > On Mon, Sep 19, 2016 at 01:40:36PM -0500, Timothy Pearson wrote: > Not sure I understand. pwm[1-6]_enable = 0 means no fan speed control. > Do you mean the (full speed) comment ? "no fan speed control (i

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Guenter Roeck
On Mon, Sep 19, 2016 at 01:14:49PM -0500, Timothy Pearson wrote: > On 09/18/2016 08:41 PM, Guenter Roeck wrote: > > On Sun, Sep 18, 2016 at 07:50:55PM -0500, Timothy Pearson wrote: > >> Add a basic driver for the MAX31785, focusing on the fan control > >> features but ignoring the temperature and v

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Guenter Roeck
On Mon, Sep 19, 2016 at 01:40:36PM -0500, Timothy Pearson wrote: > On 09/18/2016 08:41 PM, Guenter Roeck wrote: > >> +Sysfs entries > >> +- > >> + > >> +fan[1-6]_input RO fan tachometer speed in RPM > >> +fan[1-6]_fault RO fan experienced fault > >> +fan[1-6]_targe

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/18/2016 08:41 PM, Guenter Roeck wrote: >> +Sysfs entries >> +- >> + >> +fan[1-6]_input RO fan tachometer speed in RPM >> +fan[1-6]_fault RO fan experienced fault >> +fan[1-6]_target RW desired fan speed

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-19 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/18/2016 08:41 PM, Guenter Roeck wrote: > On Sun, Sep 18, 2016 at 07:50:55PM -0500, Timothy Pearson wrote: >> Add a basic driver for the MAX31785, focusing on the fan control >> features but ignoring the temperature and voltage monitoring >> featu

Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-18 Thread Guenter Roeck
On Sun, Sep 18, 2016 at 07:50:55PM -0500, Timothy Pearson wrote: > Add a basic driver for the MAX31785, focusing on the fan control > features but ignoring the temperature and voltage monitoring > features of the device. > > This driver supports all fan control modes and tachometer / PWM > readbac

[PATCH] Initial driver for the MAX31785 intelligent fan controller

2016-09-18 Thread Timothy Pearson
Add a basic driver for the MAX31785, focusing on the fan control features but ignoring the temperature and voltage monitoring features of the device. This driver supports all fan control modes and tachometer / PWM readback where applicable. Signed-off-by: Timothy Pearson --- Documentation/hwmon