Re: [PATCH] hwmon: (w83773g) Fix a precedence bug in get_fault()

2017-12-05 Thread Guenter Roeck
On Tue, Dec 05, 2017 at 05:37:26PM +0300, Dan Carpenter wrote: > Shift has higher precedence than mask but presumably we wanted to set > *val to 1 if BIT(2) was set or 0 if the bit was clear. > > Fixes: de0a524e3e09 ("hwmon: Add W83773G driver") > Signed-off-by: Dan Carpenter

[PATCH] hwmon: (w83773g) Fix a precedence bug in get_fault()

2017-12-05 Thread Dan Carpenter
Shift has higher precedence than mask but presumably we wanted to set *val to 1 if BIT(2) was set or 0 if the bit was clear. Fixes: de0a524e3e09 ("hwmon: Add W83773G driver") Signed-off-by: Dan Carpenter diff --git a/drivers/hwmon/w83773g.c b/drivers/hwmon/w83773g.c