On Tue, Aug 14, 2018 at 09:34:30AM +, IKEGAMI Tokunori wrote:
> Hi Dan-san,
>
> Thank you so much for this fix also.
>
> Reviewed-by: Tokunori Ikegami
>
> By the way I will do try to change the adt7475_read_word() to return the
> error correctly in near future.
>
I can do that. Drop
le.com]
> Sent: Tuesday, August 14, 2018 6:15 PM
> To: Jean Delvare; IKEGAMI Tokunori
> Cc: Guenter Roeck; linux-hwmon@vger.kernel.org;
> kernel-janit...@vger.kernel.org
> Subject: [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks
>
> The adt7475_read_word() returns u16
The adt7475_read_word() returns u16 values, so it's impossible for
"ret" to be negative. The check is harmless, but static checkers
complain about it.
Signed-off-by: Dan Carpenter
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 16045149f3db..9d3da8ea38ba 100644
---
