Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Nicolin Chen
On Thu, Oct 11, 2018 at 12:31:52PM -0700, Guenter Roeck wrote: > > One more question here, and this might sound a bit abuse of using > > the existing hwmon ABI: would it sound plausible to you that the > > driver powers down the chip when all three channels get disabled > > via in[123]_enable

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Guenter Roeck
On Wed, Oct 10, 2018 at 05:24:12PM -0700, Nicolin Chen wrote: > Hi Guenter, > > On Wed, Oct 10, 2018 at 04:43:00PM -0700, Guenter Roeck wrote: > > > > The effort to do all this using CPU cycles would in most if not all > > > > cases > > > > outweigh any perceived power savings. As such, I just

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Nicolin Chen
Hi Guenter, On Wed, Oct 10, 2018 at 04:43:00PM -0700, Guenter Roeck wrote: > > > The effort to do all this using CPU cycles would in most if not all cases > > > outweigh any perceived power savings. As such, I just don't see the > > > practical use case. > > > > It really depends on the use case

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On Wed, Oct 10, 2018 at 04:09:07PM -0700, Nicolin Chen wrote: > Hello Guenter, > > On Wed, Oct 10, 2018 at 06:22:39AM -0700, Guenter Roeck wrote: > > > > The hwmon core now has a new optional mode interface. So this patch > > > just implements this mode support so that user space

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Nicolin Chen
Hello Guenter, On Wed, Oct 10, 2018 at 06:22:39AM -0700, Guenter Roeck wrote: > > The hwmon core now has a new optional mode interface. So this patch > > just implements this mode support so that user space can check and > > configure via sysfs node its operating modes: power-down, one-shot, > >

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On 10/09/2018 09:33 PM, Nicolin Chen wrote: The hwmon core now has a new optional mode interface. So this patch just implements this mode support so that user space can check and configure via sysfs node its operating modes: power-down, one-shot, and continuous modes. One-shot

[PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-09 Thread Nicolin Chen
The hwmon core now has a new optional mode interface. So this patch just implements this mode support so that user space can check and configure via sysfs node its operating modes: power-down, one-shot, and continuous modes. Signed-off-by: Nicolin Chen --- drivers/hwmon/ina3221.c | 64