Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-06 Thread Guenter Roeck
On 09/05/2018 11:50 PM, Dan Carpenter wrote: On Wed, Sep 05, 2018 at 03:05:00PM -0700, Guenter Roeck wrote: Hi Dan, On 09/05/2018 12:57 AM, Dan Carpenter wrote: Done. Btw, I saw another that looks legit. Thanks ... drivers/hwmon/nct6775.c:1687 nct6775_update_device() error: buffer

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-06 Thread Dan Carpenter
On Wed, Sep 05, 2018 at 03:05:00PM -0700, Guenter Roeck wrote: > Hi Dan, > > On 09/05/2018 12:57 AM, Dan Carpenter wrote: > > Done. Btw, I saw another that looks legit. > > > Thanks ... > > > drivers/hwmon/nct6775.c:1687 nct6775_update_device() > > error: buffer overflow

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-05 Thread Guenter Roeck
Hi Dan, On 09/05/2018 12:57 AM, Dan Carpenter wrote: Done. Btw, I saw another that looks legit. Thanks ... drivers/hwmon/nct6775.c:1687 nct6775_update_device() error: buffer overflow 'data->FAN_PULSE_SHIFT' 6 <= 6 drivers/hwmon/nct6775.c 1667 data->in[i][2] =

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-05 Thread Dan Carpenter
Done. Btw, I saw another that looks legit. drivers/hwmon/nct6775.c:1687 nct6775_update_device() error: buffer overflow 'data->FAN_PULSE_SHIFT' 6 <= 6 drivers/hwmon/nct6775.c 1667 data->in[i][2] = nct6775_read_value(data, 1668

Re: [bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-04 Thread Guenter Roeck
Hi Dan, On 09/04/2018 05:40 AM, Dan Carpenter wrote: Hello Guenter Roeck, The patch bbd8decd4123: "hwmon: (nct6775) Add support for weighted fan control" from Dec 4, 2012, leads to the following static checker warning: drivers/hwmon/nct6775.c:1562 nct6775_update_pwm() warn:

[bug report] hwmon: (nct6775) Add support for weighted fan control

2018-09-04 Thread Dan Carpenter
Hello Guenter Roeck, The patch bbd8decd4123: "hwmon: (nct6775) Add support for weighted fan control" from Dec 4, 2012, leads to the following static checker warning: drivers/hwmon/nct6775.c:1562 nct6775_update_pwm() warn: dead code because of 'j == 1' and 'j < (56 / 8 + 0)'