Re: [PATCHv3] hwmon: Add tc654 driver

On 10/09/2016 03:12 PM, Chris Packham wrote: Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham --- Changes in v3: - typofix in documentation - add

Re: [PATCH 04/10] i2c: i2c-mux-i2cs: Add device tree bindings

On Fri, Oct 07, 2016 at 06:21:03PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add binding document for the i2c mux driver of Juniper's I2CS FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis

Re: [PATCH 02/10] mfd: dt-bindings: Add bindings for the Juniper I2CS MFD

On Fri, Oct 07, 2016 at 06:21:01PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings for the Juniper I2CS MFD driver. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou

Re: [PATCHv3] hwmon: Add tc654 driver

On 10/11/2016 02:22 AM, Guenter Roeck wrote: >> +if (val) >> > + data->config |= TC654_REG_CONFIG_DUTYC; >> > + else >> > + data->config &= ~TC654_REG_CONFIG_DUTYC; > I just realized that this won't work as intended. Problem is that you > only fill data->config when reading

[PATCHv4] hwmon: Add tc654 driver

Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham --- Changes in v4: - tab-align values in #defines - ensure locking in set_pwm covers updating cached

Re: [PATCH v2] Documentation: dtb: lm87: Add hwmon binding documentation.

Hi Rob, Thank you for the comments, I'll address them and send back another patch shortly. As, for your question about " These need vendor prefixes. Or would they apply for multiple vendors of LM87?" The driver is shared between the ADM1024 H/W monitoring sensor and LM87 sensor, and both of

Re: [PATCH 0/7] Introduce PTX1K Boot FPGA driver

On Fri, Oct 07, 2016 at 06:21:57PM +0300, Pantelis Antoniou wrote: > Add Juniper's PTX1K Boot FPGA driver. Those FPGAs > are present in Juniper's PTX series of routers. > > The MFD driver provices watchdog/mtd/hwmon devices. > > There are full device tree binding documents for the > master mfd

Re: [PATCHv3] hwmon: Add tc654 driver

On Mon, Oct 10, 2016 at 08:08:14PM +, Chris Packham wrote: > On 10/11/2016 02:22 AM, Guenter Roeck wrote: > >> + if (val) > >> > +data->config |= TC654_REG_CONFIG_DUTYC; > >> > +else > >> > +data->config &= ~TC654_REG_CONFIG_DUTYC; > > I just realized

Re: [PATCHv4] hwmon: Add tc654 driver

On Tue, Oct 11, 2016 at 10:26:31AM +1300, Chris Packham wrote: > Add support for the tc654 and tc655 fan controllers from Microchip. > > http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf > > Signed-off-by: Chris Packham > --- > Changes in v4: > -

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

On Fri, Oct 07, 2016 at 02:32:13PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Tue, 4 Oct 2016 12:37:13 -0700, Guenter Roeck wrote: > > On Tue, Oct 04, 2016 at 10:45:59AM +0200, Jean Delvare wrote: > > > I see this patch is upstream now, but I had started reviewing it and > > > maybe some of

Re: [PATCH 04/10] i2c: i2c-mux-i2cs: Add device tree bindings

On 2016-10-07 17:21, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add binding document for the i2c mux driver of Juniper's I2CS FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou

Re: [PATCH 07/10] leds: i2cs: Add I2CS FPGA leds driver

Hi Pantelis, Thanks for the patch. Please find my comments in the code below. On 10/07/2016 05:21 PM, Pantelis Antoniou wrote: From: Georgi Vlaev Add support for the FRU faceplate status LEDs (OK, FAIL, ACTIVE, STANDBY) controlled by the Juniper I2CS FPGA. This driver is