Re: [PATCH v2 1/1] hwmon (occ): Add temp sensor value check

On Wed, Apr 17, 2019 at 01:35:41PM -0500, Eddie James wrote: > > On 4/17/19 1:03 PM, Alexander Amelkin wrote: > >From: Alexander Soldatov > > > >The occ driver supports two formats for the temp sensor value. > > > >The OCC firmware for P8 supports only the first format, for which > >no range

[PATCH v2 1/1] hwmon (occ): Add temp sensor value check

From: Alexander Soldatov The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources for P8 reveals that OCC may send a special value

Re: [PATCH 1/1] hwmon (occ): Add temp sensor value check

17.04.2019 16:03, Guenter Roeck wrote: > On 4/17/19 4:26 AM, Alexander Amelkin wrote: >> Inspecting the OCC sources for P8 reveals that OCC may send >> a special value 0x to indicate that a sensor read timeout >> has occured, see >> > occurred Yup. A typo. Will fix. > >>

Re: [PATCH v2 1/1] hwmon (occ): Add temp sensor value check

On 4/17/19 1:03 PM, Alexander Amelkin wrote: From: Alexander Soldatov The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources

[PATCH 1/1] hwmon (occ): Add temp sensor value check

From: Alexander Soldatov The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources for P8 reveals that OCC may send a special value

Re: [PATCH 1/1] hwmon (occ): Add temp sensor value check

On 4/17/19 4:26 AM, Alexander Amelkin wrote: From: Alexander Soldatov The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources

[PATCH v3 10/21] docs: hwmon: aspeed-pwm-tacho: convert to ReST format

Convert aspeed-pwm-tacho to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/aspeed-pwm-tacho | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/hwmon/aspeed-pwm-tacho b/Documentation/hwmon/aspeed-pwm-tacho

[PATCH v3 18/21] docs: hwmon: pmbus files: convert to ReST format

Convert pmbus files to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/adm1275| 26 Documentation/hwmon/ibm-cffps | 3 + Documentation/hwmon/ir35221| 11 +- Documentation/hwmon/lm25066| 30

[PATCH v3 07/21] docs: hwmon: fam15h_power: convert to ReST format

Convert fam15h_power to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/fam15h_power | 85 +--- 1 file changed, 57 insertions(+), 28 deletions(-) diff --git a/Documentation/hwmon/fam15h_power

[PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

Now that all files were converted to ReST format, rename them and add an index. Signed-off-by: Mauro Carvalho Chehab --- .../devicetree/bindings/hwmon/g762.txt| 2 +- Documentation/hwmon/{ab8500 => ab8500.rst}| 2 +- ...guru-datasheet => abituguru-datasheet.rst} | 0

[PATCH v3 19/21] docs: hwmon: misc files: convert to ReST format

Convert other files maintained by Guenter to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/ina209 | 18 -- Documentation/hwmon/ina2xx | 39 +--- Documentation/hwmon/jc42 | 55 -

[PATCH v3 15/21] docs: hwmon: wm831x, wm8350: convert to ReST format

Convert wm831x and wm8350 to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/wm831x | 9 ++--- Documentation/hwmon/wm8350 | 10 +++--- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH v3 16/21] docs: hwmon: da9052, da9055: convert to ReST format

Convert da9052 and da9055 to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/da9052 | 41 +++--- Documentation/hwmon/da9055 | 20 ++- 2 files changed, 44 insertions(+), 17

[PATCH v3 12/21] docs: hwmon: asc7621: convert to ReST format

Convert asc7621 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/asc7621 | 146 ++-- 1 file changed, 88 insertions(+), 58 deletions(-) diff --git a/Documentation/hwmon/asc7621

[PATCH v3 17/21] docs: hwmon: k8temp, w83793: convert to ReST format

Convert k8temp and w83793 to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/k8temp | 17 +++-- Documentation/hwmon/w83793 | 123 - 2 files changed, 77 insertions(+), 63 deletions(-)

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

; can be generated and pushed right after a commit window closes. Would > >> that by any chance be possible ? > > > > No, those patches are hand-maid, but I can surely rebase it on the top of > > your tree. Is your tree already merged at linux-next, or should I use some > > other branch/tree for rebase? > > > > linux-next merges hwmon-next. next-20190416 is missing one patch which touches > Documentation/hwmon, but that should be easy to deal with. Ok, did a rebase on the top of next-20190417. While re-reading the output of the html files, I noticed a few minor issues on some tables and fixed. Thanks, Mauro

[PATCH v3 11/21] docs: hwmon: ibmpowernv: convert to ReST format

Convert ibmpowernv to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/ibmpowernv | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/Documentation/hwmon/ibmpowernv

[PATCH v3 13/21] docs: hwmon: ads1015: convert to ReST format

Convert ads1015 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/ads1015 | 72 ++--- 1 file changed, 43 insertions(+), 29 deletions(-) diff --git a/Documentation/hwmon/ads1015

[PATCH v3 14/21] docs: hwmon: dme1737, vt1211: convert to ReST format

Convert dme1737 and vt1211 to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/dme1737 | 88 ++--- Documentation/hwmon/vt1211 | 84 +-- 2 files changed, 114

[PATCH v3 06/21] docs: hwmon: pc87360: convert to ReST format

Convert pc87360 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/pc87360 | 38 + 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/Documentation/hwmon/pc87360

[PATCH v3 01/21] docs: hwmon: k10temp: convert to ReST format

Convert k10temp to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/k10temp | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/Documentation/hwmon/k10temp

[PATCH v3 02/21] docs: hwmon: vexpress: convert to ReST format

Convert vexpress to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/vexpress | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/Documentation/hwmon/vexpress b/Documentation/hwmon/vexpress

[PATCH v3 09/21] docs: hwmon: coretemp: convert to ReST format

Convert coretemp to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/coretemp | 46 +++- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/Documentation/hwmon/coretemp

[PATCH v3 08/21] docs: hwmon: w83791d: convert to ReST format

Convert w83791d to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/w83791d | 123 +--- 1 file changed, 71 insertions(+), 52 deletions(-) diff --git a/Documentation/hwmon/w83791d

[PATCH v3 05/21] docs: hwmon: emc2103: convert to ReST format

Convert emc2103 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/emc2103 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/hwmon/emc2103 b/Documentation/hwmon/emc2103 index

[PATCH v3 04/21] docs: hwmon: sch5627: convert to ReST format

Convert sch5627 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/sch5627 | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/hwmon/sch5627 b/Documentation/hwmon/sch5627 index 0551d266c51c..187682e99114

[PATCH v3 03/21] docs: hwmon: menf21bmc: convert to ReST format

Convert menf21bmc to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/menf21bmc | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/hwmon/menf21bmc b/Documentation/hwmon/menf21bmc index

Re: [PATCH v3 02/21] docs: hwmon: vexpress: convert to ReST format

On Wed, Apr 17, 2019 at 06:46:10AM -0300, Mauro Carvalho Chehab wrote: > Convert vexpress to ReST format, in order to allow it to > be parsed by Sphinx. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/hwmon/vexpress | 13 ++--- > 1 file changed, 10 insertions(+), 3

Re: [PATCH v3 02/21] docs: hwmon: vexpress: convert to ReST format

Em Wed, 17 Apr 2019 11:24:15 +0100 Liviu Dudau escreveu: > On Wed, Apr 17, 2019 at 06:46:10AM -0300, Mauro Carvalho Chehab wrote: > > Convert vexpress to ReST format, in order to allow it to > > be parsed by Sphinx. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > >

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

On Wed, Apr 17, 2019 at 06:46:29AM -0300, Mauro Carvalho Chehab wrote: > Now that all files were converted to ReST format, rename them > and add an index. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../devicetree/bindings/hwmon/g762.txt| 2 +- > Documentation/hwmon/{ab8500 =>

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On 4/16/19 4:55 PM, Nicolin Chen wrote: The CONFIG register has two 3-bit fields for conversion time settings of Bus-voltage and Shunt-voltage, respectively. The conversion settings, along with averaging mode, allow users to optimize available timing requirement. This patch adds an

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On 4/17/19 6:46 AM, Guenter Roeck wrote: On 4/16/19 4:55 PM, Nicolin Chen wrote: The CONFIG register has two 3-bit fields for conversion time settings of Bus-voltage and Shunt-voltage, respectively. The conversion settings, along with averaging mode, allow users to optimize available timing

Re: [PATCH 1/4] hwmon: (pmbus) add support for output voltage registers

On Tue, Apr 16, 2019 at 06:57:18PM -0700, Ruslan Babayev wrote: > Hi Guenter, > > Thanks for taking the time to review these patches. Please see my > comments inline. > > Guenter Roeck writes: > > > On Tue, Apr 16, 2019 at 11:36:16AM -0700, Ruslan Babayev wrote: > >> +static ssize_t

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

On Wed, Apr 17, 2019 at 06:46:29AM -0300, Mauro Carvalho Chehab wrote: > Now that all files were converted to ReST format, rename them > and add an index. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Liviu Dudau I applied all patches except this one, which fails due to a conflict in

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

On Wed, Apr 17, 2019 at 09:47:41AM -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2019 at 06:46:29AM -0300, Mauro Carvalho Chehab wrote: > > Now that all files were converted to ReST format, rename them > > and add an index. > > > > Signed-off-by: Mauro Carvalho Chehab > > Acked-by: Liviu Dudau

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

Em Wed, 17 Apr 2019 09:47:41 -0700 Guenter Roeck escreveu: > On Wed, Apr 17, 2019 at 06:46:29AM -0300, Mauro Carvalho Chehab wrote: > > Now that all files were converted to ReST format, rename them > > and add an index. > > > > Signed-off-by: Mauro Carvalho Chehab > > Acked-by: Liviu Dudau

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

Em Wed, 17 Apr 2019 14:13:52 -0300 Mauro Carvalho Chehab escreveu: > Em Wed, 17 Apr 2019 09:47:41 -0700 > Guenter Roeck escreveu: > > > On Wed, Apr 17, 2019 at 06:46:29AM -0300, Mauro Carvalho Chehab wrote: > > > Now that all files were converted to ReST format, rename them > > > and add an

Re: [PATCH v3 21/21] docs: hwmon: Add an index file and rename docs to *.rst

On Wed, Apr 17, 2019 at 10:43:37AM -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2019 at 02:22:15PM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 17 Apr 2019 14:13:52 -0300 > > Mauro Carvalho Chehab escreveu: > > > > > Em Wed, 17 Apr 2019 09:47:41 -0700 > > > Guenter Roeck escreveu: > > > >

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On Wed, Apr 17, 2019 at 07:04:09AM -0700, Guenter Roeck wrote: > > > I am not quite sure if this update_interval is the best way to > > > implement the conversion time settings but I can't find another > > > common approach. This implementation certainly has drawbacks: > > >   1) It can't

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On Wed, Apr 17, 2019 at 11:39:49AM -0700, Nicolin Chen wrote: > > Thinking about it ... does it even make sense to cache reg_config twice, > > or would it be better to just update the local copy and use regmap_write() > > to send it to the chip ? > > I remember the reason of adding the read-back

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On Wed, Apr 17, 2019 at 12:48:18PM -0700, Nicolin Chen wrote: > On Wed, Apr 17, 2019 at 11:39:49AM -0700, Nicolin Chen wrote: > > > > Thinking about it ... does it even make sense to cache reg_config twice, > > > or would it be better to just update the local copy and use regmap_write() > > > to

Re: [PATCH] hwmon: (ina3221) Add voltage conversion time settings

On Wed, Apr 17, 2019 at 01:12:34PM -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2019 at 12:48:18PM -0700, Nicolin Chen wrote: > > On Wed, Apr 17, 2019 at 11:39:49AM -0700, Nicolin Chen wrote: > > > > > > Thinking about it ... does it even make sense to cache reg_config twice, > > > > or would it

[PATCH v2 0/2] hwmon: (ina3221) Two changes for INA3221

Adding two changes for INA3221 HWMON driver. Changlog v1->v2: * Added PATCH-1 * Rebased PATCH-2 (see detail of changelog in it) Nicolin Chen (2): hwmon: (ina3221) Do not read-back to cache reg_config hwmon: (ina3221) Add voltage conversion time settings Documentation/hwmon/ina3221 | 9

[PATCH v2 2/2] hwmon: (ina3221) Add voltage conversion time settings

The CONFIG register has two 3-bit fields for conversion time settings of Bus-voltage and Shunt-voltage, respectively. The conversion settings, along with averaging mode, allow users to optimize available timing requirement. This patch adds an 'update_interval' sysfs node through the