On 08/16/2019 02:36 PM, Geert Uytterhoeven wrote:
> Hi Max,
>
> On Fri, Aug 16, 2019 at 2:25 PM Max Staudt wrote:
>> On 08/16/2019 01:07 PM, Geert Uytterhoeven wrote:
>>> One minor nit: as the driver no longer uses any of_*() symbols, you can
>>> replace
>>> #include by #include .
>>
>> I
On 08/16/2019 01:51 PM, Wolfram Sang wrote:
>
>> +if (IS_ERR(new_fwnode))
>> +dev_info(>dev, "Failed to create fwnode for LTC2990, error:
>> %ld\n",
>> + PTR_ERR(new_fwnode));
>> +else {
>
> Braces for both blocks. Did you run checkpatch?
I did, and it
Hi Max,
On Fri, Aug 16, 2019 at 2:25 PM Max Staudt wrote:
> On 08/16/2019 01:07 PM, Geert Uytterhoeven wrote:
> > One minor nit: as the driver no longer uses any of_*() symbols, you can
> > replace
> > #include by #include .
>
> I should have thought of that, sorry.
>
> Another patch, or will
Hi Max,
On Fri, Aug 16, 2019 at 11:09 AM Max Staudt wrote:
> ltc2990 will now use device_property_read_u32_array() instead of
> of_property_read_u32_array() - allowing the use of software nodes
> via fwnode_create_software_node().
>
> This allows code using i2c_new_device() to specify a default
On 08/16/2019 01:07 PM, Geert Uytterhoeven wrote:
> Reviewed-by: Geert Uytterhoeven
Thank you!
> One minor nit: as the driver no longer uses any of_*() symbols, you can
> replace
> #include by #include .
I should have thought of that, sorry.
Another patch, or will you do it?
Max
ltc2990 will now use device_property_read_u32_array() instead of
of_property_read_u32_array() - allowing the use of software nodes
via fwnode_create_software_node().
This allows code using i2c_new_device() to specify a default
measurement mode for the LTC2990 via fwnode_create_software_node().
Since the 2019 a1k.org community re-print of these PCBs sports an
LTC2990 hwmon chip as an example use case, let this driver autoprobe
for that as well. If it is present, modprobing ltc2990 is sufficient.
The property_entry enables the three additional inputs available on
this particular board:
On 8/16/19 5:43 AM, Max Staudt wrote:
On 08/16/2019 02:36 PM, Geert Uytterhoeven wrote:
Hi Max,
On Fri, Aug 16, 2019 at 2:25 PM Max Staudt wrote:
On 08/16/2019 01:07 PM, Geert Uytterhoeven wrote:
One minor nit: as the driver no longer uses any of_*() symbols, you can replace
#include by
On Fri, Aug 16, 2019 at 1:50 AM Guenter Roeck wrote:
> On Fri, Aug 16, 2019 at 12:19:42AM +0200, Max Staudt wrote:
> > On 08/15/2019 02:58 PM, Max Staudt wrote:
> > > - if (of_node) {
> > > - ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
> > > -
On 08/16/2019 12:43 AM, Guenter Roeck wrote:
> On Fri, Aug 16, 2019 at 12:19:42AM +0200, Max Staudt wrote:
>> On 08/15/2019 02:58 PM, Max Staudt wrote:
>>> - if (of_node) {
>>> - ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
>>> -
ltc2990 will now use device_property_read_u32_array() instead of
of_property_read_u32_array() - allowing the use of software nodes
via fwnode_create_software_node().
This allows code using i2c_new_device() to specify a default
measurement mode for the LTC2990 via fwnode_create_software_node().
11 matches
Mail list logo
