Re: [RFC 3/4] hwmon: add Gateworks System Controller support

2018-02-28 Thread Tim Harvey
On Tue, Feb 27, 2018 at 6:05 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 02/27/2018 05:21 PM, Tim Harvey wrote: >> >> The Gateworks System Controller has a hwmon sub-component that exposes >> up to 16 ADC's, some of which are temperature sensors, others which are

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-28 Thread Tim Harvey
On Tue, Feb 27, 2018 at 6:00 PM, Randy Dunlap <rdun...@infradead.org> wrote: > On 02/27/2018 05:21 PM, Tim Harvey wrote: >> The Gateworks System Controller (GSC) is an I2C slave controller >> implemented with an MSP430 micro-controller whose firmware embeds the >> fo

Re: [PATCH v2 4/4] input: misc: Add Gateworks System Controller support

2018-03-14 Thread Tim Harvey
On Sat, Mar 10, 2018 at 10:45 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Mon, Mar 05, 2018 at 02:02:41PM -0800, Tim Harvey wrote: >> Add support for dispatching Linux Input events for the various interrupts >> the Gateworks System Controller provides. >

Re: [v3,4/4] watchdog: add Gateworks System Controller support

2018-04-04 Thread Tim Harvey
On Mon, Apr 2, 2018 at 9:32 AM, Andrew Lunn wrote: >> The 'use case' we have been using this in for a couple years is that >> users who want to use this watchdog will enable it externally (we have >> a command in the bootloader) and if enabled the kernel driver (that >> I'm

Re: [v3,4/4] watchdog: add Gateworks System Controller support

2018-03-30 Thread Tim Harvey
On Thu, Mar 29, 2018 at 6:07 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On Wed, Mar 28, 2018 at 08:14:03AM -0700, Tim Harvey wrote: >> Signed-off-by: Tim Harvey <thar...@gateworks.com> >> --- >> drivers/watchdog/Kconfig | 10 >> drivers/watchdog

Re: [PATCH v3 3/4] hwmon: add Gateworks System Controller support

2018-03-28 Thread Tim Harvey
On Wed, Mar 28, 2018 at 10:00 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On Wed, Mar 28, 2018 at 08:14:02AM -0700, Tim Harvey wrote: >> The Gateworks System Controller has a hwmon sub-component that exposes >> up to 16 ADC's, some of which are temperature sensors, others

Re: [PATCH v3 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-28 Thread Tim Harvey
On Wed, Mar 28, 2018 at 9:24 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On Wed, Mar 28, 2018 at 08:14:00AM -0700, Tim Harvey wrote: >> This patch adds documentation of device-tree bindings for the >> Gateworks System Controller (GSC). >> >> Signed-off-by:

Re: [PATCH v3 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-28 Thread Tim Harvey
On Wed, Mar 28, 2018 at 1:23 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On Wed, Mar 28, 2018 at 12:17:34PM -0700, Tim Harvey wrote: >> On Wed, Mar 28, 2018 at 9:24 AM, Guenter Roeck <li...@roeck-us.net> wrote: >> > On Wed, Mar 28, 2018 at 08:14:00AM -0700, Tim

Re: [v3,4/4] watchdog: add Gateworks System Controller support

2018-04-02 Thread Tim Harvey
On Fri, Mar 30, 2018 at 11:19 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On Fri, Mar 30, 2018 at 10:49:38AM -0700, Tim Harvey wrote: >> On Thu, Mar 29, 2018 at 6:07 PM, Guenter Roeck <li...@roeck-us.net> wrote: >> > On Wed, Mar 28, 2018 at 08:14:03AM -0700, Tim

Re: [PATCH v3 2/4] mfd: add Gateworks System Controller core driver

2018-04-03 Thread Tim Harvey
On Wed, Mar 28, 2018 at 8:14 AM, Tim Harvey <thar...@gateworks.com> wrote: > The Gateworks System Controller (GSC) is an I2C slave controller > implemented with an MSP430 micro-controller whose firmware embeds the > following features: > - I/O expander (16 GPIO's) using PCA955x

Re: [PATCH v3 2/4] mfd: add Gateworks System Controller core driver

2018-04-03 Thread Tim Harvey
On Tue, Apr 3, 2018 at 9:47 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Tue, Apr 03, 2018 at 08:48:27AM -0700, Tim Harvey wrote: >> On Wed, Mar 28, 2018 at 8:14 AM, Tim Harvey <thar...@gateworks.com> wrote: >> > The Gateworks System Controller (GSC) is an I2C sla

[PATCH v3 4/4] watchdog: add Gateworks System Controller support

2018-03-28 Thread Tim Harvey
Signed-off-by: Tim Harvey <thar...@gateworks.com> --- drivers/watchdog/Kconfig | 10 drivers/watchdog/Makefile | 1 + drivers/watchdog/gsc_wdt.c | 146 + 3 files changed, 157 insertions(+) create mode 100644 drivers/watchdog/gsc_wdt.c

[PATCH v3 0/4] Add support for the Gateworks System Controller

2018-03-28 Thread Tim Harvey
of of to own function - use strlcpy to ensure null termination - fix static array sizes and removed unnecessary initializers - dynamically allocate channels - fix fan input label - support platform data Tim Harvey (4): dt-bindings: mfd: Add Gateworks System Controller bindings mfd: add Gateworks

[PATCH v3 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-28 Thread Tim Harvey
This patch adds documentation of device-tree bindings for the Gateworks System Controller (GSC). Signed-off-by: Tim Harvey <thar...@gateworks.com> --- v3: - replaced _ with - - remove input bindings - added full description of hwmon - fix unit address of hwmon child nodes --- .../devi

[PATCH v3 2/4] mfd: add Gateworks System Controller core driver

2018-03-28 Thread Tim Harvey
rr_regmap: + i2c_unregister_device(gsc->i2c_hwmon); + + return ret; +} + +static int gsc_remove(struct i2c_client *client) +{ + struct gsc_dev *gsc = i2c_get_clientdata(client); + + sysfs_remove_group(>dev.kobj, _group); + i2c_unregister_device(gsc->i2c_hwmon); + +

Re: [PATCH v2 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-23 Thread Tim Harvey
On Fri, Mar 9, 2018 at 3:14 PM, Rob Herring <r...@kernel.org> wrote: > On Mon, Mar 05, 2018 at 02:02:38PM -0800, Tim Harvey wrote: >> This patch adds documentation of device-tree bindings for the >> Gateworks System Controller (GSC). >> >> Signed-off-by:

[PATCH v2 0/4] Add support for the Gateworks System Controller

2018-03-05 Thread Tim Harvey
(enumating DS1672) - HWMON - Interrupt controller with tamper detect, user pushbotton - Watchdog controller capable of full board power-cycle - Power Control capable of full board power-cycle see http://trac.gateworks.com/wiki/gsc for more details Tim Harvey (4): dt-bindings: mfd: Add

[PATCH v2 4/4] input: misc: Add Gateworks System Controller support

2018-03-05 Thread Tim Harvey
Add support for dispatching Linux Input events for the various interrupts the Gateworks System Controller provides. Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> Signed-off-by: Tim Harvey <thar...@gateworks.com> --- v2: - reword Kconfig - revise license comment block - remove unne

[PATCH v2 3/4] hwmon: add Gateworks System Controller support

2018-03-05 Thread Tim Harvey
eck-us.net> Signed-off-by: Tim Harvey <thar...@gateworks.com> --- v2: - change license comment style - remove DEBUG - simplify regmap_bulk_read err check - remove break after returns in switch statement - fix fan setpoint buffer address - remove unnecessary parens - consistently use struct

[PATCH v2 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-05 Thread Tim Harvey
This patch adds documentation of device-tree bindings for the Gateworks System Controller (GSC). Signed-off-by: Tim Harvey <thar...@gateworks.com> --- Documentation/devicetree/bindings/mfd/gsc.txt | 159 ++ 1 file changed, 159 insertions(+) create mode

Re: [RFC 0/4] Add support for the Gateworks System Controller

2018-02-28 Thread Tim Harvey
On Wed, Feb 28, 2018 at 6:44 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Tue, Feb 27, 2018 at 05:21:10PM -0800, Tim Harvey wrote: >> This series adds support for the Gateworks System Controller used on >> Gateworks >> Laguna, Ventana, and Newport product families. >

[RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-27 Thread Tim Harvey
custom protocol - Interrupt controller with tamper detect, user pushbotton - Watchdog controller capable of full board power-cycle - Power Control capable of full board power-cycle see http://trac.gateworks.com/wiki/gsc for more details Signed-off-by: Tim Harvey <thar...@gateworks.

[RFC 0/4] Add support for the Gateworks System Controller

2018-02-27 Thread Tim Harvey
(enumating DS1672) - HWMON - Interrupt controller with tamper detect, user pushbotton - Watchdog controller capable of full board power-cycle - Power Control capable of full board power-cycle see http://trac.gateworks.com/wiki/gsc for more details Tim Harvey (4): dt-bindings: mfd: Add

[RFC 4/4] input: misc: Add Gateworks System Controller support

2018-02-27 Thread Tim Harvey
Add support for dispatching Linux Input events for the various interrupts the Gateworks System Controller provides. Signed-off-by: Tim Harvey <thar...@gateworks.com> --- drivers/input/misc/Kconfig | 6 ++ drivers/input/misc/Makefile| 1 + drivers/input/misc/gsc-input.c

[RFC 3/4] hwmon: add Gateworks System Controller support

2018-02-27 Thread Tim Harvey
The Gateworks System Controller has a hwmon sub-component that exposes up to 16 ADC's, some of which are temperature sensors, others which are voltage inputs. The ADC configuration (register mapping and name) is configured via device-tree and varies board to board. Signed-off-by: Tim Harvey <t

[RFC 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-02-27 Thread Tim Harvey
This patch adds documentation of device-tree bindings for the Gateworks System Controller (GSC). Signed-off-by: Tim Harvey <thar...@gateworks.com> --- Documentation/devicetree/bindings/mfd/gsc.txt | 69 +++ 1 file changed, 69 insertions(+) create mode