Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Thomas Gleixner
xactly > happy if anyone pushes a patch into arch/x86 without their approval. Adding those PCI ids looks straight forward. So feel free to route them through hwmon with: Acked-by: Thomas Gleixner

Re: [PATCH v2 0/2] occ: FSI and hwmon: Fix license headers

2019-01-29 Thread Thomas Gleixner
On Mon, 28 Jan 2019, Eddie James wrote: > From: Eddie James > > Source files for the FSI OCC and OCC hwmon drivers had a combination of bad > license information and missing IBM copyright. Correct the licenses. Thanks for cleaning that up! tglx

Re: [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data

2019-01-17 Thread Thomas Gleixner
Eddie, On Wed, 11 Jul 2018, Eddie James wrote: > --- /dev/null > +++ b/drivers/hwmon/occ/sysfs.c > @@ -0,0 +1,188 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * OCC hwmon driver sysfs interface > + * > + * Copyright (C) IBM Corporation 2018 > + * > + * This program is free software; you

Re: [PATCH v3 1/2] x86/amd_nb: Add support for Raven Ridge CPUs

2018-05-13 Thread Thomas Gleixner
t> Guenter, if you want to take that through hwmon: Acked-by: Thomas Gleixner <t...@linutronix.de> If not, let me know. > --- > v3: No change. > v2: Use naming scheme suggested by Borislav Petkov. > > arch/x86/kernel/amd_nb.c | 6 ++ > 1 file changed

Re: [PATCH] hwmon: (coretemp) remove duplicated coretemp for same core id

2017-10-19 Thread Thomas Gleixner
On Wed, 18 Oct 2017, Guenter Roeck wrote: > On 10/18/2017 07:28 PM, Shu Wang wrote: > > > > > > Fix kernel warning on my 4cpus 2core_id system. The cpu0 and cpu1 > > > > > > have same core_id 0, so both cpu0 and cpu1 will try to create file > > > > > > temp2_label when it's online. > > > > > > >

[PATCH] hwmon: (coretemp) Handle frozen hotplug state correctly

2017-05-10 Thread Thomas Gleixner
. Fixes: e00ca5df37ad ("hwmon: (coretemp) Convert to hotplug state machine") Reported-by: Tommi Rantala <tt.rant...@gmail.com> Signed-off-by: Thomas Gleixner <t...@linutronix.de> --- drivers/hwmon/coretemp.c | 14 ++ 1 file changed, 14 insertions(+) --- a/drivers/

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-05-10 Thread Thomas Gleixner
On Wed, 10 May 2017, Tommi Rantala wrote: > 2017-05-09 10:16 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > On Thu, 4 May 2017, Tommi Rantala wrote: > >> Here's the trace output, does it help? > > > > Not much. Can you please try the following: > >

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-05-09 Thread Thomas Gleixner
On Thu, 4 May 2017, Tommi Rantala wrote: > 2017-04-23 18:01 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > On Sat, 15 Apr 2017, Tommi Rantala wrote: > > > >> Testing with 4.10.8-200.fc25.x86_64: freezer, devices and platform are > >> OK, it breaks at

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-23 Thread Thomas Gleixner
On Sat, 15 Apr 2017, Tommi Rantala wrote: > 2017-04-14 20:35 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > On Wed, 12 Apr 2017, Thomas Gleixner wrote: > >> > >> Can you please try the following: > >> > >> # for STATE in freezer device

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-14 Thread Thomas Gleixner
On Wed, 12 Apr 2017, Thomas Gleixner wrote: > On Wed, 12 Apr 2017, Tommi Rantala wrote: > > 2017-04-12 13:52 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > > Can you please try to offline/online CPUs from the console? > > > > > > # echo 0 >/sys/de

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Thomas Gleixner
On Wed, 12 Apr 2017, Tommi Rantala wrote: > 2017-04-12 13:52 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > Can you please try to offline/online CPUs from the console? > > > > # echo 0 >/sys/devices/system/cpu1/online > > # echo 1 >/sys/devices

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Thomas Gleixner
On Wed, 12 Apr 2017, Tommi Rantala wrote: > 2017-04-12 12:28 GMT+03:00 Thomas Gleixner <t...@linutronix.de>: > > On Wed, 12 Apr 2017, Tommi Rantala wrote: > >> Resume-from-suspend stopped working in HP xw6600 in fedora kernel > >> 4.10.8-200.fc25.x86_64, while it w

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Thomas Gleixner
On Wed, 12 Apr 2017, Tommi Rantala wrote: > Resume-from-suspend stopped working in HP xw6600 in fedora kernel > 4.10.8-200.fc25.x86_64, while it worked just fine in > 4.9.9-200.fc25.x86_64. > > When powering on the suspended PC, there is no video output, and to > recover, I need to reset the

[patch 4/6] [PREEMPT-RT] hwmon/coretemp: Convert to hotplug state machine

2016-11-22 Thread Thomas Gleixner
Install the callbacks via the state machine. Setup and teardown are handled by the hotplug core. Signed-off-by: Sebastian Andrzej Siewior Cc: linux-hwmon@vger.kernel.org Cc: Fenghua Yu Cc: Jean Delvare Cc: r...@linuxtronix.de Cc:

[patch 3/6] hwmon/coretemp: Avoid redundant lookups

2016-11-22 Thread Thomas Gleixner
No point in looking up the same thing over and over. Signed-off-by: Thomas Gleixner <t...@linutronix.de> --- drivers/hwmon/coretemp.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -533,21 +

[patch 5/6] hwmon/coretemp: Use proper error codes in cpu online callback

2016-11-22 Thread Thomas Gleixner
when the device cannot be initialized and remove all the magic cruft. Signed-off-by: Thomas Gleixner <t...@linutronix.de> --- drivers/hwmon/coretemp.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/core

[patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2016-11-22 Thread Thomas Gleixner
After the first attempt to convert the coretemp driver to the hotplug state machine failed, we had a deeper look and went a bit farther. The driver has quite some interesting concepts vs. the package, core and sysfs file management and a bug in the package temperature sysfs interface vs. cpu

Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers

2016-06-02 Thread Thomas Gleixner
On Thu, 2 Jun 2016, Borislav Petkov wrote: > static int read_registers(struct fam15h_power_data *data) > { > - int this_cpu, ret, cpu; > int core, this_core; > cpumask_var_t mask; > + int ret, cpu; > > ret = zalloc_cpumask_var(, GFP_KERNEL); > if (!ret) > @@