Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller
On 09/20/2016 01:01 PM, Timothy Pearson wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 02:59 PM, Guenter Roeck wrote: On Tue, Sep 20, 2016 at 02:41:56PM -0500, Timothy Pearson wrote: On 09/19/2016 07:54 PM, Guenter Roeck wrote: On 09/19/2016 03:04 PM, Guenter Roeck wrote: And then you are using all pmbus commands ? Seems odd. I guess I'l buy an evaluation board if one is available and check if your claim is correct. I am not inclined to accept a non-pmbus driver for a pmbus device without good reason. Guenter Regarding the PMBus driver, I looked over the documentation available here: https://www.kernel.org/doc/Documentation/hwmon/pmbus From what I can tell PMBus drivers do not support configuring the fan control parameters, only monitoring the fan status and speed. Is this correct, and if not where would I find the correct documentation? So far that wasn't needed. That doesn't mean it can not be added. I orderd an evaluation board and will likely spend some time on it myself after I get it. Guenter OK, sounds good. I looked back in the notes for this project and we had originally considered using a PMBus driver but ran into the kernel documentation, noted the missing control features, and I subsequently It is always useful to talk with the maintainer. misinterpreted the datasheet using the kernel docs as a reference. This is why the hwmon driver was implemented. I am still not sure I understand what irked you off in the datasheet. Is it the "supports a subset of the commands defined in the PMBus Specfication" ? If so, please keep in mind that every single chip supporting PMBus will only support a subset of PMBus commands. Please let me know if I can be of any assistance. Sure, I'll let you know. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2016 02:59 PM, Guenter Roeck wrote: > On Tue, Sep 20, 2016 at 02:41:56PM -0500, Timothy Pearson wrote: >> On 09/19/2016 07:54 PM, Guenter Roeck wrote: On 09/19/2016 03:04 PM, Guenter Roeck wrote: And then you are using all pmbus commands ? Seems odd. >>> >>> I guess I'l buy an evaluation board if one is available and check if your >>> claim >>> is correct. I am not inclined to accept a non-pmbus driver for a pmbus >>> device without good reason. >>> >>> Guenter >> >> Regarding the PMBus driver, I looked over the documentation available >> here: https://www.kernel.org/doc/Documentation/hwmon/pmbus >> >> From what I can tell PMBus drivers do not support configuring the fan >> control parameters, only monitoring the fan status and speed. Is this >> correct, and if not where would I find the correct documentation? >> > So far that wasn't needed. That doesn't mean it can not be added. > > I orderd an evaluation board and will likely spend some time on it myself > after I get it. > > Guenter OK, sounds good. I looked back in the notes for this project and we had originally considered using a PMBus driver but ran into the kernel documentation, noted the missing control features, and I subsequently misinterpreted the datasheet using the kernel docs as a reference. This is why the hwmon driver was implemented. Please let me know if I can be of any assistance. Thanks! - -- Timothy Pearson Raptor Engineering +1 (415) 727-8645 (direct line) +1 (512) 690-0200 (switchboard) https://www.raptorengineering.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJX4ZWeAAoJEK+E3vEXDOFbSNkH/3IqLAbvz2aVyPUBhKBFHC72 0uaP/IhBIoDoKAdZ50jJljYQIub0hn6HrQH52SYXvNhkO43+UJwqOxIRliipueDg X9H2esdeaptjI+O3dXCv5bLyMgy+ohGv1aPkxon+BTo506NWlHOyYlbCscIgmuMu nsMmHVGQvEyMtbJHlwmT0tjE81IEYxFxc1eLPbPhcrdz1f6yIAY7tHFo5ZjE+wt8 mzU35ZI+zIkKbD88Qfs8Ca/aTfRzt5xDKHDI3//YouyiqlnDK7etoZrAtx2RxtcJ Qv8k2udTpQuuYwwGobwC0SSWaxeRMlRaumX+ZkIYJz7xSp1krnArx5na2r2cTr8= =Guwk -END PGP SIGNATURE- -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
