Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-22 Thread Claudiu Beznea
On 22.02.2018 14:33, Daniel Thompson wrote: > On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: >> Add PWM mode to pwm_config() function. The drivers which uses pwm_config() >> were adapted to this change. >> >> Signed-off-by: Claudiu Beznea >> --- >>

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-22 Thread Claudiu Beznea
On 22.02.2018 15:01, Sean Young wrote: > On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: >> Add PWM mode to pwm_config() function. The drivers which uses pwm_config() >> were adapted to this change. >> >> Signed-off-by: Claudiu Beznea >> --- > >

[PATCH v3 06/10] pwm: add PWM modes

2018-02-22 Thread Claudiu Beznea
Add PWM normal and complementary modes. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pwm.txt | 9 +++-- Documentation/pwm.txt | 26 +++--- include/dt-bindings/pwm/pwm.h | 1

[PATCH v3 00/10] extend PWM framework to support PWM modes

2018-02-22 Thread Claudiu Beznea
Hi all, Please give feedback on these patches which extends the PWM framework in order to support multiple PWM modes of operations. This series is a rework of [1] and [2]. The current patch series add the following PWM modes: - PWM mode normal - PWM mode complementary - PWM mode push-pull

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-22 Thread Daniel Thompson
On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: > Add PWM mode to pwm_config() function. The drivers which uses pwm_config() > were adapted to this change. > > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-s3c24xx/mach-rx1950.c | 11

[PATCH v3 10/10] pwm: atmel: add push-pull mode support

2018-02-22 Thread Claudiu Beznea
Add support for PWM push-pull mode. This is only supported by SAMA5D2 SoCs. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git

[PATCH v3 09/10] pwm: add documentation for pwm push-pull mode

2018-02-22 Thread Claudiu Beznea
Add documentation for PWM push-pull mode. Signed-off-by: Claudiu Beznea Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pwm/pwm.txt | 2 ++ Documentation/pwm.txt | 16

[PATCH v3 01/10] pwm: extend PWM framework with PWM modes

2018-02-22 Thread Claudiu Beznea
Add basic PWM modes: normal and complementary. These modes should differentiate the single output PWM channels from two outputs PWM channels. These modes could be set as follow: 1. PWM channels with one output per channel: - normal mode 2. PWM channels with two outputs per channel: - normal mode -

[PATCH v3 04/10] pwm: pxa: populate PWM mode in of_xlate function

2018-02-22 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-pxa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index 4143a46684d2..7a035716e054

[PATCH v3 02/10] pwm: clps711x: populate PWM mode in of_xlate function

2018-02-22 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-clps711x.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-clps711x.c

[PATCH v3 08/10] pwm: add push-pull mode support

2018-02-22 Thread Claudiu Beznea
Add push-pull mode support. In push-pull mode the channels' outputs have same polarities and the edges are complementary delayed for one period. Signed-off-by: Claudiu Beznea --- include/linux/pwm.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-22 Thread Claudiu Beznea
Add PWM mode to pwm_config() function. The drivers which uses pwm_config() were adapted to this change. Signed-off-by: Claudiu Beznea --- arch/arm/mach-s3c24xx/mach-rx1950.c | 11 +-- drivers/bus/ts-nbus.c| 2 +- drivers/clk/clk-pwm.c

[PATCH v3 07/10] pwm: atmel: add pwm capabilities

2018-02-22 Thread Claudiu Beznea
Add pwm capabilities for Atmel/Microchip PWM controllers. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 80 - 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c

Re: [PATCH v3 06/10] pwm: add PWM modes

2018-02-22 Thread Claudiu Beznea
On 22.02.2018 19:28, Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 2:01 PM, Claudiu Beznea > wrote: >> Add PWM normal and complementary modes. > >> +- PWM_DTMODE_COMPLEMENTARY: PWM complementary working mode (for PWM >> +channels two outputs); if not specified,

Re: [RFC PATCH] drivers/peci: peci_match_id() can be static

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 11:01 PM, kbuild test robot wrote: Fixes: 99f5d2b99ecd ("drivers/peci: Add support for PECI bus driver core") Signed-off-by: Fengguang Wu --- peci-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/peci/peci-core.c

Re: [PATCH v3 06/10] pwm: add PWM modes

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 2:01 PM, Claudiu Beznea wrote: > Add PWM normal and complementary modes. > +- PWM_DTMODE_COMPLEMENTARY: PWM complementary working mode (for PWM > +channels two outputs); if not specified, the default for PWM channel will > +be used What DT

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 10:54 PM, Greg KH wrote: On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework.