[GIT PULL] Immutable branch between MFD and HWMON due for the v4.18 merge window

2018-04-16 Thread Lee Jones
Sorry for the delay. Things are pretty hectic at the moment. The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-hwmo

[PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Ahsan Hussain
Upstream commit 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") makes ina2xx_set_shunt() call mutex_lock on an un-initialized mutex. Initialize it prior so we don't get a NULL pointer dereference error Signed-off-by: Ahsan Hussain --- drivers/hwmon/ina2xx.c | 4 ++-- 1 file

Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Ahsan Hussain
On 04/16/2018 10:28 PM, Guenter Roeck wrote: > On Mon, Apr 16, 2018 at 10:08:19PM +0500, Ahsan Hussain wrote: >> >> Upstream commit >> >> 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") >> > This doesn't have to be on separate lines; as written, it just causes > confusion. > W

Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Guenter Roeck
On Mon, Apr 16, 2018 at 10:48:03PM +0500, Ahsan Hussain wrote: > > > On 04/16/2018 10:28 PM, Guenter Roeck wrote: > > On Mon, Apr 16, 2018 at 10:08:19PM +0500, Ahsan Hussain wrote: > >> > >> Upstream commit > >> > >> 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") > >> > > This

[PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread ahsan_hussain
From: Ahsan Hussain Upstream commit 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed"), makes ina2xx_set_shunt() call mutex_lock on an un-initialized mutex. Initialize it prior so we don't get a NULL pointer dereference error. Fixes: 8d008c0c ("hwmon: (ina2xx) Make calibration re

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: > This commit adds documents of generic PECI bus, adapter and client drivers. "dt-bindings: ..." for the subject prefix please. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Ve

Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Guenter Roeck
On Mon, Apr 16, 2018 at 10:08:19PM +0500, Ahsan Hussain wrote: > > Upstream commit > > 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") > This doesn't have to be on separate lines; as written, it just causes confusion. > makes ina2xx_set_shunt() call mutex_lock on an un-initia

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document of PECI adapter driver for Aspeed > AST24xx/25xx SoCs. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Alan Cox > Cc

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: > This commit adds dt-bindings documents for PECI cputemp and dimmtemp client > drivers. "dt-bindings: hwmon: ..." for the subject. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by

Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Guenter Roeck
On Mon, Apr 16, 2018 at 10:53:23PM +0500, ahsan_huss...@mentor.com wrote: > From: Ahsan Hussain > > Upstream commit 8d008c0c ("hwmon: (ina2xx) Make calibration register > value fixed"), makes ina2xx_set_shunt() call mutex_lock on an > un-initialized mutex. Initialize it prior so we don't get a NU

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-16 Thread Jae Hyun Yoo
Hi Rob, Thanks for sharing your time. Please see my answers inline. On 4/16/2018 10:59 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: This commit adds documents of generic PECI bus, adapter and client drivers. "dt-bindings: ..." for the subject prefix pl

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-16 Thread Jae Hyun Yoo
On 4/16/2018 11:10 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vern

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-16 Thread Jae Hyun Yoo
On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. "dt-bindings: hwmon: ..." for the subject. I'll change the subject. Signed-off-by: Jae Hyun Yoo Re

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-16 Thread Jae Hyun Yoo
On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. "dt-bindings: hwmon: ..." for the subject. I'll change the