Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Marcel Bocu
On 22/07/2019 21:11, Vicki Pfau wrote: > I'm getting similar variance. Compiling Linux seems to spike the temperature > above 70, even with a new CPU cooler, so I'm wondering if there might be an > offset I'm missing. It may just be the fan being too slow (going to be > reconfiguring the BIOS

Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote: > Added new DT binding document for Infineon PXE1610 devices. > > Signed-off-by: Vijay Khemka > --- > .../devicetree/bindings/hwmon/pxe1610.txt | 15 +++ > 1 file changed, 15 insertions(+) > create mode 100644

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 07:46:58PM +0200, Björn Gerhart wrote: > Thanks for the review Guenter, I checked your proposals, and here I comes an > update of the patch. > > Changes: > - simplified differences in register addresses > - fixed fan enablements > - simplified case statement > >

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Guenter Roeck
On Tue, Jul 23, 2019 at 12:09:16AM +0300, Marcel Bocu wrote: > On 22/07/2019 21:11, Vicki Pfau wrote: > > I'm getting similar variance. Compiling Linux seems to spike the > > temperature above 70, even with a new CPU cooler, so I'm wondering if there > > might be an offset I'm missing. It may

Re: [PATCH v2 2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs

2019-07-22 Thread Marcel Bocu
On 22/07/2019 21:23, Guenter Roeck wrote: > On Mon, Jul 22, 2019 at 08:46:53PM +0300, Marcel Bocu wrote: >> It would seem like model 70h is behaving in the same way as model 30h, >> so let's just add the new F3 PCI ID to the list of compatible devices. >> >> Unlike previous Ryzen/Threadripper,

Re: [PATCH] hwmon: Remove ads1015 driver

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 04:39:44PM -0600, Rob Herring wrote: > On Mon, Jul 01, 2019 at 11:12:38AM -0700, Guenter Roeck wrote: > > A driver for ADS1015 with more functionality is available in the iio > > subsystem. > > > > Remove the hwmon driver as duplicate. If the chip is used for hardware > >

Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices

2019-07-22 Thread Andrew Jeffery
Hi Vijay, A few nitpicks. On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote: > Addes Typo: Adds > Voltage Unnecessary capitalisation. > regulators Infineon pxe1610 devices to Facebook > tiogapass platform. > > Signed-off-by: Vijay Khemka > --- > .../dts/aspeed-bmc-facebook-tiogapass.dts

Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610

2019-07-22 Thread Vijay Khemka
On 7/22/19, 1:06 PM, "Guenter Roeck" wrote: On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote: > Added new DT binding document for Infineon PXE1610 devices. > > Signed-off-by: Vijay Khemka > --- > .../devicetree/bindings/hwmon/pxe1610.txt | 15

Re: [PATCH] hwmon: Remove ads1015 driver

2019-07-22 Thread Rob Herring
On Mon, Jul 01, 2019 at 11:12:38AM -0700, Guenter Roeck wrote: > A driver for ADS1015 with more functionality is available in the iio > subsystem. > > Remove the hwmon driver as duplicate. If the chip is used for hardware > monitoring, the iio->hwmon bridge should be used. > > Cc: Dirk Eibach >

Re: [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices

2019-07-22 Thread Vijay Khemka
On 7/22/19, 5:12 PM, "Andrew Jeffery" wrote: Hi Vijay, A few nitpicks. On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote: > Addes Typo: Adds Ack > Voltage Unnecessary capitalisation. Ack > regulators Infineon pxe1610 devices to

Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610

2019-07-22 Thread Guenter Roeck
On 7/22/19 5:12 PM, Vijay Khemka wrote: On 7/22/19, 1:06 PM, "Guenter Roeck" wrote: On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote: > Added new DT binding document for Infineon PXE1610 devices. > > Signed-off-by: Vijay Khemka > --- >

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Thomas Gleixner
On Fri, 19 Jul 2019, Guenter Roeck wrote: > > We could merge his patches (if he contacted the x86 crew), make a v2 of > > mine (71h -> 70h, add his Signed-off-by?) and merge, or some other option? > > > Either case, we'll need feedback from x86 maintainers. They are not exactly > happy if anyone

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Borislav Petkov
On Mon, Jul 22, 2019 at 10:59:32AM +0200, Thomas Gleixner wrote: > On Fri, 19 Jul 2019, Guenter Roeck wrote: > > > We could merge his patches (if he contacted the x86 crew), make a v2 of > > > mine (71h -> 70h, add his Signed-off-by?) and merge, or some other option? > > > > > Either case, we'll

[PATCH] drivers/hwmon/acpi_power_meter.c: Change log level

2019-07-22 Thread Shenran Wang
>From ce991220c17873821bd1e2bd011686201b3daaff Mon Sep 17 00:00:00 2001 From: Wang Shenran Date: Mon, 22 Jul 2019 14:38:10 +0300 Subject: [PATCH] drivers/hwmon/acpi_power_meter.c: Change log level At boot time, the acpi_power_meter driver logs the following error level message: "Ignoring unsafe

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Woods, Brian
On Mon, Jul 22, 2019 at 11:12:45AM +0200, Borislav Petkov wrote: > On Mon, Jul 22, 2019 at 10:59:32AM +0200, Thomas Gleixner wrote: > > On Fri, 19 Jul 2019, Guenter Roeck wrote: > > > > We could merge his patches (if he contacted the x86 crew), make a v2 of > > > > mine (71h -> 70h, add his

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 04:04:24PM +, Woods, Brian wrote: > On Mon, Jul 22, 2019 at 11:12:45AM +0200, Borislav Petkov wrote: > > On Mon, Jul 22, 2019 at 10:59:32AM +0200, Thomas Gleixner wrote: > > > On Fri, 19 Jul 2019, Guenter Roeck wrote: > > > > > We could merge his patches (if he

[PATCH 0/3] hwmon: convert subsystem to i2c_new_dummy_device()

2019-07-22 Thread Wolfram Sang
This series is part of a tree-wide movement to replace the I2C API call 'i2c_new_dummy' which returns NULL with its new counterpart returning an ERRPTR. The series was generated with coccinelle (audited afterwards, of course) and build tested by me and by buildbot. No tests on HW have been

[PATCH 1/3] hwmon: asb100: convert to i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Generated with coccinelle. Build tested by me and buildbot. Not tested on HW. drivers/hwmon/asb100.c | 12 ++-- 1 file changed, 6 insertions(+),

[PATCH 3/3] hwmon: w83781d: convert to i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Generated with coccinelle. Build tested by me and buildbot. Not tested on HW. drivers/hwmon/w83781d.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/3] hwmon: smm665: convert to i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Generated with coccinelle. Build tested by me and buildbot. Not tested on HW. drivers/hwmon/smm665.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Woods, Brian
On Mon, Jul 22, 2019 at 09:51:05AM -0700, Guenter Roeck wrote: > > With 3900X, and the series applied, I get: > > k10temp-pci-00c3 > Adapter: PCI adapter > Tdie: +45.1°C (high = +70.0°C) > Tctl: +45.1°C > > which looks about right. > > Interesting, though. I thought there

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

2019-07-22 Thread Björn Gerhart
Thanks for the review Guenter, I checked your proposals, and here I comes an update of the patch. Changes: - simplified differences in register addresses - fixed fan enablements - simplified case statement Signed-off-by: Bjoern Gerhart --- diff -Naur a/drivers/hwmon/nct6775.c

[PATCH v2 2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs

2019-07-22 Thread Marcel Bocu
It would seem like model 70h is behaving in the same way as model 30h, so let's just add the new F3 PCI ID to the list of compatible devices. Unlike previous Ryzen/Threadripper, Ryzen gen 3 processors do not need temperature offsets anymore. This has been reported in the press and verified on my

[PATCH v2 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 70h

2019-07-22 Thread Marcel Bocu
The AMD Ryzen gen 3 processors came with a different PCI IDs for the function 3 & 4 which are used to access the SMN interface. The root PCI address however remained at the same address as the model 30h. Adding the F3/F4 PCI IDs respectively to the misc and link ids appear to be sufficient for

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Marcel Bocu
On 22/07/2019 20:39, Woods, Brian wrote: > On Mon, Jul 22, 2019 at 09:51:05AM -0700, Guenter Roeck wrote: >> >> With 3900X, and the series applied, I get: >> >> k10temp-pci-00c3 >> Adapter: PCI adapter >> Tdie: +45.1°C (high = +70.0°C) >> Tctl: +45.1°C >> >> which looks about

Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h

2019-07-22 Thread Vicki Pfau
I'm getting similar variance. Compiling Linux seems to spike the temperature above 70, even with a new CPU cooler, so I'm wondering if there might be an offset I'm missing. It may just be the fan being too slow (going to be reconfiguring the BIOS settings today). The reason I haven't replied

Re: [PATCH v2 2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 08:46:53PM +0300, Marcel Bocu wrote: > It would seem like model 70h is behaving in the same way as model 30h, > so let's just add the new F3 PCI ID to the list of compatible devices. > > Unlike previous Ryzen/Threadripper, Ryzen gen 3 processors do not need > temperature

Re: [PATCH] drivers/hwmon/acpi_power_meter.c: Change log level

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 05:50:34PM +0300, Shenran Wang wrote: > From ce991220c17873821bd1e2bd011686201b3daaff Mon Sep 17 00:00:00 2001 > From: Wang Shenran > Date: Mon, 22 Jul 2019 14:38:10 +0300 > Subject: [PATCH] drivers/hwmon/acpi_power_meter.c: Change log level > > At boot time, the

Re: [PATCH 1/3] hwmon: asb100: convert to i2c_new_dummy_device

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 07:26:08PM +0200, Wolfram Sang wrote: > Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an > ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Applied to hwmon-next. Thanks, Guenter > --- > > Generated with coccinelle. Build

Re: [PATCH 2/3] hwmon: smm665: convert to i2c_new_dummy_device

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 07:26:09PM +0200, Wolfram Sang wrote: > Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an > ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Applied to hwmon-next. Thanks, Guenter > --- > > Generated with coccinelle. Build

Re: [PATCH 3/3] hwmon: w83781d: convert to i2c_new_dummy_device

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 07:26:10PM +0200, Wolfram Sang wrote: > Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an > ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Applied to hwmon-next. Thanks, Guenter > --- > > Generated with coccinelle. Build

Re: [PATCH v2 1/1] hwmon: (adt7475) Convert to use hwmon_device_register_with_groups()

2019-07-22 Thread Guenter Roeck
On Mon, Jul 22, 2019 at 10:55:30AM +1200, Grant McEwan wrote: > hwmon_device_register() is a deprecated function and produces a warning. > > Converting the driver to use the hwmon_device_register_with_groups() > instead. > > Signed-off-by: Grant McEwan Applied to hwmon-next. Thanks, Guenter