Re: [PATCH v2] hwmon: (applesmc) fix UB and udelay overflow

2019-10-02 Thread Nick Desaulniers
On Mon, Sep 30, 2019 at 5:01 PM Guenter Roeck wrote: > > Again, I fail to understand why waiting for a multiple of 20 seconds > under any circumstances would make any sense. Maybe the idea was > to divide us by 1000 before entering the second loop ? Yes, that's very clearly a mistake of mine. >

[PATCH] hwmon: applesmc: switch to using input device polling mode

2019-10-02 Thread Dmitry Torokhov
Now that instances of input_dev support polling mode natively, we no longer need to create input_polled_dev instance. Signed-off-by: Dmitry Torokhov --- drivers/hwmon/Kconfig| 1 - drivers/hwmon/applesmc.c | 38 ++ 2 files changed, 18 insertions(+), 21

Re: [PATCH] hwmon: applesmc: switch to using input device polling mode

2019-10-02 Thread kbuild test robot
Hi Dmitry, I love your patch! Yet something to improve: [auto build test ERROR on hwmon/hwmon-next] [cannot apply to v5.4-rc1 next-20191002] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH] hwmon: applesmc: switch to using input device polling mode

2019-10-02 Thread Guenter Roeck
On Wed, Oct 02, 2019 at 02:43:45PM -0700, Dmitry Torokhov wrote: > Now that instances of input_dev support polling mode natively, > we no longer need to create input_polled_dev instance. > > Signed-off-by: Dmitry Torokhov Applied to hwmon-next. I don't know what 0-day is complaining about; the

Re: [PATCH v2] hwmon: (applesmc) fix UB and udelay overflow

2019-10-02 Thread Guenter Roeck
On 10/2/19 2:43 PM, Nick Desaulniers wrote: On Mon, Sep 30, 2019 at 5:01 PM Guenter Roeck wrote: Again, I fail to understand why waiting for a multiple of 20 seconds under any circumstances would make any sense. Maybe the idea was to divide us by 1000 before entering the second loop ? Yes,