Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-08 Thread Laxman Dewangan
On Wednesday 08 June 2016 08:34 PM, Andrew F. Davis wrote: On 06/07/2016 05:30 PM, Guenter Roeck wrote: On Fri, Jun 03, 2016 at 10:17:55AM -0500, Andrew F. Davis wrote: On 06/03/2016 09:14 AM, Laxman Dewangan wrote: On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: On 06/03/2016 03:06

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 03:36 PM, Jonathan Cameron wrote: On 01/06/16 13:34, Laxman Dewangan wrote: Add support for INA3221 SW driver via IIO ADC interface. The device is register as iio-device and provides interface for voltage/current and power monitor. Also provide interface for setting

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: On 03/06/16 11:06, Jonathan Cameron wrote: Code looks good, bu these more fundamental bits need sorting. Another minor point - why do the power calculations in driver? no hardware support for it, so why not just leave it to userspace?

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 05:34 PM, Jonathan Cameron wrote: On 03/06/16 12:31, Laxman Dewangan wrote: On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: On 03/06/16 11:06, Jonathan Cameron wrote: Code looks good, bu these more fundamental bits need sorting. Another minor point - why do

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 05:39 PM, Jonathan Cameron wrote: On 03/06/16 12:26, Laxman Dewangan wrote: On Friday 03 June 2016 03:36 PM, Jonathan Cameron wrote: I thought that all ADC or monitors are going to be part of IIO device framework. I saw the ina2xx which is same (single channel) which

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-07 Thread Laxman Dewangan
On Wednesday 07 March 2018 07:50 PM, Guenter Roeck wrote: On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: While I am not opposed to ABI changes, the merits of those would need to be discussed on the mailing list. But replacing "fan1_input" with "rpm" is not an acceptable ABI change,

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-08 Thread Laxman Dewangan
On Thursday 08 March 2018 08:01 PM, Guenter Roeck wrote: On 03/07/2018 10:06 PM, Laxman Dewangan wrote: The RPM is measured speed via PWM signal capture which is output from fan. So should we have the fan[1..n]_output_rpm? No. I hear you clearly that you for some reason dislike fan[1