Re: [PATCHv4 1/4] mfd: da9052: fix manual ADC read after timed out read

2017-07-17 Thread Lee Jones
/* Channel gets activated on enabling the Conversion bit */ > mux_sel = chan_mux[channel] | DA9052_ADC_MAN_MAN_CONV; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCHv4 3/4] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-17 Thread Lee Jones
regulator, which provides the reference > + voltage for the TSIREF pin. Must be provided when the > + touchscreen pins are used for ADC purposes. > + DT Ack please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open

Re: [PATCHv5 2/6] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-17 Thread Lee Jones
dle to the regulator, which provides the reference > + voltage for the TSIREF pin. Must be provided when the > + touchscreen pins are used for ADC purposes. > + > Sub-nodes: > - regulators : Contain the regulator nodes. The DA9052/5

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-17 Thread Lee Jones
| 11 ++- > 2 files changed, 16 insertions(+), 1 deletion(-) Do other patches in this set depend on this change? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-17 Thread Lee Jones
On Mon, 17 Jul 2017, Lee Jones wrote: > On Mon, 03 Jul 2017, Sebastian Reichel wrote: > > > Add register details an channels definition for using the TSI > > registers in the hwmon driver. > > > > Signed-off-by: Sebastian Reichel > > --- > &g

Re: [PATCHv5 4/6] mfd: da9052: make touchscreen registration optional

2017-07-17 Thread Lee Jones
l da9052_tsi_subdev_info[] = { > + { > + .name = "da9052-tsi", > + }, > +}; I normally prefer these one a single line. Once fixed: For my own reference: Acked-for-MFD-by: Lee Jones > const struct regmap_config da9052_regmap

Re: [PATCHv5 3/6] mfd: da9052: add register details for TSI

2017-07-18 Thread Lee Jones
On Mon, 17 Jul 2017, Sebastian Reichel wrote: > Hi, > > On Mon, Jul 17, 2017 at 03:32:45PM +0100, Lee Jones wrote: > > On Mon, 03 Jul 2017, Sebastian Reichel wrote: > > > > > Add register details an channels definition for using the TSI > > > registers i

Re: [PATCHv6 1/4] mfd: da9052: add register details for TSI

2017-08-21 Thread Lee Jones
| 11 ++- > 2 files changed, 16 insertions(+), 1 deletion(-) For my own reference: Acked-for-MFD-by: Lee Jones Please add all the Acks you have obtained and [RESEND] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Li

Re: [PATCHv6 2/4] mfd: da9052: make touchscreen registration optional

2017-08-21 Thread Lee Jones
; drivers/mfd/da9052-core.c | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Faceboo

Re: [RESEND] [PATCHv6 1/4] mfd: da9052: add register details for TSI

2017-08-22 Thread Lee Jones
On Mon, 21 Aug 2017, Sebastian Reichel wrote: > Add register details an channels definition for using the TSI > registers in the hwmon driver. > > Acked-for-MFD-by: Lee Jones > Signed-off-by: Sebastian Reichel > --- > include/linux/mfd/da9052/da9052.h | 6 ++ >

Re: [RESEND] [PATCHv6 3/4] hwmon: da9052: replace S_IRUGO with 0444

2017-08-22 Thread Lee Jones
ivers/hwmon/da9052-hwmon.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the

Re: [RESEND] [PATCHv6 2/4] mfd: da9052: make touchscreen registration optional

2017-08-22 Thread Lee Jones
On Mon, 21 Aug 2017, Sebastian Reichel wrote: > If the touchscreen pins are used as general purpose analogue > input, the touchscreen driver should not be used. The pins > will be handled by the existing hwmon driver instead. > > Acked-for-MFD-by: Lee Jones > Signed-off-by:

Re: [RESEND] [PATCHv6 4/4] hwmon: da9052: add support for TSI channel

2017-08-22 Thread Lee Jones
--- > drivers/hwmon/da9052-hwmon.c | 249 > ++- > 1 file changed, 245 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: F

[GIT PULL] Immutable branch between MFD and HWMON due for the v4.14 merge window

2017-08-22 Thread Lee Jones
+++--- drivers/mfd/da9052-core.c | 26 +++- include/linux/mfd/da9052/da9052.h | 6 + include/linux/mfd/da9052/reg.h| 11 +- 4 files changed, 302 insertions(+), 26 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [GIT PULL] Immutable branch between MFD and HWMON due for the v4.14 merge window

2017-09-04 Thread Lee Jones
;t exist either. > > > > The immutable branch looks ok for me: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=ib-mfd-hwmon-v4.14 > > > > Hmm, yes, I must be blind. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Li

Re: [PATCH v2 2/4] mfd: add Gateworks System Controller core driver

2018-03-12 Thread Lee Jones
C 0x68 > + > +/* Register offsets */ > +#define GSC_CTRL_0 0x00 > +#define GSC_CTRL_1 0x01 > +#define GSC_TIME 0x02 > +#define GSC_TIME_ADD 0x06 > +#define GSC_IRQ_STATUS 0x0A > +#define GSC_IRQ_ENABLE 0x0B > +#define GSC_FW_CRC 0x0C > +#defi

Re: [PATCH v3] hwmon: MC13783: add uid and die temperature sensor inputs

2018-03-28 Thread Lee Jones
d to in16_input > > - style fixes > > --- > > drivers/hwmon/mc13783-adc.c | 60 > > + > > drivers/mfd/mc13xxx-core.c | 15 +++++++- > > include/linux/mfd/mc13xxx.h | 2 ++ > > 3 files changed, 76 inser

Re: [PATCH v3] hwmon: MC13783: add uid and die temperature sensor inputs

2018-03-28 Thread Lee Jones
2 ++ For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of

Re: [PATCH v3] hwmon: MC13783: add uid and die temperature sensor inputs

2018-03-28 Thread Lee Jones
On Wed, 28 Mar 2018, Guenter Roeck wrote: > On 03/28/2018 03:06 AM, Lee Jones wrote: > > On Tue, 27 Mar 2018, Guenter Roeck wrote: > > > > > On 03/27/2018 07:19 AM, Andrey Gusakov wrote: > > > > The uid and die temperature can be read out on the ADIN7 usin

[GIT PULL] Immutable branch between MFD and HWMON due for the v4.18 merge window

2018-04-16 Thread Lee Jones
/linux/mfd/mc13xxx.h | 2 ++ 3 files changed, 76 insertions(+), 1 deletion(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" i

Re: [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-07-27 Thread Lee Jones
On Mon, 23 Jul 2018, Jae Hyun Yoo wrote: > This commit adds PECI client MFD driver. > > Signed-off-by: Jae Hyun Yoo > Cc: Lee Jones > Cc: Rob Herring > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery

Re: [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-07-31 Thread Lee Jones
On Mon, 30 Jul 2018, Jae Hyun Yoo wrote: > Hi Rob, > > On 7/30/2018 3:10 PM, Rob Herring wrote: > > On Fri, Jul 27, 2018 at 11:36 AM Jae Hyun Yoo > > wrote: > > > > > > Hi Lee, > > > > > > On 7/27/2018 1:26 AM, Lee Jon

Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-10-24 Thread Lee Jones
On Tue, 18 Sep 2018, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document for PECI client MFD. > > Cc: Lee Jones > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery

Re: [PATCH v8 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-10-24 Thread Lee Jones
On Tue, 18 Sep 2018, Jae Hyun Yoo wrote: > This commit adds PECI client MFD driver. > > Cc: Lee Jones > Cc: Randy Dunlap > Cc: Rob Herring > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery > Signed-off-by: J

Re: [PATCH v8 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-10-24 Thread Lee Jones
On Wed, 24 Oct 2018, Jae Hyun Yoo wrote: > On 10/24/2018 3:59 AM, Lee Jones wrote: > > On Tue, 18 Sep 2018, Jae Hyun Yoo wrote: > > > > > This commit adds PECI client MFD driver. > > > > > [...] > > > +bool peci_temp_need_update(struct t

Re: [PATCH v9 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-12-21 Thread Lee Jones
On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: > This commit adds PECI client MFD driver. > > Cc: Lee Jones > Cc: Randy Dunlap > Cc: Rob Herring > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery > Signed-off-by: J

Re: [PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-12-21 Thread Lee Jones
On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document for PECI client MFD. > > Cc: Lee Jones > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery

Re: [PATCH 1/8] dt-bindings: mfd: iqs62x: Add bindings

2019-10-23 Thread Lee Jones
allows > > automated parsing of the examples + bindings using them for > > correctness. > > > > I'll wait for Lee or Rob's cue, but I'm happy to move to yaml if it's time > to make the switch here. > > > One comment inline. I'm far from an exp

Re: [RFC] Addition of Altera Arria10 System Resource Chip

2016-03-30 Thread Lee Jones
A10-SR GPIO > [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor > [RFC 8/8] ARM: socfpga: dts: Add Devkit Arria10-SR HWMON -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To

Re: [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor

2016-03-30 Thread Lee Jones
> + .name = "altr_a10sr_hwmon", > + .of_compatible = "altr,a10sr-hwmon", > + }, > }; > > static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) This belongs in a patch of its own. -- Lee Jones Linaro STMicroelectronics Landing Tea

Re: [RFC 4/8] gpio: altera-a10sr: Add A10 System Resource Chip GPIO support.

2016-03-30 Thread Lee Jones
e. > include/linux/mfd/altera-a10sr.h | 22 ++ > 5 files changed, 193 insertions(+) > create mode 100644 drivers/gpio/gpio-altera-a10sr.c -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [RFC 2/8] MAINTAINERS: Addition of Altera Arria10 System Resource Chip

2016-03-30 Thread Lee Jones
er > +S: Maintained > +F: drivers/mfd/altera-a10sr.c > +F: include/linux/mfd/altera-a10sr.h > +F: drivers/gpio/gpio-altera-a10sr.c > +F: drivers/hwmon/altera-a10sr-hwmon.c Alphabetical makes more sense. > ALTERA TRIPLE SPEED ETHERNET DRIVER > M: Vince Bridgers &

Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings

2016-03-30 Thread Lee Jones
#gpio-cells = <2>; > + ngpios = <16>; > + }; > + > + a10sr_hwmon: a10sr_hwmon { Device type only please. > + compatible = "altr,a10sr-hwmon"; > + }; > + }; --

Re: [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip

2016-03-30 Thread Lee Jones
unsigned int reg_cnt, > + unsigned char *val) > +{ > + return regmap_bulk_read(a10sr->regmap, reg, val, reg_cnt); > +} > + > +static inline int altr_a10sr_group_write(struct altr_a10sr *a10sr, > +

Re: [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip

2016-03-30 Thread Lee Jones
Mr Brown, On Wed, 30 Mar 2016, Thor Thayer wrote: > On 03/30/2016 06:51 AM, Lee Jones wrote: > >On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: > > > >>From: Thor Thayer > >> > >>Add support for the Altera Arria10 Development Kit System Reso

Re: [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip

2016-03-31 Thread Lee Jones
On Wed, 30 Mar 2016, Mark Brown wrote: > On Wed, Mar 30, 2016 at 03:52:39PM +0100, Lee Jones wrote: > > On Wed, 30 Mar 2016, Thor Thayer wrote: > > > > The read register has a different address than the write register > > > which is handled in this function w

Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings

2016-04-01 Thread Lee Jones
On Thu, 31 Mar 2016, Thor Thayer wrote: > On 03/30/2016 06:35 AM, Lee Jones wrote: > >On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: > > > >>From: Thor Thayer [...] > >>+The A10SR consists of this varied group of sub-devices: > >>+

Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings

2016-04-18 Thread Lee Jones
On Fri, 15 Apr 2016, Thor Thayer wrote: > On 03/30/2016 06:35 AM, Lee Jones wrote: > >On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: > > > >>From: Thor Thayer > >> > >>The Altera Arria10 Devkit System Resource chip is a Multi-Function > >

Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings

2016-04-18 Thread Lee Jones
On Fri, 15 Apr 2016, Thor Thayer wrote: > On 03/30/2016 06:35 AM, Lee Jones wrote: > >On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: > > > >>From: Thor Thayer > >> > >>The Altera Arria10 Devkit System Resource chip is a Multi-Function > >

Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings

2016-04-19 Thread Lee Jones
On Mon, 18 Apr 2016, Thor Thayer wrote: > Hi Lee, > > On 04/18/2016 02:45 AM, Lee Jones wrote: > >On Fri, 15 Apr 2016, Thor Thayer wrote: > >>On 03/30/2016 06:35 AM, Lee Jones wrote: > >>>On Tue, 29 Mar 2016, ttha...@opensource.altera.com wrote: > >&g

Re: [PATCH 02/11] MAINTAINERS: Add Altera Arria10 System Resource Chip

2016-05-09 Thread Lee Jones
wn reference: Acked-by: Lee Jones > diff --git a/MAINTAINERS b/MAINTAINERS > index 724bb86..e5f2621 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -608,6 +608,14 @@ L: linux-g...@vger.kernel.org > S: Maintained > F: drivers/gpio/gpio-altera.c > > +AL

Re: [PATCH 09/11] mfd: altr_a10sr: Add Altera A10-SR power supply alarms

2016-05-09 Thread Lee Jones
; include/linux/mfd/altera-a10sr.h | 24 > 2 files changed, 28 insertions(+) For my own reference: Acked-by: Lee Jones > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c > index 2ff08e3..2b2a90c 100644 > --- a/drivers/mfd/altera-a10

Re: [PATCH 09/11] mfd: altr_a10sr: Add Altera A10-SR power supply alarms

2016-05-09 Thread Lee Jones
On Mon, 09 May 2016, Lee Jones wrote: > On Fri, 22 Apr 2016, ttha...@opensource.altera.com wrote: > > > From: Thor Thayer > > > > Add support for power supply alarms to the Altera Arria10 > > Development Kit System Resource chip. > > > > Signed-off

Re: [PATCH 03/11] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip

2016-05-09 Thread Lee Jones
> +#define ALTR_A10SR_PBDSW_IRQ_REG 0x06/* PB & DIP SW Flag Clear */ > +/* Pushbutton & DIP Switch Bit Definitions */ > +#define ALTR_A10SR_IN_VALID_RANGE_LO 8 > +#define ALTR_A10SR_IN_VALID_RANGE_HI 15 > + > +#define ALTR_A10SR_PWR_GOOD1_REG 0x08

Re: [PATCH v2 3/4] mfd: add support for Allwinner SoCs ADC

2016-07-19 Thread Lee Jones
at least say *why* you don't like it? How else would it get probed? > I don't have any better suggestions though.. > > + }, > > +}; [...] > > + if (ret) { > > + dev_err(&pdev->dev, "failed to add MFD devices: %d\n", ret); >

Re: [PATCH v2 3/4] mfd: add support for Allwinner SoCs ADC

2016-07-21 Thread Lee Jones
On Wed, 20 Jul 2016, Jonathan Cameron wrote: > On 19/07/16 08:31, Lee Jones wrote: > > On Mon, 18 Jul 2016, Jonathan Cameron wrote: > > > >> On 15/07/16 10:59, Quentin Schulz wrote: > >>> The Allwinner SoCs all have an ADC that can also act as a touchscreen &

Re: [PATCH v2 3/4] mfd: add support for Allwinner SoCs ADC

2016-07-22 Thread Lee Jones
On Thu, 21 Jul 2016, Maxime Ripard wrote: > 1;4205;0c > On Thu, Jul 21, 2016 at 01:12:53PM +0100, Lee Jones wrote: > > On Wed, 20 Jul 2016, Jonathan Cameron wrote: > > > > > On 19/07/16 08:31, Lee Jones wrote: > > > > On Mon, 18 Jul 2016, Jonathan Cameron

Re: [PATCH v3 3/4] mfd: mfd-core: reattach mfd of_node to cells without of_compatible

2016-08-09 Thread Lee Jones
break; > + } > } > + } else { > + pdev->dev.of_node = parent->of_node; > } > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source s

Re: [PATCH v3 3/4] mfd: mfd-core: reattach mfd of_node to cells without of_compatible

2016-08-31 Thread Lee Jones
On Wed, 24 Aug 2016, Maxime Ripard wrote: > Hi Lee, > > On Tue, Aug 09, 2016 at 02:48:47PM +0100, Lee Jones wrote: > > On Tue, 26 Jul 2016, Quentin Schulz wrote: > > > > > When an MFD cell has an of_compatible (meaning it is present in the Device > > > Tr

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
_XY_CHANGE BIT(13) > +#define SUN4I_GPADC_INT_FIFOC_TP_FIFO_TRIG_LEVEL(x) ((GENMASK(4, 0) & (x)) > << 8) > +#define SUN4I_GPADC_INT_FIFOC_TP_DATA_DRQ_EN BIT(7) > +#define SUN4I_GPADC_INT_FIFOC_TP_FIFO_FLUSH BIT(4) > +#define SUN4I_GPADC_INT_FIF

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
On Mon, 12 Sep 2016, Quentin Schulz wrote: > On 12/09/2016 11:18, Lee Jones wrote: > > On Thu, 08 Sep 2016, Quentin Schulz wrote: > > > [...] [...] > >> +++ b/drivers/mfd/sun4i-gpadc-mfd.c [...] > >> +static struct mfd_cell sun4i_gpadc_mfd_cells[]

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
On Mon, 12 Sep 2016, Maxime Ripard wrote: > On Mon, Sep 12, 2016 at 10:59:23AM +0100, Lee Jones wrote: > > > >> +static const struct of_device_id sun4i_gpadc_mfd_of_match[] = { > > > >> + { > > > >> + .compatible = "a

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
On Mon, 12 Sep 2016, Quentin Schulz wrote: > On 12/09/2016 12:49, Lee Jones wrote: > > On Mon, 12 Sep 2016, Maxime Ripard wrote: > > > >> On Mon, Sep 12, 2016 at 10:59:23AM +0100, Lee Jones wrote: > >>>>>> +static const

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
On Mon, 12 Sep 2016, Quentin Schulz wrote: > On 12/09/2016 11:59, Lee Jones wrote: > > On Mon, 12 Sep 2016, Quentin Schulz wrote: > > > >> On 12/09/2016 11:18, Lee Jones wrote: > >>> On Thu, 08 Sep 2016, Quentin Schulz wrote: > >>> > >>

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-12 Thread Lee Jones
On Mon, 12 Sep 2016, Maxime Ripard wrote: > On Mon, Sep 12, 2016 at 02:56:55PM +0100, Lee Jones wrote: > > > >>> Then use .data = and set up a switch() in .probe(). > > > >> > > > >> Uh? Why? It just adds a non-standard indirection, while using

Re: [PATCH v5 2/3] mfd: add support for Allwinner SoCs ADC

2016-09-13 Thread Lee Jones
On Tue, 13 Sep 2016, Quentin Schulz wrote: > On 12/09/2016 15:56, Lee Jones wrote: > > On Mon, 12 Sep 2016, Quentin Schulz wrote: > >> On 12/09/2016 11:59, Lee Jones wrote: > >>> On Mon, 12 Sep 2016, Quentin Schulz wrote: > >>> > >>>> On

Re: [PATCH v6 1/2] mfd: add support for Allwinner SoCs ADC

2016-10-26 Thread Lee Jones
t; +#define SUN4I_GPADC_INT_FIFOC_TP_DATA_IRQ_EN BIT(16) > +#define SUN4I_GPADC_INT_FIFOC_TP_DATA_XY_CHANGE BIT(13) > +#define SUN4I_GPADC_INT_FIFOC_TP_FIFO_TRIG_LEVEL(x) ((GENMASK(4, 0) & (x)) > << 8) > +#define SUN4I_GPADC_INT_FIFOC_TP_DATA_DRQ_EN

Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver

2016-11-03 Thread Lee Jones
> 5 files changed, 1409 insertions(+) > create mode 100644 drivers/mfd/imanager-core.c > create mode 100644 include/linux/mfd/imanager-ec.h > create mode 100644 include/linux/mfd/imanager.h After a brief review, it is my belief that this looks like a platform driver, which should

Re: [PATCH 6/7] mfd/iio: move the AB8500 GPADC to IIO

2017-01-13 Thread Lee Jones
500-gpadc.c (76%) > delete mode 100644 include/linux/mfd/abx500/ab8500-gpadc.h Ack for it being moved out of MFD. Acked-by: Lee Jones > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 38bc319904c4..e524bdeb3e27 100644 > --- a/drivers/iio/adc/Kconfig > ++

Re: [PATCH 5/7] mfd: ab8500: augment DT bindings

2017-01-13 Thread Lee Jones
/mfd/ab8500.txt | 119 > +++ > 1 file changed, 119 insertions(+) Looks okay to me, but we should wait for Rob to take a look. For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/Documentation/devicetree/bindings/mfd/ab8500.txt > b/Documentation/devicetre