Re: [PATCH] hwmon: (sht21) Don't use clock stretching

2018-01-31 Thread Guenter Roeck
On Wed, Jan 31, 2018 at 03:39:23PM +0100, Danilo Bargen wrote: > Hello Guenter > > Thank you for your fast review! > > > The driver must now support I2C_FUNC_I2C which is a significant change in > > functionality > > since it will no longer work on SMBus-only adapters. > > You are right of

Re: [PATCH] hwmon: (sht21) Don't use clock stretching

2018-01-31 Thread Danilo Bargen
Hello Guenter Thank you for your fast review! > The driver must now support I2C_FUNC_I2C which is a significant change in > functionality > since it will no longer work on SMBus-only adapters. You are right of course, I wasn't aware of that. > You'll have to find a better > solution, one that

Re: [PATCH] hwmon: (sht21) Don't use clock stretching

2018-01-27 Thread Guenter Roeck
On 01/26/2018 03:37 PM, Danilo Bargen wrote: The current driver uses clock stretching (hold master) mode to retrieve the measurements. This blocks the bus and may cause problems on some systems like the BCM2835 (Raspberry Pi) that have buggy I2C hardware¹. ¹

[PATCH] hwmon: (sht21) Don't use clock stretching

2018-01-26 Thread Danilo Bargen
The current driver uses clock stretching (hold master) mode to retrieve the measurements. This blocks the bus and may cause problems on some systems like the BCM2835 (Raspberry Pi) that have buggy I2C hardware¹. ¹ http://www.advamation.com/knowhow/raspberrypi/rpi-i2c-bug.html Signed-off-by: