Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.
Hi, On Monday 07 August 2017 02:55 PM, Jean Delvare wrote: Hi Arvind, On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Confused by the subject. What is "wusbhc:"? Also please avoid trailing dot in mail subjects. Thanks for review, I will update. Signed-off-by: Arvind Yadav --- drivers/hwmon/adt7475.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c index 1baa213..9ef8499 100644 --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR, NULL }; -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; static int adt7475_detect(struct i2c_client *client, struct i2c_board_info *info) Looks good to me. Reviewed-by: Jean Delvare ~arvind -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.
Hi Arvind, On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. Confused by the subject. What is "wusbhc:"? Also please avoid trailing dot in mail subjects. > Signed-off-by: Arvind Yadav > --- > drivers/hwmon/adt7475.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c > index 1baa213..9ef8499 100644 > --- a/drivers/hwmon/adt7475.c > +++ b/drivers/hwmon/adt7475.c > @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, > S_IRUGO | S_IWUSR, > NULL > }; > > -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs > }; > -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; > -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; > -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > +static const struct attribute_group adt7475_attr_group = { .attrs = > adt7475_attrs }; > +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs > }; > +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs > }; > +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > > static int adt7475_detect(struct i2c_client *client, > struct i2c_board_info *info) Looks good to me. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html