Re: [PATCH 1/8] dt-bindings: mfd: iqs62x: Add bindings
On Tue, 22 Oct 2019, Jeff LaBundy wrote: > Hi Jonathan, > > On Tue, Oct 22, 2019 at 12:00:51PM +0100, Jonathan Cameron wrote: > > On Sun, 20 Oct 2019 23:11:16 -0500 > > Jeff LaBundy wrote: > > > > > This patch adds binding documentation for six-channel members of the > > > Azoteq ProxFusion family of sensor devices. > > > > > > Signed-off-by: Jeff LaBundy > > > > I'm not sure if Lee has made the switch for mfd entirely yet, but > > mostly new dt bindings need to be in yaml format as it allows > > automated parsing of the examples + bindings using them for > > correctness. > > > > I'll wait for Lee or Rob's cue, but I'm happy to move to yaml if it's time > to make the switch here. > > > One comment inline. I'm far from an expert on most of the stuff here > > so will leave it for others! It would make sense. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 1/8] dt-bindings: mfd: iqs62x: Add bindings
Hi Jonathan, On Tue, Oct 22, 2019 at 12:00:51PM +0100, Jonathan Cameron wrote: > On Sun, 20 Oct 2019 23:11:16 -0500 > Jeff LaBundy wrote: > > > This patch adds binding documentation for six-channel members of the > > Azoteq ProxFusion family of sensor devices. > > > > Signed-off-by: Jeff LaBundy > > I'm not sure if Lee has made the switch for mfd entirely yet, but > mostly new dt bindings need to be in yaml format as it allows > automated parsing of the examples + bindings using them for > correctness. > I'll wait for Lee or Rob's cue, but I'm happy to move to yaml if it's time to make the switch here. > One comment inline. I'm far from an expert on most of the stuff here > so will leave it for others! > > Jonathan > > > > --- > > Documentation/devicetree/bindings/mfd/iqs62x.txt | 242 > > +++ > > 1 file changed, 242 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/iqs62x.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.txt > > b/Documentation/devicetree/bindings/mfd/iqs62x.txt > > new file mode 100644 > > index 000..089f567 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/iqs62x.txt > > @@ -0,0 +1,242 @@ > > +Azoteq IQS620A/621/622/624/625 ProxFusion Sensor Family > > + > > +Required properties: > > + > > +- compatible : Must be equal to one of the following: > > + "azoteq,iqs620a" > > + "azoteq,iqs621" > > + "azoteq,iqs622" > > + "azoteq,iqs624" > > + "azoteq,iqs625" > > + > > +- reg : I2C slave address for the device. > > + > > +- interrupts : GPIO to which the device's active-low > > RDY > > + output is connected (see [0]). > > + > > +Optional properties: > > + > > +- linux,fw-file: Specifies the name of the calibration > > and > > + configuration file selected by the driver. > > + If this property is omitted, the filename > > + is selected based on the device name with > > + ".bin" as the extension (e.g. iqs620a.bin > > + for IQS620A). > > + > > +All devices accommodate a child node (e.g. "keys") that represents touch > > key > > +support. Required properties for the "keys" child node include: > > + > > +- compatible : Must be equal to one of the following: > > + "azoteq,iqs620a-keys" > > + "azoteq,iqs621-keys" > > + "azoteq,iqs622-keys" > > + "azoteq,iqs624-keys" > > + "azoteq,iqs625-keys" > > + > > +- linux,keycodes : Specifies an array of up to 16 numeric key- > > + codes corresponding to each available touch > > + or proximity event. An 'x' in the following > > + table indicates an event is supported for a > > + given device; specify 0 for unused events. > > + > > + > > > > + | # | Event | IQS620A | IQS621 | IQS622 | IQS624 | > > IQS625 | > > + > > > > + | 0 | CH0 Touch |x|x |x |x |x > > | > > + || Antenna 1 Touch* |x|||| > > | > > + > > > > + | 1 | CH0 Proximity |x|x |x |x |x > > | > > + || Antenna 1 Proximity* |x|||| > > | > > + > > > > + | 2 | CH1 Touch |x|x |x |x |x > > | > > + || Antenna 1 Deep Touch* |x|||| > > | > > + > > > > + | 3 | CH1 Proximity |x|x |x |x |x > > | > > + > > > > + | 4 | CH2 Touch |x|||| > > | > > + > > > > + | 5 | CH2 Proximity |x|||| > > | > > + || Antenna 2 Proximity* |x|||| > > | > > + > >
Re: [PATCH 1/8] dt-bindings: mfd: iqs62x: Add bindings
On Sun, 20 Oct 2019 23:11:16 -0500 Jeff LaBundy wrote: > This patch adds binding documentation for six-channel members of the > Azoteq ProxFusion family of sensor devices. > > Signed-off-by: Jeff LaBundy I'm not sure if Lee has made the switch for mfd entirely yet, but mostly new dt bindings need to be in yaml format as it allows automated parsing of the examples + bindings using them for correctness. One comment inline. I'm far from an expert on most of the stuff here so will leave it for others! Jonathan > --- > Documentation/devicetree/bindings/mfd/iqs62x.txt | 242 > +++ > 1 file changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/iqs62x.txt > > diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.txt > b/Documentation/devicetree/bindings/mfd/iqs62x.txt > new file mode 100644 > index 000..089f567 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/iqs62x.txt > @@ -0,0 +1,242 @@ > +Azoteq IQS620A/621/622/624/625 ProxFusion Sensor Family > + > +Required properties: > + > +- compatible : Must be equal to one of the following: > + "azoteq,iqs620a" > + "azoteq,iqs621" > + "azoteq,iqs622" > + "azoteq,iqs624" > + "azoteq,iqs625" > + > +- reg: I2C slave address for the device. > + > +- interrupts : GPIO to which the device's active-low RDY > + output is connected (see [0]). > + > +Optional properties: > + > +- linux,fw-file : Specifies the name of the calibration > and > + configuration file selected by the driver. > + If this property is omitted, the filename > + is selected based on the device name with > + ".bin" as the extension (e.g. iqs620a.bin > + for IQS620A). > + > +All devices accommodate a child node (e.g. "keys") that represents touch key > +support. Required properties for the "keys" child node include: > + > +- compatible : Must be equal to one of the following: > + "azoteq,iqs620a-keys" > + "azoteq,iqs621-keys" > + "azoteq,iqs622-keys" > + "azoteq,iqs624-keys" > + "azoteq,iqs625-keys" > + > +- linux,keycodes : Specifies an array of up to 16 numeric key- > + codes corresponding to each available touch > + or proximity event. An 'x' in the following > + table indicates an event is supported for a > + given device; specify 0 for unused events. > + > + > > + | # | Event | IQS620A | IQS621 | IQS622 | IQS624 | IQS625 > | > + > > + | 0 | CH0 Touch |x|x |x |x |x > | > + || Antenna 1 Touch* |x|||| > | > + > > + | 1 | CH0 Proximity |x|x |x |x |x > | > + || Antenna 1 Proximity* |x|||| > | > + > > + | 2 | CH1 Touch |x|x |x |x |x > | > + || Antenna 1 Deep Touch* |x|||| > | > + > > + | 3 | CH1 Proximity |x|x |x |x |x > | > + > > + | 4 | CH2 Touch |x|||| > | > + > > + | 5 | CH2 Proximity |x|||| > | > + || Antenna 2 Proximity* |x|||| > | > + > > + | 6 | Metal (+) Touch** |x|x ||| > | > + || Antenna 2 Deep Touch* |x|||| > | > + > > + | 7 | Metal (+) Proximity** |x|x ||| > | > + || Antenna 2 Touch* |x|
