Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-10-11 Thread Jean Delvare
Hi Guenter, On Mon, 10 Oct 2016 16:48:22 -0700, Guenter Roeck wrote: > On Fri, Oct 07, 2016 at 02:32:13PM +0200, Jean Delvare wrote: > > On Tue, 4 Oct 2016 12:37:13 -0700, Guenter Roeck wrote: > > > On Tue, Oct 04, 2016 at 10:45:59AM +0200, Jean Delvare wrote: > > > > May I ask if any other

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-10-10 Thread Guenter Roeck
On Fri, Oct 07, 2016 at 02:32:13PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Tue, 4 Oct 2016 12:37:13 -0700, Guenter Roeck wrote: > > On Tue, Oct 04, 2016 at 10:45:59AM +0200, Jean Delvare wrote: > > > I see this patch is upstream now, but I had started reviewing it and > > > maybe some of

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-10-07 Thread Jean Delvare
Hi Guenter, On Tue, 4 Oct 2016 12:37:13 -0700, Guenter Roeck wrote: > On Tue, Oct 04, 2016 at 10:45:59AM +0200, Jean Delvare wrote: > > I see this patch is upstream now, but I had started reviewing it and > > maybe some of my comments are still relevant. > > > As always, I appreciate the

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-10-04 Thread Guenter Roeck
Hi Jean, On Tue, Oct 04, 2016 at 10:45:59AM +0200, Jean Delvare wrote: > Hi Guenter, > > I see this patch is upstream now, but I had started reviewing it and > maybe some of my comments are still relevant. > As always, I appreciate the feedback. I'll be happy to submit follow-up patches to

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-10-04 Thread Jean Delvare
Hi Guenter, I see this patch is upstream now, but I had started reviewing it and maybe some of my comments are still relevant. It's not meant to be a complete review, which is why I had not sent it yet :-( Also I did not follow the first iterations of this patchset so my apologies if I raise

Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API

2016-08-12 Thread Guenter Roeck
On 08/12/2016 01:16 AM, Keerthy wrote: On Monday 25 July 2016 09:02 AM, Guenter Roeck wrote: Up to now, each hwmon driver has to implement its own sysfs attributes. This requires a lot of template code, and distracts from the driver's core function to read and write chip registers. To be able