Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-13 Thread SF Markus Elfring
>  1 file changed, 29 insertions(+), 31 deletions(-) > > So you are asking people to review 60 changed lines to save 2, A bit of object code reduction might become useful also in this case. > that alone should be the point where you stop yourself from > *even* sending this patch. I proposed ju

Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-13 Thread Hans de Goede
Hi, On 13-03-18 09:25, SF Markus Elfring wrote: Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. … goto-s going to a label calling another goto is completely unreadable. I got an other software development view. I really do not see

Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-13 Thread SF Markus Elfring
>> Adjust jump targets so that a bit of exception handling can be better >> reused at the end of this function. … > goto-s going to a label calling another goto is completely unreadable. I got an other software development view. > I really do not see any reason for the proposed changes, I sugge