Re: [PATCH v2 1/6] arm64/hyperv: Support DeviceTree

2024-05-15 Thread Krzysztof Kozlowski
On 15/05/2024 00:43, Roman Kisel wrote: > The Virtual Trust Level platforms rely on DeviceTree, and the > arm64/hyperv code supports ACPI only. Update the logic to > support DeviceTree on boot as well as ACPI. > > Signed-off-by: Roman Kisel > --- > arch/arm64/hyperv/mshyperv.c | 34 +

Re: [PATCH v2 5/6] drivers/hv/vmbus: Get the irq number from DeviceTree

2024-05-15 Thread Krzysztof Kozlowski
On 15/05/2024 00:43, Roman Kisel wrote: > The vmbus driver uses ACPI for interrupt assignment on > arm64 hence it won't function in the VTL mode where only > DeviceTree can be used. > > Update the vmbus driver to discover interrupt configuration > via DeviceTree. > > Signed-off-by: Roman Kisel >

Re: [PATCH v2 1/6] arm64/hyperv: Support DeviceTree

2024-05-19 Thread Krzysztof Kozlowski
On 15/05/2024 19:33, Roman Kisel wrote: >>> static bool hyperv_initialized; >>> @@ -27,6 +30,29 @@ int hv_get_hypervisor_version(union >>> hv_hypervisor_version_info *info) >>> return 0; >>> } >>> >>> +static bool hyperv_detect_fdt(void) >>> +{ >>> +#ifdef CONFIG_OF >>> + const unsign

Re: [PATCH v3 5/7] dt-bindings: bus: Add Hyper-V VMBus cache coherency and IRQs

2024-07-27 Thread Krzysztof Kozlowski
On 27/07/2024 00:59, Roman Kisel wrote: > Add dt-bindings for the Hyper-V VMBus DMA cache coherency > and interrupt specification. > You did not add any bindings. I don't understand this description. Anyway, not tested. Please use scripts/get_maintainers.pl to get a list of necessary people an

Re: [PATCH v3 6/7] Drivers: hv: vmbus: Get the IRQ number from DT

2024-07-27 Thread Krzysztof Kozlowski
On 27/07/2024 00:59, Roman Kisel wrote: > @@ -2338,6 +2372,21 @@ static int vmbus_device_add(struct platform_device > *pdev) > cur_res = &res->sibling; > } > > + /* > + * Hyper-V always assumes DMA cache coherency, and the DMA subsystem > + * might default to 'n

Re: [PATCH v3 6/7] Drivers: hv: vmbus: Get the IRQ number from DT

2024-07-27 Thread Krzysztof Kozlowski
On 27/07/2024 11:17, Arnd Bergmann wrote: > On Sat, Jul 27, 2024, at 10:56, Krzysztof Kozlowski wrote: >> On 27/07/2024 00:59, Roman Kisel wrote: >>> @@ -2338,6 +2372,21 @@ static int vmbus_device_add(struct platform_device >>> *pdev) >>>

Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

2024-08-06 Thread Krzysztof Kozlowski
On 07/08/2024 00:12, Yunhong Jiang wrote: > Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs. We do not have bindings for ACPI. I think in the past it was mentioned pretty clear - we do not care what ACPI has in the wild. > > Signed-off-by: Yunhong Jiang > --- > .../devi

Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

2024-08-08 Thread Krzysztof Kozlowski
On 07/08/2024 18:56, Yunhong Jiang wrote: > On Wed, Aug 07, 2024 at 07:57:43AM +0200, Krzysztof Kozlowski wrote: >> On 07/08/2024 00:12, Yunhong Jiang wrote: >>> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs. >> >> We do not have bindings fo

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2024-08-25 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 04:23:20PM -0700, Yunhong Jiang wrote: > Add the binding to use mailbox wakeup mechanism to bringup APs. > > Signed-off-by: Yunhong Jiang > --- > .../devicetree/bindings/x86/wakeup.yaml | 64 +++ > 1 file changed, 64 insertions(+) > create mode 1006

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2024-09-16 Thread Krzysztof Kozlowski
On 10/09/2024 08:13, Yunhong Jiang wrote: > On Tue, Aug 27, 2024 at 01:45:49PM -0700, Yunhong Jiang wrote: >> On Sun, Aug 25, 2024 at 09:10:01AM +0200, Krzysztof Kozlowski wrote: >>> On Fri, Aug 23, 2024 at 04:23:20PM -0700, Yunhong Jiang wrote: >>>> Add the binding t

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2024-09-20 Thread Krzysztof Kozlowski
On 19/09/2024 21:19, Yunhong Jiang wrote: > On Mon, Sep 16, 2024 at 10:56:38AM +0200, Krzysztof Kozlowski wrote: >> On 10/09/2024 08:13, Yunhong Jiang wrote: >>> On Tue, Aug 27, 2024 at 01:45:49PM -0700, Yunhong Jiang wrote: >>>> On Sun, Aug 25, 2024 at 09:10:01AM +0

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2024-09-20 Thread Krzysztof Kozlowski
On 20/09/2024 00:15, Yunhong Jiang wrote: >>> For your "validated by the tools", can you please share the tools you used to validate the schema? I used "make dt_binding_check" per the submitting-patches.rst but I think your comments is about another tool. >>> >>> See writi

Re: [PATCH hyperv-next v4 4/6] dt-bindings: microsoft,vmbus: Add GIC and DMA coherence to the example

2025-02-11 Thread Krzysztof Kozlowski
On Tue, Feb 11, 2025 at 05:43:19PM -0800, Roman Kisel wrote: > The existing example lacks the GIC interrupt controller property > making it not possible to boot on ARM64, and it lacks the DMA GIC controller is not relevant to this binding. > coherence property making the kernel do more work on ma

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2025-03-19 Thread Krzysztof Kozlowski
On 12/03/2025 06:51, Ricardo Neri wrote: > On Tue, Mar 11, 2025 at 11:01:28AM +0100, Krzysztof Kozlowski wrote: >> On 03/03/2025 23:21, Ricardo Neri wrote: >>> On Fri, Sep 20, 2024 at 01:15:41PM +0200, Krzysztof Kozlowski wrote: >>> >>> [...] >>>

Re: [PATCH hyperv-next v6 07/11] dt-bindings: microsoft,vmbus: Add interrupt and DMA coherence properties

2025-03-16 Thread Krzysztof Kozlowski
on: Interrupt used to report a message from the host. (and note that just like we do not use "This" in commit msg, there is really no benefit of using it in hardware descruption for simple statements) Regardless: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 04/13] dt-bindings: x86: Add CPU bindings for x86

2025-05-04 Thread Krzysztof Kozlowski
On Sat, May 03, 2025 at 12:15:06PM GMT, Ricardo Neri wrote: > Add bindings for CPUs in x86 architecture. Start by defining the `reg` and What for? > `enable-method` properties and their relationship to x86 APIC ID and the > available mechanisms to boot secondary CPUs. > > Start defining bindings

Re: [PATCH v3 06/13] dt-bindings: reserved-memory: Wakeup Mailbox for Intel processors

2025-05-04 Thread Krzysztof Kozlowski
On Sat, May 03, 2025 at 12:15:08PM GMT, Ricardo Neri wrote: > Add DeviceTree bindings for the wakeup mailbox used on Intel processors. > Start using b4, so your cover letter will have proper lore links to previous versions. > x86 platforms commonly boot secondary CPUs using an INIT assert, de-as

Re: [PATCH v3 04/13] dt-bindings: x86: Add CPU bindings for x86

2025-05-06 Thread Krzysztof Kozlowski
On Mon, May 05, 2025 at 09:52:35PM GMT, Ricardo Neri wrote: > On Sun, May 04, 2025 at 06:45:59PM +0200, Krzysztof Kozlowski wrote: > > On Sat, May 03, 2025 at 12:15:06PM GMT, Ricardo Neri wrote: > > > Add bindings for CPUs in x86 architecture. Start by defining the `reg` and

Re: [PATCH v3 06/13] dt-bindings: reserved-memory: Wakeup Mailbox for Intel processors

2025-05-06 Thread Krzysztof Kozlowski
On Mon, May 05, 2025 at 10:16:10PM GMT, Ricardo Neri wrote: > > If this is a device, then compatibles specific to devices. You do not > > get different rules than all other bindings... or this does not have to > > be binding at all. Why standard reserved-memory does not work for here? > > > > Why

Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence

2025-03-10 Thread Krzysztof Kozlowski
On 10/03/2025 18:05, Roman Kisel wrote: > > > On 3/10/2025 2:28 AM, Krzysztof Kozlowski wrote: >> On Fri, Mar 07, 2025 at 02:02:59PM -0800, Roman Kisel wrote: >>> To boot on ARM64, VMBus requires configuring interrupts. Missing >>> DMA coherence property is sub

Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence

2025-03-10 Thread Krzysztof Kozlowski
On Fri, Mar 07, 2025 at 02:02:59PM -0800, Roman Kisel wrote: > To boot on ARM64, VMBus requires configuring interrupts. Missing > DMA coherence property is sub-optimal as the VMBus transations are > cache-coherent. > > Add interrupts to be able to boot on ARM64. Add DMA coherence to > avoid doing

Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence

2025-03-10 Thread Krzysztof Kozlowski
On 10/03/2025 19:07, Roman Kisel wrote: > > It is modeled as a bus in the kernel: > https://www.kernel.org/doc/html/latest/virt/hyperv/vmbus.html > >> Please upstream bindings for the bus devices and extend the example here >> with these devices. > > The set of synthetic devices that reside on t

Re: [PATCH v2 2/9] dt-bindings: x86: Add a binding for x86 wakeup mailbox

2025-03-11 Thread Krzysztof Kozlowski
On 03/03/2025 23:21, Ricardo Neri wrote: > On Fri, Sep 20, 2024 at 01:15:41PM +0200, Krzysztof Kozlowski wrote: > > [...] > >> enable-method is part of CPUs, so you probably should match the CPUs... >> I am not sure, I don't have the big picture here. >> >

Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property

2025-06-20 Thread Krzysztof Kozlowski
On Thu, Jun 19, 2025 at 04:06:34PM GMT, Hardik Garg wrote: > Document the microsoft,message-connection-id property for VMBus DeviceTree > node. This property allows specifying the connection ID used for What is a connection ID and why it cannot be inferred from existing system API? > communicatio

Re: [PATCH v4 2/2] vmbus: retrieve connection-id from DeviceTree

2025-06-20 Thread Krzysztof Kozlowski
On Thu, Jun 19, 2025 at 04:06:35PM GMT, Hardik Garg wrote: > The connection-id determines which hypervisor communication channel the > guest should use to talk to the VMBus host. This patch adds support to > read this value from the DeviceTree where it exists as a property under > the vmbus node wi

Re: [PATCH v3] vmbus: retrieve connection-id from DeviceTree

2025-06-05 Thread Krzysztof Kozlowski
On 05/06/2025 08:09, Hardik Garg wrote: > The connection-id determines which hypervisor communication channel the > guest should use to talk to the VMBus host. This patch adds support to > read this value from the DeviceTree where it exists as a property under > the vmbus node with the compatible I

Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property

2025-07-16 Thread Krzysztof Kozlowski
On 16/07/2025 06:42, Hardik Garg wrote: > What is a connection ID and why it cannot be inferred from existing > system API? > >>> The connection-id determines which hypervisor communication channel the >>> guest should use to talk to the VMBus host. Reading from DeviceTree allows >>> plat

Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property

2025-07-14 Thread Krzysztof Kozlowski
On 14/07/2025 09:48, Hardik Garg wrote: > Thank you for your review, Krzysztof. I apologize for the delay in > my response. You got review after 8 hours. You respond after 3 weeks. > >>> What is a connection ID and why it cannot be inferred from existing >>> system API? > > The connection-id

Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property

2025-07-25 Thread Krzysztof Kozlowski
On 25/07/2025 00:12, Hardik Garg wrote: >> Then all guests can use the same value, 0, making this property redundant. > > No, they cannot use the same value. The protocol requires different > connection IDs for different communication paths. > For example, a guest communicating with a VTL0 contro

Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property

2025-07-22 Thread Krzysztof Kozlowski
On 23/07/2025 05:08, Hardik Garg wrote: >> Host is supposed to have multiple guests, so this feels like you are >> going to prepare for each guest different DTS with different connection >> ID. This feels like poor design. DTS is supposed to be relatively static >> configuration, not runtime choice