Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread zhangfei gao
Hi, Ben Thanks for your suggestion. On Thu, Feb 4, 2010 at 3:37 PM, Ben Dooks ben-li...@fluff.org wrote: On Thu, Feb 04, 2010 at 02:04:03PM +0800, zhangfei gao wrote: Hi, Jean We found type of i2c_msg.len is __u16, while parameter count in i2c_master_send is int. The mismatch will

Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread Jean Delvare
Hi Gao, I'm adding the linux-i2c list to Cc. On Thu, 4 Feb 2010 14:04:03 +0800, zhangfei gao wrote: We found type of i2c_msg.len is __u16, while parameter count in i2c_master_send is int. The mismatch will truncate count from int to u16. For example we downloading firmware which is more than

Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread zhangfei gao
On Thu, Feb 4, 2010 at 5:35 PM, Jean Delvare kh...@linux-fr.org wrote: Hi Gao, I'm adding the linux-i2c list to Cc. On Thu, 4 Feb 2010 14:04:03 +0800, zhangfei gao wrote: We found type of i2c_msg.len is __u16, while parameter count in i2c_master_send is int. The mismatch will truncate

Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread Eric Miao
How about return error in i2c_master_send i2c_master_recv when count is bigger than 64K, as suggested by Ben. I think that's more preferable. Making the count parameter as u16, though is going to generate a warning, yet that's usually ignored by careless programmer, screaming out when this

Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread Jean Delvare
On Thu, 4 Feb 2010 04:47:41 -0800, Eric Miao wrote: How about return error in i2c_master_send i2c_master_recv when count is bigger than 64K, as suggested by Ben. I think that's more preferable. Making the count parameter as u16, though is going to generate a warning, yet that's usually

Re: [PATCH] i2c: Hook up runtime PM support

2010-02-04 Thread Rafael J. Wysocki
On Wednesday 03 February 2010, Mark Brown wrote: Allow I2C drivers to make use of the runtime PM framework by adding bus implementations of the runtime PM operations. These simply immediately suspend when the device is idle. Perhaps it would be a good idea to give the driver a chance to veto

Re: [PATCH 1/1] fix i2c_msg.len not aligning with i2c_master_send

2010-02-04 Thread zhangfei gao
On Thu, Feb 4, 2010 at 9:14 PM, Jean Delvare kh...@linux-fr.org wrote: On Thu, 4 Feb 2010 04:47:41 -0800, Eric Miao wrote: How about return error in i2c_master_send i2c_master_recv when count is bigger than 64K, as suggested by Ben. I think that's more preferable. Making the count