Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-15 Thread Karol Lewandowski
On 14.03.2012 18:29, Mark Brown wrote: On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote: - replace s3c24xx_i2c_type enum with plain unsigned int that can hold not only device type but also hw revision-specific quirks Would it not be clearer to just have explicit flags

Re: [PATCH v3 1/6] regmap: add support for 7_25 format

2012-03-15 Thread Mark Brown
On Thu, Mar 15, 2012 at 07:43:05AM +1100, Marc Reilly wrote: This adds support for devices with 7 address bits and 25 data bits. The initial intended user for this are the mc13xxx mfds in spi mode. (The 25th data bit is actually a dummy bit) Signed-off-by: Marc Reilly m...@cpdesign.com.au

Re: [PATCH v3 2/6] regmap: Add support for device with 24 data bits.

2012-03-15 Thread Mark Brown
On Thu, Mar 15, 2012 at 07:43:06AM +1100, Marc Reilly wrote: Add support for devices with 24 data bits. Not sure what you generated this patch against but it doesn't apply to my topic/core or against -next. Please regenerate it against topic/core, it looks good. signature.asc Description:

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-15 Thread Mark Brown
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote: Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original attempt to solve this issue. However, this required adding explicit checks to driver code all over the place (if (type == S3C2400 || type ==

Re: [PATCH v3 6/6] mfd: mc13xxx: Add i2c driver

2012-03-15 Thread Shubhrajyoti Datta
Hi Marc, On Thu, Mar 15, 2012 at 2:13 AM, Marc Reilly m...@cpdesign.com.au wrote: Adds support for mc13xxx family ICs connected via i2c. Signed-off-by: Marc Reilly m...@cpdesign.com.au --- snip +static int mc13xxx_i2c_probe(struct i2c_client *client, +               const struct

Re: [PATCH] i2c-algo-bit: Fix spurious SCL timeouts under heavy load

2012-03-15 Thread Jean Delvare
Hi Ville, On Wed, 14 Mar 2012 10:32:52 +0200, Ville Syrjälä wrote: When the system is under heavy load, there can be a significant delay between the getscl() and time_after() calls inside sclhi(). That delay may cause the time_after() check to trigger after SCL has gone high, causing sclhi()

[PATCH 0/2] i2c-tools: Clean up linux/i2c-dev.h

2012-03-15 Thread Jean Delvare
For years now, project i2c-tools has been carrying a modified copy of linux/i2c-dev.h for use by user-space applications accessing /dev/i2c-* device nodes. The modified copy includes parts of linux/i2c.h as well as i2c_smbus_*() inline functions mimicking their kernel counterparts. Why it was

[PATCH 1/2] i2c-tools: Clean up linux/i2c-dev.h

2012-03-15 Thread Jean Delvare
Minimize differences between kernel and user-space flavors of linux/i2c-dev.h. --- include/linux/i2c-dev.h | 60 +-- 1 file changed, 27 insertions(+), 33 deletions(-) --- i2c-tools.orig/include/linux/i2c-dev.h 2010-12-12 14:22:33.0

[PATCH 2/2] Split i2c-dev.h into parts

2012-03-15 Thread Jean Delvare
Properly split i2c-dev.h into parts: * The i2c_smbus_* inline functions go to a dedicated user-space header file for now (and later to a library.) * The parts from the kernel's i2c.h go away, and applications will include linux/i2c.h explicitly from now on. * The parts from the kernel's

Re: [PATCH] i2c-algo-bit: Fix spurious SCL timeouts under heavy load

2012-03-15 Thread Ville Syrjälä
On Thu, Mar 15, 2012 at 03:32:40PM +0100, Jean Delvare wrote: Hi Ville, On Wed, 14 Mar 2012 10:32:52 +0200, Ville Syrjälä wrote: When the system is under heavy load, there can be a significant delay between the getscl() and time_after() calls inside sclhi(). That delay may cause the

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-15 Thread Karol Lewandowski
On 15.03.2012 13:56, Mark Brown wrote: On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote: Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original attempt to solve this issue. However, this required adding explicit checks to driver code all over the place (if

[PATCH] i2c-dev: Add support for I2C_M_RECV_LEN

2012-03-15 Thread Jean Delvare
As the bus driver side implementation of I2C_M_RECV_LEN is heavily tied to SMBus, we can't support received length over 32 bytes, but let's at least support that. In practice, the caller will have to setup a buffer large enough to cover the case where received length byte has value 32, so minimum

Re: [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access

2012-03-15 Thread Mark Brown
On Thu, Mar 15, 2012 at 07:43:08AM +1100, Marc Reilly wrote: This change converts the mc13xxx core to use regmap rather than direct spi r/w. The spidev member of mc13xxx struct becomes redundant and is removed. Extra debugging aids are added to mc13xxx_reg_rmw. Mutex init is moved to before

[PATCH] i2c: Add clk_prepare/clk_unprepare calls to i2c-pxa

2012-03-15 Thread Philipp Zabel
This patch adds clk_prepare/clk_unprepare calls to the i2c-pxa driver by using the helper functions clk_prepare_enable and clk_disable_unprepare. Signed-off-by: Philipp Zabel philipp.za...@gmail.com Cc: Haojian Zhuang haojian.zhu...@marvell.com Cc: Eric Miao eric.y.m...@gmail.com Cc: Jean Delvare

[GIT PULL] i2c fixes for Linux 3.3

2012-03-15 Thread Jean Delvare
Hi Linus, Please pull i2c subsystem fixes for Linux 3.3 from: git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging.git i2c-for-linus drivers/i2c/algos/i2c-algo-bit.c |8 +++- drivers/i2c/i2c-core.c | 12 2 files changed, 15 insertions(+), 5