Re: [Patch V6] i2c: imx: add runtime pm support to improve the performance

2015-08-31 Thread Heiner Kallweit
Am 28.08.2015 um 08:30 schrieb Gao Pan: > In our former i2c driver, i2c clk is enabled and disabled in > xfer function, which contributes to power saving. However, > the clk enable process brings a busy wait delay until the core > is stable. As a result, the performance is sacrificed. > > To

Re: [Patch V5] i2c: imx: add runtime pm support to improve the performance

2015-08-27 Thread Heiner Kallweit
Am 27.08.2015 um 09:06 schrieb Gao Pandy: From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Thursday, August 27, 2015 1:50 PM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de

Re: [Patch V5] i2c: imx: add runtime pm support to improve the performance

2015-08-26 Thread Heiner Kallweit
Am 26.08.2015 um 07:23 schrieb Gao Pan: In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the

Re: [Patch V5] i2c: imx: add runtime pm support to improve the performance

2015-08-26 Thread Heiner Kallweit
Am 27.08.2015 um 06:01 schrieb Gao Pandy: From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Thursday, August 27, 2015 2:52 AM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de

Re: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Heiner Kallweit
Am 25.08.2015 um 04:20 schrieb Gao Pan: In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the

Re: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Heiner Kallweit
Am 25.08.2015 um 13:09 schrieb Gao Pandy: From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Tuesday, August 25, 2015 2:37 PM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de

i2c imx: suspicious use of runtime PM calls

2015-08-22 Thread Heiner Kallweit
Just by chance I stumbled across this driver and the recently added runtime PM code. Two things in i2c_imx_probe look suspicious to me: - You activate the I2C clock and then initialize runtime PM with pm_runtime_enable(pdev-dev); pm_runtime_set_autosuspend_delay(pdev-dev,