Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-08-13 Thread Alexander Sverdlin
Hello Wolfram, On 12/08/15 10:43, ext Wolfram Sang wrote: My opinion - it's time for compatible string :) ti,keystone-i2c. Especially taking int account two things: 1) In Datasheet SPRS893B TCI6630K2L Multicore DSP+ARM KeyStone II System-on-Chip (SoC) (Rev. E) values for those

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-08-12 Thread Wolfram Sang
On Fri, Jul 10, 2015 at 09:26:30PM +0300, Grygorii Strashko wrote: Hi, On 07/10/2015 07:02 PM, Sekhar Nori wrote: On Friday 10 July 2015 01:23 AM, Wolfram Sang wrote: On Thu, Jun 18, 2015 at 12:22:33PM -0400, Murali Karicheri wrote: On 06/18/2015 05:00 AM, Sekhar Nori wrote: On Thursday

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-07-10 Thread Grygorii Strashko
Hi, On 07/10/2015 07:02 PM, Sekhar Nori wrote: On Friday 10 July 2015 01:23 AM, Wolfram Sang wrote: On Thu, Jun 18, 2015 at 12:22:33PM -0400, Murali Karicheri wrote: On 06/18/2015 05:00 AM, Sekhar Nori wrote: On Thursday 18 June 2015 02:23 PM, Alexander Sverdlin wrote: According to KeyStone

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-07-10 Thread Sekhar Nori
On Friday 10 July 2015 01:23 AM, Wolfram Sang wrote: On Thu, Jun 18, 2015 at 12:22:33PM -0400, Murali Karicheri wrote: On 06/18/2015 05:00 AM, Sekhar Nori wrote: On Thursday 18 June 2015 02:23 PM, Alexander Sverdlin wrote: According to KeyStone Architecture I2C User Guide,

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Alexander Sverdlin
Hello! On 18/06/15 13:12, ext Sekhar Nori wrote: Ah, beyond the evalboards, there are device-trees not linked into the kernel, but flashed into the boards, as originally in OF. They are part of the HW, its description. Not part or description of the Kernel. And you have no way to

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Sekhar Nori
On Thursday 18 June 2015 03:34 PM, Alexander Sverdlin wrote: Hi! On 18/06/15 11:47, ext Sekhar Nori wrote: Ah, beyond the evalboards, there are device-trees not linked into the kernel, but flashed into the boards, as originally in OF. They are part of the HW, its description. Not part

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Murali Karicheri
On 06/18/2015 05:00 AM, Sekhar Nori wrote: On Thursday 18 June 2015 02:23 PM, Alexander Sverdlin wrote: According to KeyStone Architecture I2C User Guide, module clock frequency master clock frequency = -- (ICCL + 6) +

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Alexander Sverdlin
Hi! On 18/06/15 11:47, ext Sekhar Nori wrote: Ah, beyond the evalboards, there are device-trees not linked into the kernel, but flashed into the boards, as originally in OF. They are part of the HW, its description. Not part or description of the Kernel. And you have no way to introduce

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Alexander Sverdlin
Hi! On 18/06/15 11:00, ext Sekhar Nori wrote: +if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) { + dev_dbg(dev-dev, Keystone SoC detected\n); + d = 6; + } I think its better to use a different compatible string for i2c on keystone devices rather

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Sekhar Nori
Hi Alexander, On Thursday 18 June 2015 02:39 PM, Alexander Sverdlin wrote: Hi! On 18/06/15 11:00, ext Sekhar Nori wrote: + if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) { + dev_dbg(dev-dev, Keystone SoC detected\n); + d = 6; + } I think its better

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Alexander Sverdlin
Hello! On 18/06/15 11:25, ext Sekhar Nori wrote: + if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) { +dev_dbg(dev-dev, Keystone SoC detected\n); +d = 6; +} I think its better to use a different compatible string for i2c on keystone devices

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Sekhar Nori
On Thursday 18 June 2015 03:07 PM, Alexander Sverdlin wrote: Hello! On 18/06/15 11:25, ext Sekhar Nori wrote: + if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) { +dev_dbg(dev-dev, Keystone SoC detected\n); +d = 6; +} I think its better to use a

[PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Alexander Sverdlin
According to KeyStone Architecture I2C User Guide, module clock frequency master clock frequency = -- (ICCL + 6) + (ICCH + 6) i.e. d in i2c_davinci_calc_clk_dividers() should be fixed and not dependent from module clock

Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

2015-06-18 Thread Sekhar Nori
On Thursday 18 June 2015 02:23 PM, Alexander Sverdlin wrote: According to KeyStone Architecture I2C User Guide, module clock frequency master clock frequency = -- (ICCL + 6) + (ICCH + 6) i.e. d in