Re: [PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-12 Thread Eric Miao
On Sun, Apr 4, 2010 at 10:08 PM, Wolfram Sang w.s...@pengutronix.de wrote: The timeout value is in jiffies, so it should be using HZ, not a plain number. Assume '100' means 100ms here and adapt accordingly. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Eric Miao eric.y.m...@gmail.com

Re: [PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-12 Thread Russell King - ARM Linux
On Mon, Apr 12, 2010 at 09:13:19PM +0200, Jean Delvare wrote: On Tue, 13 Apr 2010 01:57:51 +0800, Eric Miao wrote: On Sun, Apr 4, 2010 at 10:08 PM, Wolfram Sang w.s...@pengutronix.de wrote: The timeout value is in jiffies, so it should be using HZ, not a plain number. Assume '100' means

Re: [PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-12 Thread Russell King - ARM Linux
On Mon, Apr 12, 2010 at 09:32:35PM +0200, Jean Delvare wrote: On Mon, 12 Apr 2010 20:20:10 +0100, Russell King - ARM Linux wrote: On Mon, Apr 12, 2010 at 09:13:19PM +0200, Jean Delvare wrote: On Tue, 13 Apr 2010 01:57:51 +0800, Eric Miao wrote: One other better and cleaner approach to

Re: [PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-12 Thread Jamie Lokier
Russell King - ARM Linux wrote: On Mon, Apr 12, 2010 at 09:32:35PM +0200, Jean Delvare wrote: On Mon, 12 Apr 2010 20:20:10 +0100, Russell King - ARM Linux wrote: On Mon, Apr 12, 2010 at 09:13:19PM +0200, Jean Delvare wrote: On Tue, 13 Apr 2010 01:57:51 +0800, Eric Miao wrote: One

Re: [PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-12 Thread Eric Miao
On Tue, Apr 13, 2010 at 5:53 AM, Jamie Lokier ja...@shareable.org wrote: Russell King - ARM Linux wrote: On Mon, Apr 12, 2010 at 09:32:35PM +0200, Jean Delvare wrote: On Mon, 12 Apr 2010 20:20:10 +0100, Russell King - ARM Linux wrote: On Mon, Apr 12, 2010 at 09:13:19PM +0200, Jean Delvare

[PATCH] mach-pxa/viper: Fix timeout usage for I2C

2010-04-04 Thread Wolfram Sang
The timeout value is in jiffies, so it should be using HZ, not a plain number. Assume '100' means 100ms here and adapt accordingly. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Eric Miao eric.y.m...@gmail.com Cc: Russell King li...@arm.linux.org.uk Cc: Marc Zyngier m...@misterjones.org