Re: [PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe()

2015-10-15 Thread Wolfram Sang
> Although I don't think there is any need to add clearing to probe path as > clearing happens beginning of transmit before enabling the interrupts. Well, in case the firmware left interrupts dangling, they would still be dangling unless someone starts some communication. Chances are small, but

Re: [PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe()

2015-10-10 Thread Wolfram Sang
On Mon, Aug 31, 2015 at 05:31:28PM +0300, Jarkko Nikula wrote: > There is no need to clear interrupts in i2c_dw_pci_probe() since only place > where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts > are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always > clear

[PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe()

2015-08-31 Thread Jarkko Nikula
There is no need to clear interrupts in i2c_dw_pci_probe() since only place where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always clear interrupts before enabling them"). This allows to cleanup the code and