Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-30 Thread Laurent Pinchart
Hi Geert, On Friday 30 October 2015 09:16:40 Geert Uytterhoeven wrote: > On Fri, Oct 30, 2015 at 5:35 AM, Laurent Pinchart wrote: > > [9.641533] Unable to handle kernel paging request at virtual address > > > > [9.648927] pgd = eb2adf40 > > [9.651695] [] *pgd=80400

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-30 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Oct 30, 2015 at 5:35 AM, Laurent Pinchart wrote: > [9.641533] Unable to handle kernel paging request at virtual address > > [9.648927] pgd = eb2adf40 > [9.651695] [] *pgd=8040007003, *pmd=6bfde003, *pte= > [9.658579] Internal error:

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-30 Thread Wolfram Sang
> First of all, I got one kernel panic. :( I am starting to think i should revert my last i2c-rcar series until these issues are gone... > I have also seen different errors: > > [1.177690] i2c-rcar e653.i2c: error -16 : 0 > [1.182534] adv7511: probe of 2-0039 failed with error -16 >

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. I'm afraid this doesn't make any noticeable difference. With or without the patch applied the adv7511 can't be detected using the latest driver tag (renesas-devel-20151026-v4.3-rc7). However, I have a bit more information to report. First of all, I got one

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Kuninori Morimoto
Hi Wolfram Sang wrote: > > From: Wolfram Sang > > Reported-by: Kuninori Morimoto > Signed-off-by: Wolfram Sang > --- Please add explain why this patch is needed, and what happen without this patch. And my previous patch didn't explain this, but please add 93c659d820ef291f6ca5e628f44b26cfb222

[PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Wolfram Sang
From: Wolfram Sang Reported-by: Kuninori Morimoto Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 616433d387cdb2..58dbd30c24d1cc 1